From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D776A0C57; Mon, 1 Nov 2021 16:03:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4266A40E28; Mon, 1 Nov 2021 16:03:48 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 07D6D40DF6 for ; Mon, 1 Nov 2021 16:03:45 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="230885272" X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="230885272" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 08:03:42 -0700 X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="488684009" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.16.121]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Nov 2021 08:03:41 -0700 Date: Mon, 1 Nov 2021 15:03:38 +0000 From: Bruce Richardson To: Ben Magistro Cc: dev@dpdk.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] Overriding rte_config.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 29, 2021 at 09:48:30AM -0400, Ben Magistro wrote: > With the transition to meson, what is the best way to provide custom values > to parameters in rte_config.h? When using makefiles, (from memory, I > think) we used common_base as a template that was copied in as a > replacement for defconfig_x86.... Our current thinking is to apply a > locally maintained patch so that we can track custom values easier to the > rte_config.h file unless there is another way to pass in an overridden > value. As an example, one of the values we are customizing is > IP_FRAG_MAX_FRAG. > > Cheers, > There is no one defined way for overriding values in rte_config with the meson build system, as values there are ones that should rarely need to be overridden. If it's the case that one does need tuning, we generally want to look to either change the default so it works for everyone, or alternatively look to replace it with a runtime option. In the absense of that, a locally maintained patch may be reasonable. To what value do you want to change MAX_FRAG? Would it be worth considering as a newer default value in DPDK itself, since the current default is fairly low?