From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 38F13A0C4E;
	Tue,  2 Nov 2021 19:05:18 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EE0344069F;
	Tue,  2 Nov 2021 19:05:17 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by mails.dpdk.org (Postfix) with ESMTP id 92C3240689
 for <dev@dpdk.org>; Tue,  2 Nov 2021 19:05:15 +0100 (CET)
X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="231589945"
X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="231589945"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Nov 2021 11:05:14 -0700
X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="500685893"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.3.189])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 02 Nov 2021 11:05:13 -0700
Date: Tue, 2 Nov 2021 18:05:09 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Message-ID: <YYF91cynVwsyDnGy@bricha3-MOBL.ger.corp.intel.com>
References: <20211022205531.9966-1-david.marchand@redhat.com>
 <YXkihM9d8ksnxJxV@bricha3-MOBL.ger.corp.intel.com>
 <CAJFAV8wrjWX7TOzNZaWyrgmRx861N46i3PStSJQtQygKfz6b9w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8wrjWX7TOzNZaWyrgmRx861N46i3PStSJQtQygKfz6b9w@mail.gmail.com>
Subject: Re: [dpdk-dev] [PATCH] devtools: refuse indent with tabs in Meson
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Nov 02, 2021 at 06:48:07PM +0100, David Marchand wrote:
> On Wed, Oct 27, 2021 at 11:57 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > I wonder is there ever any scenario where we want to allow tabs on a line?
> > If not, then rather than using regex, the check could be simplified to:
> >
> >         if '\t' in line:
> 
> I am not sure.
> I considered cases with tabs in log messages.
> 
Ok. I think we'd live without tabs in log messages if we had to, but for
now your version is safer as it allows us to keep everything else
unchanged.

/Bruce