From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1046A034F; Wed, 10 Nov 2021 18:34:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD3074113C; Wed, 10 Nov 2021 18:34:14 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D0FB540DDA for ; Wed, 10 Nov 2021 18:34:13 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10164"; a="293552244" X-IronPort-AV: E=Sophos;i="5.87,224,1631602800"; d="scan'208";a="293552244" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 09:34:12 -0800 X-IronPort-AV: E=Sophos;i="5.87,224,1631602800"; d="scan'208";a="589432792" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.18.229]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 10 Nov 2021 09:34:10 -0800 Date: Wed, 10 Nov 2021 17:34:07 +0000 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, bluca@debian.org, tredaelli@redhat.com, i.maximets@ovn.org, james.r.harris@intel.com, mohammed@hawari.fr Subject: Re: [PATCH 5/5] build: select optional libraries Message-ID: References: <20211110164814.5231-1-david.marchand@redhat.com> <20211110164814.5231-6-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211110164814.5231-6-david.marchand@redhat.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 10, 2021 at 05:48:14PM +0100, David Marchand wrote: > There is currently no way to know which libraries are optional. > Introduce a enable_libs option (close to what we have for drivers) so > that packagers or projects consuming DPDK can more easily select the > optional libraries that matter to them and disable other optional > libraries. > > Note: the enabled_libs variable is renamed for sake of consistency. > > Signed-off-by: David Marchand > --- This is the only patch of this set I would have some concerns about. I'm just not sure that it makes sense to have this option for libraries compared to drivers. Specifically: * We have over 200 drivers in DPDK (rough count using find), of which 2 are mandatory, and therefore specifying just 1 or 2 that you want can make sense. * On the other hand, we have 53 libraries, of which only 7 or so (after this patchset) are optional. This means that use of the term "enable_libs" is misleading - at least to me - in that it's only a very small proportion of the libs which would be affected by that flag (compared to 99% of the drivers) * Also, while the number of mandatory drivers is unlikely to change much (since there are only 2), it should be fairly safe to do builds using "--enable-drivers". On the other hand, the list of libraries affected by "--enable-libs" is likely to change, so short of each user naming each and every lib they use (and each library those depend on), to the list, it's quite possible that any --enable-libs use could lead to a broken build in future if a library changes from mandatory to optional. Overall, I'm just concerned that this flag is premature, and would prefer to keep it just to the disable option until we are confident that out "optional library" list is relatively settled. /Bruce