From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 978EEA0C52; Wed, 24 Nov 2021 15:29:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 533B240E78; Wed, 24 Nov 2021 15:29:43 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id B83A24003C for ; Wed, 24 Nov 2021 15:29:40 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10177"; a="222508267" X-IronPort-AV: E=Sophos;i="5.87,260,1631602800"; d="scan'208";a="222508267" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2021 06:29:13 -0800 X-IronPort-AV: E=Sophos;i="5.87,260,1631602800"; d="scan'208";a="674874720" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.34]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 24 Nov 2021 06:29:12 -0800 Date: Wed, 24 Nov 2021 14:29:08 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Subject: Re: [PATCH v2] config: sort Meson options by categories Message-ID: References: <20211025161736.12689-1-thomas@monjalon.net> <20211124125642.1322551-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211124125642.1322551-1-thomas@monjalon.net> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 24, 2021 at 01:56:42PM +0100, Thomas Monjalon wrote: > Options used to be sorted alphabetically. > It looks easier to read when major options are first, > then path tuning, libs options, and drivers options. > > Signed-off-by: Thomas Monjalon > --- > v2: add blank lines for readability > --- > meson_options.txt | 99 ++++++++++++++++++++++++++++++----------------- > 1 file changed, 63 insertions(+), 36 deletions(-) While I like the idea of being able to group items, in the absense of meson support for displaying them as groups, I worry about it making it harder to find and use options. It also has some ambiguity as to what should be in what category: e.g. is max_lcores a global option or a library-specific one for EAL. I would have considered it global, but you have it here as library specific - which when I think about it is probably more correct, just not what I thought of instinctively. On the other hand, I agree that having them sorted alphabetically is not brilliant either - I think I originally chose to order them alphabetically so as to avoid arguments as to where exactly each option should go, since it makes things unambiguous. Overall, I'm fairly ambivilant about this patch, but would appreciate more input from others, and I'm happy with whatever the majority decision is. /Bruce