From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Lance Richardson <lance.richardson@broadcom.com>,
Ji@dpdk.org, Kai <kai.ji@intel.com>,
Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>
Subject: Re: [PATCH v2] hash: fix thash gfni implementation
Date: Tue, 16 Nov 2021 14:10:23 +0000 [thread overview]
Message-ID: <YZO7z0JgzOfdHZnK@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8zeV8pynG8XevRNCFVn5jqTro-zO7mV4gc5r_VNDBgAFQ@mail.gmail.com>
On Tue, Nov 16, 2021 at 02:53:49PM +0100, David Marchand wrote:
> On Fri, Nov 12, 2021 at 3:17 PM Vladimir Medvedkin
> <vladimir.medvedkin@intel.com> wrote:
> >
> > 1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32
> > due to the lack of support by some compilers.
>
> Ok, it was the initial report from Lance.
>
> > 2. This patch checks if AVX512F is supported along with GFNI.
> > This is done if the code is built on a platform that supports GFNI,
> > but does not support AVX512.
>
> Ok.
>
> > 3. Also this patch fixes compilation problems on 32bit arch due to
> > lack of support for _mm_extract_epi64() by implementing XOR folding
> > with _mm_extract_epi32() on 32-bit arch.
>
> This code is under a #if defined(__GFNI__) && defined(__AVX512F__).
>
> Does such a 32 bits processor exist, that supports AVX512 and GFNI?
>
The processor would be 64-bit but the code could well be 32-bit, and even
then can still use these AVX512 instruction sets.
/Bruce
next prev parent reply other threads:[~2021-11-16 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 17:24 [dpdk-dev] [PATCH] " Vladimir Medvedkin
2021-11-09 17:34 ` Lance Richardson
2021-11-09 18:08 ` Ji, Kai
2021-11-12 14:17 ` [PATCH v2] " Vladimir Medvedkin
2021-11-16 13:53 ` David Marchand
2021-11-16 14:08 ` Walsh, Conor
2021-11-16 14:10 ` Bruce Richardson [this message]
2021-11-16 14:17 ` David Marchand
2021-11-16 14:18 ` Medvedkin, Vladimir
2021-11-16 14:33 ` [PATCH v3] " Vladimir Medvedkin
2021-11-17 9:20 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZO7z0JgzOfdHZnK@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Ji@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=lance.richardson@broadcom.com \
--cc=sameh.gobriel@intel.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).