DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Elena Agostini <eagostini@nvidia.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine
Date: Wed, 17 Nov 2021 08:55:39 +0000	[thread overview]
Message-ID: <YZTDi5qSEPxPHZA5@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CALBAE1P+rZ1n8d3qsZZ1wqUO8OA_uxXZXN7A+iFUwb2izpLiKg@mail.gmail.com>

On Wed, Nov 17, 2021 at 12:51:13AM +0530, Jerin Jacob wrote:
> On Wed, Nov 17, 2021 at 12:44 AM Elena Agostini <eagostini@nvidia.com> wrote:
> >
> > > From: Jerin Jacob <jerinjacobk@gmail.com>
> >
> > > Date: Tuesday, 16 November 2021 at 20:09
> >
> > > To: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > > Cc: Elena Agostini <eagostini@nvidia.com>, dev@dpdk.org <dev@dpdk.org>, Slava Ovsiienko <viacheslavo@nvidia.com>
> >
> > > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine
> >
> > > External email: Use caution opening links or attachments
> >
> > >
> >
> > >
> >
> > > On Tue, Nov 16, 2021 at 11:42 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > > >
> >
> > > > On 11/16/2021 6:06 PM, Elena Agostini wrote:
> >
> > > > >  > From: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > > > >
> >
> > > > >  > Date: Tuesday, 16 November 2021 at 19:00
> >
> > > > >
> >
> > > > >  > To: Elena Agostini <eagostini@nvidia.com>
> >
> > > > >
> >
> > > > >  > Cc: dev@dpdk.org <dev@dpdk.org>, Slava Ovsiienko <viacheslavo@nvidia.com>
> >
> > > > >
> >
> > > > >  > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine
> >
> > > > >
> >
> > > > >  > External email: Use caution opening links or attachments>
> >
> > > > >
> >
> > > > >  >
> >
> > > > >
> >
> > > > >  > On 11/11/2021 9:41 PM, eagostini@nvidia.com wrote:
> >
> > > > >
> >
> > > > >  > > --- a/app/test-pmd/meson.build
> >
> > > > >
> >
> > > > >  > > +++ b/app/test-pmd/meson.build
> >
> > > > >
> >
> > > > >  > > @@ -32,7 +32,7 @@ if dpdk_conf.has('RTE_HAS_JANSSON')
> >
> > > > >
> >
> > > > >  > >       ext_deps += jansson_dep
> >
> > > > >
> >
> > > > >  > >   endif
> >
> > > > >
> >
> > > > >  > >
> >
> > > > >
> >
> > > > >  > > -deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci']
> >
> > > > >
> >
> > > > >  > > +deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci', 'gpudev']>
> >
> > > > >
> >
> > > > >  > I didn't review the set, but in a very high level do we want to add
> >
> > > > >
> >
> > > > >  > 'gpudev' as dependency? Isn't this like adding 'rawdev' as dependency.
> >
> > > > >
> >
> > > > > gpudev is a library that can be built without a gpu driver as all the other libraries
> >
> > > > >
> >
> > > > > and itis actually used only in case of GPU memory mempool.
> >
> > > > >
> >
> > > > > Reasons for this patch are:
> >
> > > > >
> >
> > > > > - Have an upstreamed benchmark tool to measure network metrics using GPU memory
> >
> > > > >
> >
> > > > > - Test some DPDK features not really tested anywhere like the external memory mempool feature
> >
> > > > >
> >
> > > >
> >
> > > > I can see the reason, that is obvious, yet again why we are not adding rawdev
> >
> > > > testing to the testpmd? But adding gpudev.
> >
> > > > It is easier to add it to the testpmd, and for some testing perspective it
> >
> > > > makes sense, but still I am not quite sure about this new dependency, I would
> >
> > > > like to get more feedback.
> >
> > >
> >
> > > I had the similar concern earlier. IMO, It is better to have a
> >
> > > separate test application for gpudev like
> >
> > > other device classes. For eventdev cases when it needs to work with
> >
> > > ethdev for Rx adapter cases,
> >
> > > We have enabled such code in app/test-eventdev to make testpmd focus on ethdev.
> >
> >
> >
> > gpudev already has a test app in app/test-gpudev.
> >
> >
> >
> > gpudev needs to be also test with network card and today another application
> >
> > decidated to test gpudev over the network would be very similar to testpmd io.
> >
> >
> >
> > At this stage, there is no point in reinventing the wheel
> 
> 
> I think, it is not about not reinventing the wheel, It is about
> maintenance of testpmd,
> currently, the feature are specific to ethdev. Adding more
> cross-device-specific features
> will populate the testpmd. I had a similar case when it network cases
> need to be integrated to eventdev,
> I choose to have it test-eventdev so that testpmd focus remains for ethdev.

Since there is an increasing push for libraries to be able to be disabled
in DPDK, at minimum I would look to have gpudev as an optional dependency
here, so that disabling it would not completely disable building testpmd.

Regards,
/Bruce

  reply	other threads:[~2021-11-17  8:55 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 20:49 [dpdk-dev] [PATCH] " eagostini
2021-11-11 21:41 ` [PATCH v2 0/1] " eagostini
2021-11-11 21:41   ` [PATCH v2 1/1] " eagostini
2021-11-16 16:28     ` Slava Ovsiienko
2021-11-16 17:16       ` Ananyev, Konstantin
2021-11-16 18:15         ` Elena Agostini
2021-11-16 17:55     ` Ferruh Yigit
2021-11-16 18:06       ` Elena Agostini
2021-11-16 18:11         ` Ferruh Yigit
2021-11-16 19:09           ` Jerin Jacob
2021-11-16 19:14             ` Elena Agostini
2021-11-16 19:21               ` Jerin Jacob
2021-11-17  8:55                 ` Bruce Richardson [this message]
2021-11-17  3:04 ` [PATCH v3 0/1] app/testpmd: add GPU memory option for mbuf pools eagostini
2021-11-17  3:04   ` [PATCH v3 1/1] " eagostini
2021-11-16 21:34     ` Stephen Hemminger
2021-11-17 11:08       ` Elena Agostini
2021-11-17 11:23         ` Jerin Jacob
2021-11-17 11:26           ` Elena Agostini
2021-11-17 11:31             ` Jerin Jacob
2021-11-17 11:48               ` Ferruh Yigit
2021-11-17 12:36                 ` Ananyev, Konstantin
2021-11-17 12:39                   ` Elena Agostini
2021-11-17 13:39                     ` Jerin Jacob
2021-11-17 13:50                       ` Elena Agostini
2021-11-17 14:02                         ` Jerin Jacob
2021-11-17 14:07                           ` Elena Agostini
2021-11-17 17:44                             ` Elena Agostini
2021-11-17 21:49 ` [PATCH v4 0/1] " eagostini
2021-11-17 21:49   ` [PATCH v4 1/1] " eagostini
2021-11-17 14:04     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZTDi5qSEPxPHZA5@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=eagostini@nvidia.com \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinjacobk@gmail.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).