From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C41C0A0C41; Wed, 17 Nov 2021 15:11:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54987410E9; Wed, 17 Nov 2021 15:11:00 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id EDE4940687 for ; Wed, 17 Nov 2021 15:10:58 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10170"; a="232673412" X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="232673412" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2021 06:10:58 -0800 X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="506937266" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.204]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 17 Nov 2021 06:10:57 -0800 Date: Wed, 17 Nov 2021 14:10:53 +0000 From: Bruce Richardson To: eagostini@nvidia.com Cc: dev@dpdk.org Subject: Re: [PATCH v2] build: make gpudev optional Message-ID: References: <20211117203351.6087-1-eagostini@nvidia.com> <20211117213901.26021-1-eagostini@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117213901.26021-1-eagostini@nvidia.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 17, 2021 at 09:39:01PM +0000, eagostini@nvidia.com wrote: > From: Elena Agostini > > This library can be made optional. > drivers/gpu and app/test-gpudev depend on this library, > so there is a check for dependencies. > > Signed-off-by: Elena Agostini > --- > app/test-gpudev/meson.build | 1 + > doc/guides/prog_guide/gpudev.rst | 1 + > drivers/gpu/meson.build | 1 + > lib/meson.build | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/app/test-gpudev/meson.build b/app/test-gpudev/meson.build > index 17bdef3646..02286d3a6a 100644 > --- a/app/test-gpudev/meson.build > +++ b/app/test-gpudev/meson.build > @@ -3,3 +3,4 @@ > > sources = files('main.c') > deps = ['gpudev', 'ethdev'] > + This file and "drivers/gpu/meson.build" file can be removed from the patch, since adding a blank line is unnecessary and is not related to the actual patch changes. When preparing a patch, I'd suggest always double checking that all changes introduced in the patch are intentional, and relevant to the patch itself. If these whitespace fixups are intentional needed, they should be sent as a separate patch just to make reviewing easier and ensure each patch has only one logical change in it. Thanks, /Bruce