From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62838A0C43; Fri, 26 Nov 2021 15:52:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF55D41144; Fri, 26 Nov 2021 15:52:31 +0100 (CET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id 8BB8240DF5 for ; Fri, 26 Nov 2021 15:52:30 +0100 (CET) Received: by mail-wr1-f46.google.com with SMTP id c4so19190019wrd.9 for ; Fri, 26 Nov 2021 06:52:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OS6FZF5JdJVVslGBieZfR8RZbDnqPcTLRYNj4nO5/ys=; b=Wis37r21Y5aMrHjbi9L+HZcGFI6MctdJ4/s9bpNObsU/BTsrSSgXCTTrg3cMRReWQH W/MxfydV9+0XYT5LPSjTWug/ReIaDFCn4HnboxVldNxX3b064fz1pw1Ha8Z2o9CzYpAj uMA1ShLucs5WzOMNo/vu/tbWlJ0xPi+dpC5eud8ZOKI0a4pz3n6c1Erda+QHn9GlDHpE 4OpGoh+h+SasF29n+E6oF/+yEirsvec5QsGVpG7Rl4gUl2KcEzsdekBcxksMQUNzYbnT KjvLUtjjaioQhJc1ljG70XPZUGx/5twrtPjf0x9cIYijqgj/LZJq7ynajUioYQXc7K6o MJ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OS6FZF5JdJVVslGBieZfR8RZbDnqPcTLRYNj4nO5/ys=; b=aczmfraFHpwwiLab2b5rCqwhri4SzLDtQ7Rp+fwWxqphFyuGicppml22wRuOyaJFP+ 6UmeowI57Z6+c5XnheFAoiBlqmEDKR4eP1rRpKHyKZ8Mh9ZIszqL4JpYzwnnlzUrFM+M Ai2oU4RqB/SS9FWtuYhViyguZEP3LAyedFcz1CUGLsEvVoT+5eJI3fLgrWQNDazbINtr ScBrV5bu9Nncve+o+hDOePYzOLwMuoUJB5301LM9tnzWqybqraVzUXrWbuE7Sc7VANPv 2Cd0a6DVyQbOwIWkcyzy8e+a62frFAmeG+ZwUmJKgpGzTVbyM16Z5I2JUOSjEq61L5MQ GOtw== X-Gm-Message-State: AOAM532bwsoqbOo2sEKB34s9fMqpfzPWtMhMm9APT9pcKp4Qlsg40eml SwMKp6E1cJr8tUQp3Y6OwFavhw== X-Google-Smtp-Source: ABdhPJxm1XAAIrNMWDeFkjFq/ay+SbbB4+xE3GcIf7UBXEmnUaRzxxA0cpgnakf4ARGMZpxWkHNZBg== X-Received: by 2002:a5d:618f:: with SMTP id j15mr14034439wru.506.1637938350125; Fri, 26 Nov 2021 06:52:30 -0800 (PST) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id m34sm14758060wms.25.2021.11.26.06.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 06:52:29 -0800 (PST) Date: Fri, 26 Nov 2021 15:52:28 +0100 From: Olivier Matz To: Thomas Monjalon Cc: Viacheslav Ovsiienko , Ferruh Yigit , dev@dpdk.org, hemant.agrawal@nxp.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, andrew.rybchenko@oktetlabs.ru, rahul.lakkireddy@chelsio.com, jerinj@marvell.com, humin29@huawei.com, haiyue.wang@intel.com, ndabilpuram@marvell.com, sthemmin@microsoft.com, sachin.saxena@nxp.com Subject: Re: [PATCH v4] ethdev: deprecate header fields and metadata flow actions Message-ID: References: <20211123075940.5521-1-viacheslavo@nvidia.com> <20211126095116.9882-1-viacheslavo@nvidia.com> <828f220b-1607-94ac-7cae-bb5324d53654@intel.com> <2145893.KXFgBx9ejH@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2145893.KXFgBx9ejH@thomas> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 26, 2021 at 02:06:23PM +0100, Thomas Monjalon wrote: > 26/11/2021 13:53, Ferruh Yigit: > > On 11/26/2021 9:51 AM, Viacheslav Ovsiienko wrote: > > > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was > > > introduced by [1]. This action provides an unified way > > > to perform various arithmetic and transfer operations over > > > packet network header fields and packet metadata. > > > > > > [1] commit 641dbe4fb053 ("net/mlx5: support modify field flow action") > > > > > > On other side there are a bunch of multiple legacy actions, > > > that can be superseded by the generic MODIFY_FIELD action: > > > > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL sfc > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC bnxt, cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST bnxt, cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_TP_DST cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_DEC_TTL mlx5, sfc > > > RTE_FLOW_ACTION_TYPE_SET_TTL mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST cxgbe, mlx5 > > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ mlx5 > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ mlx5 > > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK mlx5 > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP mlx5 > > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID bnxt, cnxk, cxgbe, enic, > > > mlx5, octeontx2, sfc > > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP bnxt, cnxk, cxgbe, enic, > > > mlx5, octeontx2, sfc > > > RTE_FLOW_ACTION_TYPE_SET_TAG mlx5 > > > RTE_FLOW_ACTION_TYPE_SET_META mlx5 > > > > > > This note deprecates the following RTE Flow actions, > > > as not supported by any of PMDs: > > > > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > > > > > > The following actions are supposed to be deprecated in 22.07 > > > and replaced by generic field modify action: > > > > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST > > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC > > > RTE_FLOW_ACTION_TYPE_SET_TP_DST > > > RTE_FLOW_ACTION_TYPE_DEC_TTL > > > RTE_FLOW_ACTION_TYPE_SET_TTL > > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST > > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ > > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP > > > RTE_FLOW_ACTION_TYPE_SET_TAG > > > RTE_FLOW_ACTION_TYPE_SET_META > > > > > > The VLAN set actions are interrelated to VLAN header insertion/removal > > > and supported by multiple PMDs and widely used by applications and > > > not supposed to be deprecated due to potential large impact on > > > drivers and applications. > > > > > > Signed-off-by: Viacheslav Ovsiienko > > > > Thanks for the update, > > Acked-by: Ferruh Yigit > > > > > > We need to follow with relevant PMD maintainers to switch to new > > 'MODIFY_FIELD' action till end of v22.07 release. > > Yes I would like to see them replying here, but seems some are not watching. > I don't want to block this interesting deprecation plan, > so I will merge if few more maintainers involved in ethdev give their ack. > > Acked-by: Thomas Monjalon Acked-by: Olivier Matz