From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A3BEA034E; Wed, 22 Dec 2021 16:23:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C80740687; Wed, 22 Dec 2021 16:23:50 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A3D8740040; Wed, 22 Dec 2021 16:23:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640186629; x=1671722629; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=321jJx60uxCP/E4fsIJ5GE3F/PQQtwmuGrU6DEYrY4U=; b=Wk1HCa+q64UV+IkzveEVPCrjrl391hlhYknbQC+zbEiO6ydeWjRdP0Yw MJGSWVfsnqUSQpmaRBe4eq/ZI3k0QQs4OxmWhNHUnz7HNcUqswMRBVxvW HpxImCcwJR+BM2uX6Pb5R37AcQHmNNdr4KqAKhyZXW8VJPm7jNIZkD0GS OuAROVyP4YcaJk1b4aQARaZm0GJQZdJvnWrkU/6kyTC26IqPe8Q7Pd9+e RLsaKSl3zJRpRIzzaAyCjbNUqskU8e8aR/7cbXUdnO6excgB5gO/AXRzg L+G5CJkOOripMnet0ZxS7lmJkEMrIlfCzGMYUriHVBMr+euIH5ZYcqHO7 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10205"; a="239394276" X-IronPort-AV: E=Sophos;i="5.88,226,1635231600"; d="scan'208";a="239394276" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 07:23:47 -0800 X-IronPort-AV: E=Sophos;i="5.88,226,1635231600"; d="scan'208";a="466696954" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.23.107]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 22 Dec 2021 07:23:45 -0800 Date: Wed, 22 Dec 2021 15:23:42 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, stable@dpdk.org, bluca@debian.org Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] doc/examples: fix build on FreeBSD Message-ID: <YcNC/nKaZr3hscwn@bricha3-MOBL.ger.corp.intel.com> References: <20210915173633.59057-1-bruce.richardson@intel.com> <1645178.3i6yeRJgWt@thomas> <YVcsDoruXujCVUTK@bricha3-MOBL.ger.corp.intel.com> <7246004.BAT3AUThdf@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7246004.BAT3AUThdf@thomas> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Nov 17, 2021 at 11:20:17AM +0100, Thomas Monjalon wrote: > 01/10/2021 17:41, Bruce Richardson: > > On Fri, Oct 01, 2021 at 05:36:51PM +0200, Thomas Monjalon wrote: > > > 01/10/2021 17:15, Bruce Richardson: > > > > On Fri, Oct 01, 2021 at 05:03:11PM +0200, Thomas Monjalon wrote: > > > > > 15/09/2021 19:36, Bruce Richardson: > > > > > > On FreeBSD, "find" does not support the "printf" flag, so we > > > > > > need to use "gfind" from the "findutils" package. > > > > > > > > > > It is one more dependency. Shouldn't we avoid it by rewritting > > > > > the shell commands with loops? > > > > > > > > > Probably in the longer term, yes. If I get the chance, I'll try and > > > > rewrite this script, but let's keep this patch in the queue in case > > > > I don't get to in the 21.11 timeframe. > > > > > > OK I can help with the shell tricks if needed. > > > > > Well, I was actually considering a rewrite in python for two reasons: * > > easy FS scans using the "walk()" function * portability across OS's > > [which is the main reason for the work after all] > > Applied this patch for 21.11. > Following up on this thread, implemented an alternative fix for this issue which does not use the extra findutils dependency[1]. I didn't rewrite the script in python as was my original intent, but used basic shell commands to work around the lack of printf support in find, leading to a simpler fix. /Bruce [1] http://patches.dpdk.org/project/dpdk/patch/20211222151855.803916-1-bruce.richardson@intel.com/