[PATCH] eal: log hugepage create errors with filename

[PATCH] eal: log hugepage create errors with filename

[Stephen Hemminger]

While debugging running DPDK service in a container, it is
useful to see which file creation failed.  Don't hide this
failure with DEBUG.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/eal/linux/eal_memalloc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c
index 337f2bc739cf..16b58d861b31 100644
--- a/lib/eal/linux/eal_memalloc.c
+++ b/lib/eal/linux/eal_memalloc.c
@@ -308,8 +308,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi,
 		if (fd < 0) {
 			fd = open(path, O_CREAT | O_RDWR, 0600);
 			if (fd < 0) {
-				RTE_LOG(ERR, EAL, "%s(): open failed: %s\n",
-					__func__, strerror(errno));
+				RTE_LOG(ERR, EAL, "%s(): open '%s' failed: %s\n",
+					__func__, path, strerror(errno));
 				return -1;
 			}
 			/* take out a read lock and keep it indefinitely */
@@ -346,8 +346,8 @@ get_seg_fd(char *path, int buflen, struct hugepage_info *hi,
 
 			fd = open(path, O_CREAT | O_RDWR, 0600);
 			if (fd < 0) {
-				RTE_LOG(DEBUG, EAL, "%s(): open failed: %s\n",
-					__func__, strerror(errno));
+				RTE_LOG(ERR, EAL, "%s(): open '%s' failed: %s\n",
+					__func__, path, strerror(errno));
 				return -1;
 			}
 			/* take out a read lock */
-- 
2.30.2

Re: [PATCH] eal: log hugepage create errors with filename

[Bruce Richardson]

On Thu, Dec 23, 2021 at 11:21:58AM -0800, Stephen Hemminger wrote:
> While debugging running DPDK service in a container, it is
> useful to see which file creation failed.  Don't hide this
> failure with DEBUG.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/eal/linux/eal_memalloc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Should we consider this a bugfix for backporting? Not printing the failing
path seems an omission that should be fixed generally.

Re: [PATCH] eal: log hugepage create errors with filename

[Thomas Monjalon]

07/01/2022 12:53, Bruce Richardson:
> On Thu, Dec 23, 2021 at 11:21:58AM -0800, Stephen Hemminger wrote:
> > While debugging running DPDK service in a container, it is
> > useful to see which file creation failed.  Don't hide this
> > failure with DEBUG.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  lib/eal/linux/eal_memalloc.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Should we consider this a bugfix for backporting? Not printing the failing
> path seems an omission that should be fixed generally.

Yes adding Cc stable

Applied, thanks.