From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D651FA04A2; Fri, 7 Jan 2022 13:07:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6649940140; Fri, 7 Jan 2022 13:07:25 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1DF8940042 for ; Fri, 7 Jan 2022 13:07:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641557244; x=1673093244; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vNf7nJ3fC65cq2azw7VrYH3oiuE5XlXLE6qyuul6RSI=; b=Ut0daEphGk3zZUzfKoZWOlgzgQ4I/hpYK4Cu2caxtv4+H3wR91pGWJj5 Vk6yRUHHs6I8Mq+BmtCpEshRmBV4YnuuV+hIElR78F6IHMx8rR+Ad7cBi pQ0AiYTxl9IfACiFXjilCk2AG/4tXY6yswYpoyiXWp/rxpsykCL9/+g8+ E6asbKNfRhu5mtCF305Rf+VVi5QQ9QavSLjFjIYq7QRUmG5K4qCZP/Dqo 6Ggu8WygUIIo2F7Pp6jbhYaNuhRePeBA7nZJEBn2BrYrfPhPJRGjeUlwd SxiG74+52VCuOcBmt18r5BXF/snlflYbA26ZmcOzz8lUI1mCCHw8l5o4s g==; X-IronPort-AV: E=McAfee;i="6200,9189,10219"; a="230197926" X-IronPort-AV: E=Sophos;i="5.88,269,1635231600"; d="scan'208";a="230197926" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2022 04:07:23 -0800 X-IronPort-AV: E=Sophos;i="5.88,269,1635231600"; d="scan'208";a="761465548" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.26.15]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Jan 2022 04:07:22 -0800 Date: Fri, 7 Jan 2022 12:07:18 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Subject: Re: [RFC] eal: support systemd service convention for runtime directory Message-ID: References: <20211223233907.181033-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211223233907.181033-1-stephen@networkplumber.org> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 23, 2021 at 03:39:07PM -0800, Stephen Hemminger wrote: > Systemd.exec supports configuring the runtime directory of a service > via RuntimeDirectory=. This creates the directory with the necessary > permissions which actual service may not have if running in container. > > The change to DPDK is to look for the environment RUNTIME_DIRECTORY > first and use that in preference to the fallback alternatives. > > Signed-off-by: Stephen Hemminger > --- > lib/eal/linux/eal.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > Seems reasonable. The path lookup for telemetry in the dpdk-telemetry.py script will need updating to match this. Otherwise: Acked-by: Bruce Richardson