From: Olivier Matz <olivier.matz@6wind.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com,
jerinjacobk@gmail.com, dev@dpdk.org
Subject: Re: [PATCH] mempool: fix get objects from mempool with cache
Date: Mon, 24 Jan 2022 17:11:20 +0100 [thread overview]
Message-ID: <Ye7PqLEtLnZilrox@platinum> (raw)
In-Reply-To: <Ye7IEJGmdAclYMeZ@platinum>
On Mon, Jan 24, 2022 at 04:38:58PM +0100, Olivier Matz wrote:
> On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote:
> > --- a/lib/mempool/rte_mempool.h
> > +++ b/lib/mempool/rte_mempool.h
> > @@ -1443,6 +1443,10 @@ rte_mempool_put(struct rte_mempool *mp, void *obj)
> >
> > /**
> > * @internal Get several objects from the mempool; used internally.
> > + *
> > + * If cache is enabled, objects are returned from the cache in Last In First
> > + * Out (LIFO) order for the benefit of CPUs with small L1 cache.
> > + *
> > * @param mp
> > * A pointer to the mempool structure.
> > * @param obj_table
> > @@ -1452,7 +1456,7 @@ rte_mempool_put(struct rte_mempool *mp, void *obj)
> > * @param cache
> > * A pointer to a mempool cache structure. May be NULL if not needed.
> > * @return
> > - * - >=0: Success; number of objects supplied.
> > + * - 0: Success; got n objects.
> > * - <0: Error; code of ring dequeue function.
> > */
> > static __rte_always_inline int
>
> I think that part should be in a separate commit too. This is a
> documentation fix, which is easily backportable (and should be
> backported) (Fixes: af75078fece3 ("first public release")).
I see that the same change is also part of this commit:
https://patches.dpdk.org/project/dpdk/patch/20211223100741.21292-1-chenzhiheng0227@gmail.com/
I think it is better to have a doc fix commit, and remove this chunk
from this patch.
next prev parent reply other threads:[~2022-01-24 16:11 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-26 15:34 [RFC] mempool: rte_mempool_do_generic_get optimizations Morten Brørup
2022-01-06 12:23 ` [PATCH] mempool: optimize incomplete cache handling Morten Brørup
2022-01-06 16:55 ` Jerin Jacob
2022-01-07 8:46 ` Morten Brørup
2022-01-10 7:26 ` Jerin Jacob
2022-01-10 10:55 ` Morten Brørup
2022-01-14 16:36 ` [PATCH] mempool: fix get objects from mempool with cache Morten Brørup
2022-01-17 17:35 ` Bruce Richardson
2022-01-18 8:25 ` Morten Brørup
2022-01-18 9:07 ` Bruce Richardson
2022-01-24 15:38 ` Olivier Matz
2022-01-24 16:11 ` Olivier Matz [this message]
2022-01-28 10:22 ` Morten Brørup
2022-01-17 11:52 ` [PATCH] mempool: optimize put objects to " Morten Brørup
2022-01-19 14:52 ` [PATCH v2] mempool: fix " Morten Brørup
2022-01-19 15:03 ` [PATCH v3] " Morten Brørup
2022-01-24 15:39 ` Olivier Matz
2022-01-28 9:37 ` Morten Brørup
2022-02-02 8:14 ` [PATCH v2] mempool: fix get objects from " Morten Brørup
2022-06-15 21:18 ` Morten Brørup
2022-09-29 10:52 ` Morten Brørup
2022-10-04 12:57 ` Andrew Rybchenko
2022-10-04 15:13 ` Morten Brørup
2022-10-04 15:58 ` Andrew Rybchenko
2022-10-04 18:09 ` Morten Brørup
2022-10-06 13:43 ` Aaron Conole
2022-10-04 16:03 ` Morten Brørup
2022-10-04 16:36 ` Morten Brørup
2022-10-04 16:39 ` Morten Brørup
2022-02-02 10:33 ` [PATCH v4] mempool: fix mempool cache flushing algorithm Morten Brørup
2022-04-07 9:04 ` Morten Brørup
2022-04-07 9:14 ` Bruce Richardson
2022-04-07 9:26 ` Morten Brørup
2022-04-07 10:32 ` Bruce Richardson
2022-04-07 10:43 ` Bruce Richardson
2022-04-07 11:36 ` Morten Brørup
2022-10-04 20:01 ` Morten Brørup
2022-10-09 11:11 ` [PATCH 1/2] mempool: check driver enqueue result in one place Andrew Rybchenko
2022-10-09 11:11 ` [PATCH 2/2] mempool: avoid usage of term ring on put Andrew Rybchenko
2022-10-09 13:08 ` Morten Brørup
2022-10-09 13:14 ` Andrew Rybchenko
2022-10-09 13:01 ` [PATCH 1/2] mempool: check driver enqueue result in one place Morten Brørup
2022-10-09 13:19 ` [PATCH v4] mempool: fix mempool cache flushing algorithm Andrew Rybchenko
2022-10-04 12:53 ` [PATCH v3] mempool: fix get objects from mempool with cache Andrew Rybchenko
2022-10-04 14:42 ` Morten Brørup
2022-10-07 10:44 ` [PATCH v4] " Andrew Rybchenko
2022-10-08 20:56 ` Thomas Monjalon
2022-10-11 20:30 ` Copy-pasted code should be updated Morten Brørup
2022-10-11 21:47 ` Honnappa Nagarahalli
2022-10-30 8:44 ` Morten Brørup
2022-10-30 22:50 ` Honnappa Nagarahalli
2022-10-14 14:01 ` [PATCH v4] mempool: fix get objects from mempool with cache Olivier Matz
2022-10-09 13:37 ` [PATCH v6 0/4] mempool: fix mempool cache flushing algorithm Andrew Rybchenko
2022-10-09 13:37 ` [PATCH v6 1/4] mempool: check driver enqueue result in one place Andrew Rybchenko
2022-10-09 13:37 ` [PATCH v6 2/4] mempool: avoid usage of term ring on put Andrew Rybchenko
2022-10-09 13:37 ` [PATCH v6 3/4] mempool: fix cache flushing algorithm Andrew Rybchenko
2022-10-09 14:31 ` Morten Brørup
2022-10-09 14:51 ` Andrew Rybchenko
2022-10-09 15:08 ` Morten Brørup
2022-10-14 14:01 ` Olivier Matz
2022-10-14 15:57 ` Morten Brørup
2022-10-14 19:50 ` Olivier Matz
2022-10-15 6:57 ` Morten Brørup
2022-10-18 16:32 ` Jerin Jacob
2022-10-09 13:37 ` [PATCH v6 4/4] mempool: flush cache completely on overflow Andrew Rybchenko
2022-10-09 14:44 ` Morten Brørup
2022-10-14 14:01 ` Olivier Matz
2022-10-10 15:21 ` [PATCH v6 0/4] mempool: fix mempool cache flushing algorithm Thomas Monjalon
2022-10-11 19:26 ` Morten Brørup
2022-10-26 14:09 ` Thomas Monjalon
2022-10-26 14:26 ` Morten Brørup
2022-10-26 14:44 ` [PATCH] mempool: cache align mempool cache objects Morten Brørup
2022-10-26 19:44 ` Andrew Rybchenko
2022-10-27 8:34 ` Olivier Matz
2022-10-27 9:22 ` Morten Brørup
2022-10-27 11:42 ` Olivier Matz
2022-10-27 12:11 ` Morten Brørup
2022-10-27 15:20 ` Olivier Matz
2022-10-28 6:35 ` [PATCH v3 1/2] " Morten Brørup
2022-10-28 6:35 ` [PATCH v3 2/2] mempool: optimized debug statistics Morten Brørup
2022-10-28 6:41 ` [PATCH v4 1/2] mempool: cache align mempool cache objects Morten Brørup
2022-10-28 6:41 ` [PATCH v4 2/2] mempool: optimized debug statistics Morten Brørup
2022-10-30 9:09 ` Morten Brørup
2022-10-30 9:16 ` Thomas Monjalon
2022-10-30 9:17 ` [PATCH v4 1/2] mempool: cache align mempool cache objects Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye7PqLEtLnZilrox@platinum \
--to=olivier.matz@6wind.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).