From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16DBBA00C3; Fri, 14 Jan 2022 18:37:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 957DF41178; Fri, 14 Jan 2022 18:37:54 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id ABBC04115A for ; Fri, 14 Jan 2022 18:37:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642181872; x=1673717872; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/BANZZb2VS1cuDIuzqYny3A3qdu6SQTP1VVSGD/Cwgc=; b=RCfhikyPXVeEo/K8eb4Fbt4rkNGhv9kVo2e/eXJVFiHAAEnHrNtUxUOO czcxxyycOvQunBZt7N8AVfXPv7dcJY0Knd0CdRWJM1kMuSBG3yfCOWoGr +nRkaAW2cdhLceJW+/WlQ3+lPdrsLkEKJUuLvldXFY39axun/Aq8/M/e1 IkYpg59Tpq52YudyQJE3QNSoQFGMb52gvEt+WG23XECWH1FML8NMxR4x/ QZPbitzDKwCsGz9MblCl8aJKxe2S/hkTURZESlhsuUr1d/CtPH5gqCJjG vXBCqbgsqvffKYAsfV0eRMJkUSTgD61X1ToYA+99ip1HTqhp9qGETY32u Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10227"; a="307634048" X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="307634048" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 09:37:51 -0800 X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="577344607" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.26.25]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 14 Jan 2022 09:37:49 -0800 Date: Fri, 14 Jan 2022 17:36:51 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: Sean Morrissey , dev@dpdk.org, Conor Fogarty Subject: Re: [PATCH v4 01/53] devtools: script to remove unused headers includes Message-ID: References: <20211007102557.188739-1-sean.morrissey@intel.com> <20220114162409.334437-1-sean.morrissey@intel.com> <20220114162409.334437-2-sean.morrissey@intel.com> <20220114090240.17140845@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220114090240.17140845@hermes.local> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 14, 2022 at 09:02:40AM -0800, Stephen Hemminger wrote: > On Fri, 14 Jan 2022 16:23:17 +0000 > Sean Morrissey wrote: > > > This script can be used for removing headers flagged for removal by the > > include-what-you-use (IWYU) tool. The script has the ability to remove > > headers from specified sub-directories or dpdk as a whole and tests the > > build after each removal by calling meson compile. > > > > example usages: > > > > Remove headers flagged by iwyu_tool output file > > $ ./devtools/process_iwyu.py iwyu.out -b build > > > > Remove headers flagged by iwyu_tool output file from sub-directory > > $ ./devtools/process_iwyu.py iwyu.out -b build -d lib/kvargs > > > > Remove headers directly piped from the iwyu_tool > > $ iwyu_tool -p build | ./devtools/process_iwyu.py - -b build > > > > Signed-off-by: Sean Morrissey > > Signed-off-by: Conor Fogarty > > > > Reviewed-by: Bruce Richardson > > Could this be a shell script instead of python? > That would prevent having to pull in more python library dependencies. Can you clarify what python library dependencies are you concerned about? AFAIK everything in this script is just from the standard built-in python library - Sean, perhaps you can confirm? Converting to shell would lead to something far less readable, IMHO, and it would be less portable to windows too in future. /Bruce