From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD6B5A0352; Wed, 19 Jan 2022 08:49:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57C4840DFD; Wed, 19 Jan 2022 08:49:30 +0100 (CET) Received: from corp-ob08.yahoo-corp.jp (corp-ob08.yahoo-corp.jp [183.79.94.93]) by mails.dpdk.org (Postfix) with ESMTP id A831C4013F for ; Wed, 19 Jan 2022 08:49:28 +0100 (CET) Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01lp2109.outbound.protection.outlook.com [104.47.23.109]) by corp-ob08.yahoo-corp.jp (Postfix) with ESMTPS id 07FA019FB194; Wed, 19 Jan 2022 16:49:27 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo-corp.jp; s=default; t=1642578567; bh=hvH2PtcjHd/+XFOqkIWicf0J/yTziDVtgPvKpLe5RX8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=NsME7wZhvO3r0e14jdd0lvbZfWeinlDEQplgs/S5N1/Fn6AG173aAUymZ5qTOLN4J bViyOYRAw7mqbI8RSp27vJpkwBSI8aQYJhsTMGb5gRcZRdh2plBnZdppNNkgSntDfo l0HNCQhdlycNnOFT4u3UhYS2JVU3QirNaCeNvzHA= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GB4FdjqJlfLvdsk7ZG2b2QkQsph+nrp8sOHRb8Xo+4V3g2dZkRf8x04DvsX931qLICSpKT4D+GVtAsf8fFKQfqkIa8DaYXfyNQtoTHcE7os+jAKKC8IRh2V3fYV4ww7ti6zwpGTmI869vlzep0/S2dXIh+oZ+ervHxAVQkZoxtzu8j7VwznINvQ3D+LoKKFPfLhW/EYS+HQ4UI28lCDzs0bFhMTE/HmXB84Is7E6RpSqdQoUSzLE/Gc+MUCNxU6bRPUmX4TTbQPCb2vWTdkoP0PlYJnrvp6Eq8Fedvnt7lWJv+yERcYJGEm9tdZmx5aURnFtFkxPUltmHiVvV+u1Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hvH2PtcjHd/+XFOqkIWicf0J/yTziDVtgPvKpLe5RX8=; b=bDffas5DW0M9kX3tvo/mIcOLEI97khCTBR+TZGeq6EjgsS89odgQG+cs1vRS9YqHN99hnpQmh4qw3cw5hxtXAWlKVgRPyndb0MikUcjC/ucp8CCDPFXiD/nHdAwMf3CWzxYT1zOY6XmFtr9wdU73UvfhWi4PGyNgZ0teqtbufhMZ76d1dAthQbFQcVvxxWUkk85i1ecGqi9nIzu1uTYY4hUk8+P3qhDX6yoMF9CZi/pNvd+Rh9JH9wf19qQ4OZujDTFnOmKXhqJmxKNpeaIxdbwyAV4rPYHiAAd3Si/7IKf7UOYBTOGjWtP8SFRG1QUzDExDkp/csu2WG3UVNf+OUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=yahoo-corp.jp; dmarc=pass action=none header.from=yahoo-corp.jp; dkim=pass header.d=yahoo-corp.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yjcorp.onmicrosoft.com; s=selector1-yjcorp-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hvH2PtcjHd/+XFOqkIWicf0J/yTziDVtgPvKpLe5RX8=; b=CURg7+a3p4JvI4IZfPa3cdw4QI48Ab8l56S0AtN3ViUhNoSVef7ut8dBFhqyxshs+gMbUXWY105I7mpVH6wyV90zr2T5963wiZe69+uzFVs75c5zZyKzhItm28L6HLPxOzuent3+5CKcm3HJpMP92mp4cm4BO1RqXjeMrJFoWRM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=yahoo-corp.jp; Received: from TY2PR01MB4107.jpnprd01.prod.outlook.com (2603:1096:404:d8::23) by TY2PR01MB2921.jpnprd01.prod.outlook.com (2603:1096:404:75::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Wed, 19 Jan 2022 07:49:26 +0000 Received: from TY2PR01MB4107.jpnprd01.prod.outlook.com ([fe80::b40a:3819:991e:706b]) by TY2PR01MB4107.jpnprd01.prod.outlook.com ([fe80::b40a:3819:991e:706b%4]) with mapi id 15.20.4888.014; Wed, 19 Jan 2022 07:49:26 +0000 Date: Wed, 19 Jan 2022 16:49:19 +0900 From: Nobuhiro MIKI To: Ferruh Yigit Cc: keith.wiles@intel.com, dev@dpdk.org, i.maximets@ovn.org, dmarchan@redhat.com Subject: Re: [PATCH v2 1/1] net/tap: add a check that Rx/Tx have the same num of queues Message-ID: References: <20220112072324.30601-1-nmiki@yahoo-corp.jp> <0b462af2-8dfd-b7a9-074a-a0a8c7397c79@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b462af2-8dfd-b7a9-074a-a0a8c7397c79@intel.com> X-ClientProxiedBy: OS0P286CA0115.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:169::6) To TY2PR01MB4107.jpnprd01.prod.outlook.com (2603:1096:404:d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4fc9a38c-0e2c-4fa3-5ba4-08d9db20370d X-MS-TrafficTypeDiagnostic: TY2PR01MB2921:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UoMl8u2dsKZPIUapOkQIlThNYCH3Rho/+XgSb4pG3yCK/Xw0ZTrsWFj75s6w+m1jm4FMjm4F7cry63b4+wGA21jAdE0QD2k2lQMxa99mrVxH68ToQq2g37S66vO7GmgzIzHd71esPkxBpIHj90VxtkeY90h4s6o4WhmVBfpTa5SoEwSVHmPc8mKZYSxFqMoCy81/t7Zc0i7H66i8/hL/5mcbex4wmV4ZxxSGPJhozooJ1AeTlGekRn72VRThYpjBK+dSJZN2mO/6uA35HCUBwTLuDgeh28UY4NkfEZ4E0sMN0/8yaTrJAx/7TWeOuu6P4k/PVl5k7OcL44glWJkLlKMmfs5BI3NgExe5cKr/Wb14Y9Lhp5LHsISn/EJ6g1kSSRFCcuXMfcvTiHqx72L9h+N36friUz1ILkAniteE86Rno8Fx4DvYNSqBJNKVRcDeCemZ6HyqiooSajsqk16mPdIMl31MrfLlGuxh6WoWL0U+knUBVTEJKZkeC+mmqHg154iClfmu6n5c4H7VhyDjH+89nB1uN+k3Lx/YJSaL5fNsCBktuYKp5LSpDUC2iI417kstD/XUF5U+Nt886A2F9J8PZWtLI8uw79gtw4NMD2P5lxTTF5BsPGVBc3ZNpAgE5aCwFBiFq1oH/Tf7z5FJzaqgBnRN7B85zcwZM2xldgkucCSgSia5xWfrcgDq23dUcxKW/TKe1luuelIJaSGUdQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TY2PR01MB4107.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(82960400001)(66476007)(52116002)(4326008)(86362001)(316002)(5660300002)(83380400001)(6666004)(36756003)(38100700002)(8936002)(2616005)(6486002)(38350700002)(508600001)(53546011)(6512007)(186003)(26005)(6506007)(6916009)(8676002)(66556008)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kCQJvhpa0FU7bhsIAQ/XSEBDCpmYhnuHaMJRvCvWa4/BEzyHxzKGy5pTJ4Li?= =?us-ascii?Q?12sSc9dY9x/SDqvc8nWWfezFggeOG2ao7qa6VIE3V5dGn73sHkU28Pysjycd?= =?us-ascii?Q?Ix3Tuo/Zouufo0FaKShWvWADcKdbkXwzC87xo+5umSmKKIPqw0ZdxyXoEjrm?= =?us-ascii?Q?sDFZfPd6YQsIiK2JAHunjzW40My994yYxNnDu6w7sZb2FmbnO4toFg33HOhe?= =?us-ascii?Q?a3IqZIyHHKFtk01BrgiXm0Xq+yjkMTHJ8KdfhWYzbm0nlp5fe1rVysXE5nHD?= =?us-ascii?Q?KPsIBHxyNeM0W3XRtaCie9rwZ1p4FoXwMhueeBGdcw0+jLFhkttPIXDQ0wNj?= =?us-ascii?Q?l5y8AhnwYX/SCedvtuFdaoSORRhKmGGeah6kmNFRYKHB5wAY2131fF0zmsTT?= =?us-ascii?Q?4szPQ4YEwTNQMd5fc6i0YeLn++zRJAWgwij93kXF5oQO4sopWyQWU9sZU57B?= =?us-ascii?Q?fQgYD6P85qPRPf/nrMeeh1riwGL/8v8hdm4b7Zwof6asr7RJp+ZGfQUBG353?= =?us-ascii?Q?26n4/RPYeA6da1HJNKg+BX0Rnnw1MVsrI88/SoLhWu7Rvm+Hjv4JW5eqGJHE?= =?us-ascii?Q?SWaJtYx4+cSYOh3ld32XyC5/w9fw0sz327uaR+JotGQZVzBr6fydAOGY2BzM?= =?us-ascii?Q?TyniLRpGwio/RqLrb+7Z58+kVkupyrIjlHv4/PhD6rxx+E6lL3NTzuN7t3Hf?= =?us-ascii?Q?DVB9OnuPYZ+I0Kmtw8Yuhk+RHP+GeOW1dQXhA6zDDLZH0RCNhbmGNIvhwNp2?= =?us-ascii?Q?jceD+nLEGJjsk1mbTIx67c6Ip69SiHxWwAJuqm7mrUdtzvAJiHHco4N/Cl5E?= =?us-ascii?Q?yIzcCXDJBypM0/K478rQ8dDyU2D9qSP7tE6cBzYqOoDnGezPL1NBg/5h7CQ8?= =?us-ascii?Q?m634I8OpaDfUFj6ffr9Rfc4S1I/DTd6bLnIKXiuI7lIPMO1Ij1zcDi+4vbqC?= =?us-ascii?Q?37dH7p9QyPHWTNeuzf5dzfunwqQz0RWu1oXLWNWjLFuoXzMppUXy3tWk7wuh?= =?us-ascii?Q?cp9ytNn9CJU388WDCYcVBrc1c/ohWX8hwi4q1ah8q3E9VPASo8+/otbLn4Fh?= =?us-ascii?Q?u3GzyguBldnedejx/Fr7ziqTV+H8PfBdkbsvwOzwdLaq7ltMEs3YAeiwEo6K?= =?us-ascii?Q?kxIhxwJUOJhfoWaHrXzcVUHN6NAmoH7ciV7Rg0JaBjQh3DU2lg0nk4z9GRk2?= =?us-ascii?Q?QAG6kuRXwjkNrlUv+eZzMTCsPMMf3QJhccX0MMfMdGiTh7vnj4+1fLQRfHpP?= =?us-ascii?Q?Izv6T4ZbC00/V/bOIagdlvzzTzvfwPSNty9fD+XgaS0HVMnkqK0e+UKLLfvP?= =?us-ascii?Q?i7qWGK8aM1mqzh56AJUi9RjsY8ULQbjRMHPCYf4iNg6FB+TedZToSvoYRQ0x?= =?us-ascii?Q?0tjCP+L053i1fLC6G5TdvDAdbWSOzRTkTmRcHiRpbEvnZue90w7H+STKARQr?= =?us-ascii?Q?MIYWS/lwWGUQdl0uMmKmpPKoEfi6HVkVX+pP/6phrd4/cLmFdc8cc7LbPJ21?= =?us-ascii?Q?VTe8eO4QdjA0qWSgNLgdt1uH2WP2/eq3WKb7jhaJdwoG2MmrWNlmS2OH1BKW?= =?us-ascii?Q?HKUyo5pGDwauV1711Pfd4pddx6GXfyMbU1pIynWigLWnJURdEtTogO2EVBIK?= =?us-ascii?Q?oVPEinxhhvCPx9MFUC3yWfA=3D?= X-OriginatorOrg: yahoo-corp.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 4fc9a38c-0e2c-4fa3-5ba4-08d9db20370d X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB4107.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 07:49:26.0100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a208d369-cd4e-4f87-b119-98eaf31df2c3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F79h1gVB4b/WlyoTjtsz9rBhg3aRBjCOen7Su3ee8KxL6Vb0tl+tOmO8A6z2pBnXCsTaROMsfFhHfwduAQeXpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB2921 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 18, 2022 at 12:31:51PM +0000, Ferruh Yigit wrote: > On 1/12/2022 7:23 AM, Nobuhiro MIKI wrote: > > Users can create the desired number of RxQ and TxQ in DPDK. For > > example, if the number of RxQ = 2 and the number of TxQ = 5, > > a total of 8 file descriptors will be created for a tap device, > > including RxQ, TxQ, and one for keepalive. The RxQ and TxQ > > with the same ID are paired by dup(2). > > > > In this scenario, Kernel will have 3 RxQ where packets are > > incoming but not read. The reason for this is that there are only > > 2 RxQ that are polled by DPDK, while there are 5 queues in Kernel. > > This patch add a checking if DPDK has appropriate numbers of > > queues to avoid unexpected packet drop. > > > > Signed-off-by: Nobuhiro MIKI > > > It makes sense to add this check, since the driver logic seem already has > the assumption that Rx & Tx queue numbers will be same. > > But can you please update the tap documentation for this limitation/restriction? > 'doc/guides/nics/tap.rst'. Thanks for the review. I've updated doc/guides/nics/tap.rst and sent v3 patch.