From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AFF3A0350; Fri, 21 Jan 2022 20:28:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C235F42779; Fri, 21 Jan 2022 20:28:50 +0100 (CET) Received: from smtpout1.mo3004.mail-out.ovh.net (smtpout1.mo3004.mail-out.ovh.net [79.137.123.219]) by mails.dpdk.org (Postfix) with ESMTP id 54A9240040 for ; Fri, 21 Jan 2022 20:28:49 +0100 (CET) Received: from pro2.mail.ovh.net (unknown [10.109.143.244]) by mo3004.mail-out.ovh.net (Postfix) with ESMTPS id 34D6424344C; Fri, 21 Jan 2022 19:28:48 +0000 (UTC) Received: from localhost (5.253.206.158) by DAG2EX1.emp2.local (172.16.2.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 21 Jan 2022 20:28:48 +0100 Date: Fri, 21 Jan 2022 20:28:47 +0100 From: Tomasz Duszynski To: Weiguo Li CC: , Subject: Re: [PATCH] common/cnxk: fix incorrect error checking Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: X-Originating-IP: [5.253.206.158] X-ClientProxiedBy: DAG3EX1.emp2.local (172.16.2.21) To DAG2EX1.emp2.local (172.16.2.11) X-Ovh-Tracer-Id: 680325020513687411 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtgdduvdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpeffhffvuffkfhggtggujghisehttdortddttdejnecuhfhrohhmpefvohhmrghsiicuffhushiihihnshhkihcuoehtohhmrghsiidrughushiihihnshhkihesohgtthgrkhhonhdrtghomheqnecuggftrfgrthhtvghrnhepkeejgfevledtgfdtfeettdektedvieeiveduueetudekieetiedujedtleevleelnecukfhppedtrddtrddtrddtpdehrddvheefrddvtdeirdduheeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehprhhovddrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehtohhmrghsiidrughushiihihnshhkihesohgtthgrkhhonhdrtghomhdpnhgspghrtghpthhtohepuddprhgtphhtthhopehjvghrihhnjhesmhgrrhhvvghllhdrtghomh X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 21, 2021 at 04:02:20PM +0800, Weiguo Li wrote: > Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler") > > Signed-off-by: Weiguo Li > --- > drivers/common/cnxk/roc_bphy_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c > index f4e9b341af..5ba73c98dc 100644 > --- a/drivers/common/cnxk/roc_bphy_irq.c > +++ b/drivers/common/cnxk/roc_bphy_irq.c > @@ -261,9 +261,9 @@ roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num, > CPU_SET(curr_cpu, &intr_cpuset); > retval = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset), > &intr_cpuset); Use rc instead. This will generate less changes and will match local conventions. > - if (rc < 0) { > + if (retval < 0) { > plt_err("Failed to set affinity mask"); > - return rc; > + return retval; > } > > irq_usr.isr_base = (uint64_t)roc_bphy_intr_handler; > -- > 2.25.1 >