From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F2F9A0350; Fri, 4 Feb 2022 19:18:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A39C4013F; Fri, 4 Feb 2022 19:18:58 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 8D57940041 for ; Fri, 4 Feb 2022 19:18:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643998736; x=1675534736; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Xts8f/of6ensLm9DjjcphmAbY0nFkMnMWZblPxt1ie8=; b=d65CCuNZyR5/ikaI0K2QhWiARlSVK56dJL78agmVTZPOmMJ7jvDpsnEH kC4uIdwEob6a44W4nqEyoSZwdOdUPTvKLyFIhBNTBSGP8Y9kQ4mh+NiVn MFNCsI56lkj2aU+bTRxGIvR7iyplQReqjgKLDyNu+Hfjc6oqWICdY9ZdV +qvsR86hiJCalZ1+gzOgg75LD94kD7xS19qySolIg1HTHTxxNEtZ5dlVn OUpT7iTqO8YEr4w/y4oSjJAkhvRGNdjppw+Af0yh3P+ebzinsxmeQacyF HnAlH5rUogHffAqrZP472i4LzUxlbCz8sIs6BvKmZmdfA1GwwXNgxg48T Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10248"; a="235816852" X-IronPort-AV: E=Sophos;i="5.88,343,1635231600"; d="scan'208";a="235816852" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2022 10:18:55 -0800 X-IronPort-AV: E=Sophos;i="5.88,343,1635231600"; d="scan'208";a="539251259" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.8.163]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 04 Feb 2022 10:18:54 -0800 Date: Fri, 4 Feb 2022 18:18:50 +0000 From: Bruce Richardson To: dev@dpdk.org Cc: Maxime Coquelin , Chenbo Xia , Xiao Wang , Matan Azrad , Viacheslav Ovsiienko Subject: Re: [PATCH 6/7] vhost: remove non-C++ compatible includes Message-ID: References: <20220204174209.440207-1-bruce.richardson@intel.com> <20220204174209.440207-7-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220204174209.440207-7-bruce.richardson@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 04, 2022 at 05:42:08PM +0000, Bruce Richardson wrote: > Some of the linux header includes are explicitly noted as being > incompatible with C++. However, these headers can included by C files > directly, or by internal headers, to avoid polluting the public DPDK > headers with non-C++ safe includes. > > Signed-off-by: Bruce Richardson > --- CI is reporting build issues with this patch on examples, something I'm not surprised to see. I will wait for maintainer feedback on best approach before respinning patchset. /Bruce