From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 309C3A04A4; Mon, 7 Feb 2022 14:39:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF33E410F3; Mon, 7 Feb 2022 14:39:34 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id D6D03410EA for ; Mon, 7 Feb 2022 14:39:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644241173; x=1675777173; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gYdFJmmEeHXLBTh+Z58ZGnugTz1hZhM5yJkUuAxTFW4=; b=Zn9Qk9x92l+9UH9VrBqjhqPepUJAIEI8Cp3szrUeF7WJT/xXv4WFMeLi RzEOH1aDZgKjtfPsSVU1ZYvEZdy7KzJae1q+R6HSXulIkxuHzeHC9LrUK fmumQbiszXZUc8KnZKNcmPiwrvVnBs/GZHnFdlzV1Sc1eOGhHL4htgOt9 hfMOSRgX8oB3REKFRXGY1amqlLGBh7M1rwNENUhauuBZBk6HQAI8KZ0rs azlVFs5kk/+DYiCSVPex3MQinaSQ2f3hXqBuUydtO0fCppihC27/ZJTLA 7ITTGiopatL2/y5+QMsETV7xLXcmKJSp1VUDqhw+TipmH2WJpN7FXMr2Y A==; X-IronPort-AV: E=McAfee;i="6200,9189,10250"; a="232279704" X-IronPort-AV: E=Sophos;i="5.88,349,1635231600"; d="scan'208";a="232279704" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 05:39:32 -0800 X-IronPort-AV: E=Sophos;i="5.88,349,1635231600"; d="scan'208";a="540101452" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.10.89]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Feb 2022 05:39:31 -0800 Date: Mon, 7 Feb 2022 13:39:27 +0000 From: Bruce Richardson To: Weiguo Li Cc: dev@dpdk.org Subject: Re: [PATCH 0/6] fix the curly braces mismatch problem Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 07, 2022 at 07:44:29PM +0800, Weiguo Li wrote: > On Mon, 7 Feb 2022 09:29:58 +0000, Bruce Richardson wrote: > > Any headers that have filenames not starting with "rte_" are internal > > headers, and so should have the guards removed. Therefore, I think that > > most patches in this set should just be removing guards. From my tests with > > building our public headers in C++ files, resulting in series[1], I only > > found one public header with an incorrect guard. > > > > /Bruce > > > > [1]http://patches.dpdk.org/project/dpdk/list/?series=21466 > > > > Hi Bruce, > > Thanks for your tip! > > BTW it's strange that some file include these headers by angle-brackets. > > I'll update this patch set later. > Thanks. BTW: if you do find any headers that are being exposed as public headers, but don't have "rte_" in the filename, please flag them as needing fixing too. There shouldn't be any, but just in case....