From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E99BA04AE; Tue, 8 Feb 2022 11:48:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2BB2410FD; Tue, 8 Feb 2022 11:48:28 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 8B535410FC for ; Tue, 8 Feb 2022 11:48:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644317307; x=1675853307; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=otEmFmhOs8nIUhOMgtpvt143t1NGEuG4a6NAxJ4eins=; b=BxtAc+H0VpL6MdasaWD11ZjjEw8iSq9ewn3OA7St95oT+BmzaplQ6UI6 bl2kHwii/YQZkM66gcSTtlQYX07fjQLtrpeoQ4jLepucryVBi0IZ/m6/r u1GLarIHyjrjztUYnzjU7+YEiRcvKxKvxz1LOVAm3jLeDkpMyklgzyRR0 bkGAEN9qw/rSSQyj6PWpaTK1ITqBugb272x2gKhyCVOgvEwd+jfElz7B+ Gb7zqv1hbJwiMpRpxerqmWaTxbWfO5dJVYKe6Ji1wL/krerpTDxZ3cjDz FnrlOZ7R5fgrZWS+sWPRjTx3vjabe4MUh8oFdJQ6Kzcys7rWW9E7liTJg w==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="236329222" X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="236329222" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 02:48:18 -0800 X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="484771722" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.9.238]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 08 Feb 2022 02:48:17 -0800 Date: Tue, 8 Feb 2022 10:48:13 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Subject: Re: [PATCH v2 0/2] eal: support configuring runtime directory Message-ID: References: <20220203060025.881552-1-stephen@networkplumber.org> <20220205171101.7673-1-stephen@networkplumber.org> <20220207204348.05c6ba16@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207204348.05c6ba16@hermes.local> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 07, 2022 at 08:43:48PM -0800, Stephen Hemminger wrote: > On Sat, 5 Feb 2022 09:10:59 -0800 > Stephen Hemminger wrote: > > > Found this while exploring running a DPDK service with systemd > > container environment. It helps if the place DPDK puts its runtime > > directory is configurable. > > > > v2 - fix dpdk_telemetry.py to use append dpdk > > > > Stephen Hemminger (2): > > eal: remove size for eal_set_runtime_dir > > eal: support systemd service convention for runtime directory > > > > lib/eal/common/eal_common_config.c | 7 ++----- > > lib/eal/common/eal_private.h | 4 +--- > > lib/eal/freebsd/eal.c | 2 +- > > lib/eal/linux/eal.c | 25 ++++++++++++++----------- > > usertools/dpdk-telemetry.py | 10 +++++++--- > > 5 files changed, 25 insertions(+), 23 deletions(-) > > > > Bruce is it worth moving this (and the sysfs logic) from > Linux only into unix/ directory and have common code with FreeBSD? > The "create_runtime_dir()" function is indeed a copy-paste between the two OS's so looks like it should be moved into a common unix implementation.