From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5279A04A6; Wed, 9 Feb 2022 10:21:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EE5D41101; Wed, 9 Feb 2022 10:21:34 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5001F410FD for ; Wed, 9 Feb 2022 10:21:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644398492; x=1675934492; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=K3wOeLC5Bv7sOOGEfteLD7qorFI/3xFyjIpJNOa/f14=; b=QnbVSwGI12scfRgLyUEDXIX6Fku31OzYxWqJH/M3PvccnO8cvZl9G+3z 2g4/5WhW5dLVwFk/+9vXqNRryFogDc19FC4VmaxglLeJcxYZhBwqCGIoU Dfo8ikBj98QkvNX74nqmixO4ldGp+vu5yTFE0oO6pvl0mh6fwkW/+kA8x HAMYiI9xTXCNR1xdsBb4cbqXY60odznAF7f8oSro+WMBcZcYvtrn+yJPe vIkccKDO0E1M33HgkGsFR/hBIHvCYqfsWqjKaC5b8v86esuUxD4TcfWsE vtcB8CGrZXdddT0tAollf48QyxG5VOQmM0V7sd9IbrkjEo1yGlShv9/EL w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="248924026" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="248924026" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 01:21:31 -0800 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="622217170" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.97]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Feb 2022 01:21:29 -0800 Date: Wed, 9 Feb 2022 09:21:26 +0000 From: Bruce Richardson To: "Wang, Xiao W" Cc: "dev@dpdk.org" , Maxime Coquelin , "Xia, Chenbo" , Matan Azrad , Viacheslav Ovsiienko Subject: Re: [PATCH 6/7] vhost: remove non-C++ compatible includes Message-ID: References: <20220204174209.440207-1-bruce.richardson@intel.com> <20220204174209.440207-7-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 09, 2022 at 09:10:36AM +0000, Wang, Xiao W wrote: > Hi Bruce, > > > -----Original Message----- From: Richardson, Bruce > > Sent: Saturday, February 5, 2022 2:19 AM > > To: dev@dpdk.org Cc: Maxime Coquelin ; Xia, > > Chenbo ; Wang, Xiao W ; > > Matan Azrad ; Viacheslav Ovsiienko > > Subject: Re: [PATCH 6/7] vhost: remove non-C++ > > compatible includes > > > > On Fri, Feb 04, 2022 at 05:42:08PM +0000, Bruce Richardson wrote: > > > Some of the linux header includes are explicitly noted as being > > > incompatible with C++. However, these headers can included by C files > > > directly, or by internal headers, to avoid polluting the public DPDK > > > headers with non-C++ safe includes. > > > > > > Signed-off-by: Bruce Richardson --- > > > > CI is reporting build issues with this patch on examples, something I'm > > not surprised to see. I will wait for maintainer feedback on best > > approach before respinning patchset. > > > > /Bruce > > Could we move these c++ incompatible linux headers into #ifndef > __cplusplus ... #endif. Then we just need to change rte_vhost.h file, > and don't break build for the drivers and samples. > I was thinking that something similar would work, but it's not the most elegant, and strikes me as a bit of a hack. If it's generally acceptable, though, I'm happy enough to respin the patch with that fix. /Bruce