From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0AE7A04A6; Wed, 9 Feb 2022 10:25:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96F7241101; Wed, 9 Feb 2022 10:25:15 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 1AA1F410FD for ; Wed, 9 Feb 2022 10:25:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644398714; x=1675934714; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+6cs6GtKugtfUMmonygJ+s0Eyccmw2H3skbryMllOcA=; b=P8NU2kWc+vRAUDxpGyaKtAC59sL5Xjx/OaACa18eSIRhUj/fmHVkGCE9 w9ZsfR38DoJE8VxXIdbqPVRYQLD+yR2sWoH5c/5i1MUm3ClK91kZjyOWg zZIRr8PVybqHV4qooOHwPcHIuIgDPpaDyeuroh1K6xJl0XGvk+IxPxooB awkDNgh+dnwqZMqinH/LZYOhQmWmzInpa55PMIv8gQg73xcypgtVG/DQb 18J4+Cd9TsJoMvrsDD7itcxwV3GvcKF7ivtVAQeF7TTfHumgd37+kUHqd 75FN6xvLrtc38X1hrCgXv0NoRaaOz2qmsd+cPj0yGMWLdJ4HTmQ8hV8es g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="309909608" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="309909608" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 01:25:13 -0800 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="622218277" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.97]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Feb 2022 01:25:12 -0800 Date: Wed, 9 Feb 2022 09:25:08 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: Weiguo Li , dev@dpdk.org Subject: Re: [PATCH v2 06/16] net/netvsc: add define guards to avoid multi-inclusion Message-ID: References: <20220208222801.2b0ba9e5@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220208222801.2b0ba9e5@hermes.local> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 08, 2022 at 10:28:01PM -0800, Stephen Hemminger wrote: > On Wed, 9 Feb 2022 11:02:14 +0800 > Weiguo Li wrote: > > > Supplement define guards to prevent multiple inclusion. > > > > Signed-off-by: Weiguo Li > > Why bother these are just driver specific includes, not a public API On the other hand, if this can be cleaned up globally in DPDK, why not also fix the internal headers?