From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org, ocardona@microsoft.com, roretzla@microsoft.com,
david.marchand@redhat.com, ferruh.yigit@intel.com
Subject: Re: out of tree driver builds broken with C++
Date: Mon, 14 Feb 2022 10:45:52 +0000 [thread overview]
Message-ID: <Ygoy4Fy4X84N1Iqs@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <3450334.eFTFzoEnKi@thomas>
On Mon, Feb 14, 2022 at 10:22:08AM +0100, Thomas Monjalon wrote:
> 14/02/2022 10:13, Tyler Retzlaff:
> > while the driver api is "internal" we agreed some time ago that drivers
> > could be built external to the dpdk tree. by enabling the meson setup
> > option -Denable_driver_sdk=true.
> >
> > it was agreed that the driver api was internal and would attract no
> > binary compatibility support which was fine. this change has now
> > imposed a further restriction that out of tree drivers have to be
> > authored in C only as non-C++ compatible code will invariably leak into
> > the internal structures.
> >
> > you won't allow us to build C++ drivers in the dpdk tree and it seems
> > now you are preventing building of C++ drivers outside of the tree too.
>
> That's the problem of non-written assumptions, they are unknown or forgotten.
> Did we agree to support out-of-tree drivers in C++?
>
> We really need to make things clear and written in documentation.
>
> > could we please re-evaluate this.
>
> Yes we can re-evaluate.
> What is the list of impacted files?
>
Hacking meson files a bit, the list of SDK header files is reported as below.
/Bruce
Message: SDK headers:
Message: ethdev_driver.h
Message: ethdev_pci.h
Message: ethdev_vdev.h
Message: cryptodev_pmd.h
Message: eventdev_pmd.h
Message: eventdev_pmd_pci.h
Message: eventdev_pmd_vdev.h
Message: eventdev_trace.h
Message: event_timer_adapter_pmd.h
Message: rte_dmadev_pmd.h
Message: vdpa_driver.h
next prev parent reply other threads:[~2022-02-14 10:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 9:13 Tyler Retzlaff
2022-02-14 9:22 ` Thomas Monjalon
2022-02-14 10:45 ` Bruce Richardson [this message]
2022-02-14 11:19 ` Thomas Monjalon
2022-02-14 11:43 ` Bruce Richardson
2022-02-14 15:03 ` Bruce Richardson
2022-02-14 17:24 ` Stephen Hemminger
2022-02-14 17:49 ` Thomas Monjalon
2022-02-14 18:21 ` Stephen Hemminger
2022-02-14 18:32 ` Tyler Retzlaff
2022-02-14 18:40 ` Tyler Retzlaff
2022-02-14 18:03 ` Bruce Richardson
2022-02-15 6:10 ` Tyler Retzlaff
2022-02-15 8:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygoy4Fy4X84N1Iqs@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ocardona@microsoft.com \
--cc=roretzla@linux.microsoft.com \
--cc=roretzla@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).