From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4D59BA00C5;
	Mon, 14 Feb 2022 14:48:30 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2230240DDA;
	Mon, 14 Feb 2022 14:48:30 +0100 (CET)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by mails.dpdk.org (Postfix) with ESMTP id 6D4694067E
 for <dev@dpdk.org>; Mon, 14 Feb 2022 14:48:28 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1644846508; x=1676382508;
 h=date:from:to:cc:subject:message-id:references:
 mime-version:in-reply-to;
 bh=YXWV7z1hWF02CxBv8gzqP9Hb/JFzum15Zl8Urwjq7m0=;
 b=GV0UIAUHTQrCP6eESzZleV+YWigX1RNetaSWt+WP/uvRBkixKAsq5Dh0
 LUCyhp3NGtVECYuFqtDcjLrvNMeAS+bGJQe96qbEpPmGw9FkT0+/aBXYd
 5JxDwNDnARWhuyFPkbBKw19yA339GeVIcoHvF577VD6agCCwyM7Z3e81Q
 Rt6CzLT1qeLtaYuut0JPH3TeF7LfpBCmzVOpoUZbUBsPaivkN3j1RI4sU
 xt7Xyri+RE76Y4fIarM6gfOXwRD5rbPeI7fErnXGB3EEsS9oa91pvvanz
 s2DIzEcBN+yHw5IVLH9TQtMDmn0wr5H85z8oYBO54I22U8sIbe+jTxPb8 w==;
X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="249839039"
X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="249839039"
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 14 Feb 2022 05:48:27 -0800
X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="528181486"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.13.94])
 by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 14 Feb 2022 05:48:26 -0800
Date: Mon, 14 Feb 2022 13:48:23 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Karl Bonde Torp <karlowich@gmail.com>
Cc: dev@dpdk.org, Karl Bonde Torp <k.torp@samsung.com>
Subject: Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1
Message-ID: <Ygpdp2rgIsoOyCyN@bricha3-MOBL.ger.corp.intel.com>
References: <20220214114313.21258-1-k.torp@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220214114313.21258-1-k.torp@samsung.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Feb 14, 2022 at 12:43:13PM +0100, Karl Bonde Torp wrote:
> When building with Meson 0.61.1 on FreeBSD some archives become
> corrupted. This can be avoided by using 'llvm-ar' instead of 'ar'.
> 
> Signed-off-by: Karl Bonde Torp <k.torp@samsung.com>
> ---

Hi,

thanks for the patch. Can you perhaps provide some instructions or more
details as to how/when you see this issue? A clean build of mine on FreeBSD
with meson 0.61.1 didn't seem to flag up any problems and I'd like to
reproduce the issue to verify the fix.

/Bruce

>  buildtools/meson.build | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/buildtools/meson.build b/buildtools/meson.build
> index 400b88f251..e1c600e40f 100644
> --- a/buildtools/meson.build
> +++ b/buildtools/meson.build
> @@ -31,6 +31,9 @@ if host_machine.system() == 'windows'
>          pmdinfo += 'llvm-ar'
>      endif
>      pmdinfogen += 'coff'
> +elif host_machine.system() == 'freebsd'
> +    pmdinfo += 'llvm-ar'
> +    pmdinfogen += 'elf'
>  else
>      pmdinfo += 'ar'
>      pmdinfogen += 'elf'
> -- 
> 2.35.1
>