From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45148A0350; Mon, 28 Feb 2022 10:42:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BED7C41157; Mon, 28 Feb 2022 10:42:54 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id E7ECA4068C for ; Mon, 28 Feb 2022 10:42:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646041373; x=1677577373; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jFlptAcQSlLx+aGudIkZJ/CRbp4ZM7N/Fdr1AvYTQN0=; b=lb+WgOljJuQoAcCdPganG9piUsPPWk5i7vWrqRGJxwruSZjLq4dRBWvT N8Dt253n8JKITbzXAKxSbpVgam6mrYV1JFk13FwLAtWUJYYkVTeHof4c0 Iq/n+fP3pcc/tCdVHvfX961RgltQfCUpRFl70ZBwGXhcFHozY/5BZpiG0 foiu8deeORwfW91ym3AJJ98ZySHZaVFOkrahdcp3bODaEkEc6gTN17vR2 XVrzV4EwvsVMHA4YySbdcJ6OEfP12ssX/1aOZeddx2AjV74AKSPUQ/NwH Lp9sWgA8/7U/fXcshB8wuUmZxRaOGLacRztLy7L/vJWH6gLKuGzv3Cy96 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10271"; a="250428605" X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="250428605" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 01:42:51 -0800 X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="550170279" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.27.47]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 Feb 2022 01:42:50 -0800 Date: Mon, 28 Feb 2022 09:42:47 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: Stephen Hemminger , dev@dpdk.org Subject: Re: [PATCH v3 4/8] lib: document existing free functions Message-ID: References: <20220219234322.61309-1-stephen@networkplumber.org> <20220220182147.9750-1-stephen@networkplumber.org> <20220220182147.9750-5-stephen@networkplumber.org> <3949827.atdPhlSkOF@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3949827.atdPhlSkOF@thomas> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Feb 27, 2022 at 09:48:57PM +0100, Thomas Monjalon wrote: > 20/02/2022 19:21, Stephen Hemminger: > > + * If NULL then, the function does nothing. > > I'm not English native, but I thought it should be one of these 2 forms: > - If NULL, the function does nothing. > - If NULL then the function does nothing. > I would agree, and also would tend toward the first version. /Bruce