From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 530FAA0350;
Mon, 28 Feb 2022 11:19:28 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 38BB14068C;
Mon, 28 Feb 2022 11:19:28 +0100 (CET)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by mails.dpdk.org (Postfix) with ESMTP id 2520A40140
for <dev@dpdk.org>; Mon, 28 Feb 2022 11:19:25 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1646043566; x=1677579566;
h=date:from:to:cc:subject:message-id:references:
mime-version:in-reply-to;
bh=HXb6TZ4VGB4XxjhQkl22GsNzpG4XqWU4zDJmefETFe0=;
b=Bg93wYkNvk7MLFUKp+csuLGKO0yzsMhmBqlIoFYTB3SAqHDNRmM2+hSr
O3oPGFIukYe86ZuV9UTPlFA4FMUFj7Cnm0+p0mWyNN95/uauNBJlC/SLp
YU65yEJe5XhEBXiulcxxyaVUjg9hMMf9moS0ogSCD5irLkfO9I1difpfj
lNla1jqm03OHmOosfRzSiHiYjkbjadK0MxI6cc2hGTXSP3N1EaEYyyAD4
v2yCjO02fAY7aYVjE9+msz69A9qhS5HbiA/3qkMsi+DLy1oYXHZFJZZ0k
ER8jLwuU4a+6uwdZkullnziXVIhOIjVWALLfoE8vQnK3fBMFt/J2o88Yb A==;
X-IronPort-AV: E=McAfee;i="6200,9189,10271"; a="240262274"
X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="240262274"
Received: from orsmga006.jf.intel.com ([10.7.209.51])
by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
28 Feb 2022 02:19:25 -0800
X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="510037951"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.27.47])
by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
28 Feb 2022 02:19:23 -0800
Date: Mon, 28 Feb 2022 10:19:20 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH] ci: remove redundant drivers enabling
Message-ID: <YhyhqCSnaYVwqsdj@bricha3-MOBL.ger.corp.intel.com>
References: <20220226183651.2165304-1-thomas@monjalon.net>
<YhyZ8SLvTWWm7fiD@bricha3-MOBL.ger.corp.intel.com>
<CAJFAV8yijPf5aVBsrkoRwZXyFuf4vpZ8eUo=AGv3cwA4XD+9Zw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8yijPf5aVBsrkoRwZXyFuf4vpZ8eUo=AGv3cwA4XD+9Zw@mail.gmail.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Mon, Feb 28, 2022 at 11:17:07AM +0100, David Marchand wrote:
> On Mon, Feb 28, 2022 at 10:46 AM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote:
> > > No need to explicitly enable drivers bus/vdev and mempool/ring.
> > >
> > > bus/vdev is always enabled since
> > > commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
> > >
> > > mempool/ring is always enabled since
> > > commit 81c2337e044d ("build: make ring mempool driver mandatory")
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > One comment inline below.
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > .ci/linux-build.sh | 2 +-
> > > devtools/test-meson-builds.sh | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> > > index 67d68535e0..77c0d1976b 100755
> > > --- a/.ci/linux-build.sh
> > > +++ b/.ci/linux-build.sh
> > > @@ -89,7 +89,7 @@ OPTS="$OPTS --default-library=$DEF_LIB"
> > > OPTS="$OPTS --buildtype=debugoptimized"
> > > OPTS="$OPTS -Dcheck_includes=true"
> > > if [ "$MINI" = "true" ]; then
> > > - OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null"
> > > + OPTS="$OPTS -Denable_drivers=net/null"
> > > OPTS="$OPTS -Ddisable_libs=*"
> > > fi
> > > meson build --werror $OPTS
> > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> > > index c07fd16fdc..a653b253cb 100755
> > > --- a/devtools/test-meson-builds.sh
> > > +++ b/devtools/test-meson-builds.sh
> > > @@ -221,7 +221,7 @@ for c in gcc clang ; do
> > > done
> > >
> > > build build-mini cc skipABI $use_shared -Ddisable_libs=* \
> > > - -Denable_drivers=bus/vdev,mempool/ring,net/null
> > > + -Denable_drivers=net/null
> >
> > Do we even need this enabled for a mini-build. Would disable_drivers=*/*
> > not work better to truly have a minimal build?
>
> In GHA, for native builds, test-null.sh is called, and it uses net/null ports.
> https://git.dpdk.org/dpdk/tree/.ci/linux-build.sh#n101
>
Ok, thanks for clarifying, all good so.
/Bruce