From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4EAE2A0093;
	Tue,  8 Mar 2022 22:28:13 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C3DE240395;
	Tue,  8 Mar 2022 22:28:12 +0100 (CET)
Received: from sender11-of-o51.zoho.eu (sender11-of-o51.zoho.eu
 [185.20.211.237])
 by mails.dpdk.org (Postfix) with ESMTP id CABCD40141
 for <dev@dpdk.org>; Tue,  8 Mar 2022 22:28:10 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; t=1646774883; cv=none; d=zohomail.eu; s=zohoarc; 
 b=DTcDVw9lw2YGUS2BmNZgqWVu+DKoFCNh/irafkn7HKI5IoN3Jxp+8Z0L+0URS3ik1h1teKKqF/3VuuV27beGJxqsFu1pwbIdxYIMqwzdssJoPTBIC7JLG+Lgd1UGvsyhP4BofQjVlBZeifeVnPoxHlQsOzQdOpc5Z2zYyg0vako=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu;
 s=zohoarc; t=1646774883;
 h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To;
 bh=uh8bZTq/R6kJraDkz4d8eqFHL7wk9Jen6GBjxy0Hfuo=; 
 b=XTMTcY434Q7fFSlguDaq8b9TpHc3bvzO/mdCRJo8IRb/ATGLMXjVOk62vj4hEKMH1ro0CcUOA7QEotAHyxbKMKqcnGOfYweF2Zg8SkxcR1x8eDH6L7MOBFNy5qp2wWJVxIVHmaAEMsm6ZU+UL4nfNZTIlLNAVKKucNM681B1AFI=
ARC-Authentication-Results: i=1; mx.zohomail.eu;
 spf=pass  smtp.mailfrom=liangma@liangbit.com;
 dmarc=pass header.from=<liangma@liangbit.com>
Received: from C02GF04TMD6V
 (ec2-35-176-106-177.eu-west-2.compute.amazonaws.com [35.176.106.177]) by
 mx.zoho.eu with SMTPS id 1646774880611721.0027895330305;
 Tue, 8 Mar 2022 22:28:00 +0100 (CET)
Date: Tue, 8 Mar 2022 21:27:58 +0000
From: Liang Ma <liangma@liangbit.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Usama Arif <usama.arif@bytedance.com>
Subject: Re: [PATCH] devtools: fix symbols check
Message-ID: <YifKXgTiaR11M5r5@C02GF04TMD6V>
References: <20220308211859.3677476-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220308211859.3677476-1-thomas@monjalon.net>
X-ZohoMailClient: External
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Mar 08, 2022 at 10:18:59PM +0100, Thomas Monjalon wrote:
> In some environments, the check of local symbols catch-all
> was failing. Note: this script is called during the build.
> 
> The reason is that grep returns an error if nothing is found.
> The option -e of the shell script makes this error fatal.
> It is not always fatal because the grep is in a command substitution.
> 
> Fixes: b403498e1422 ("build: hide local symbols in shared libraries")
> 
> Reported-by: Usama Arif <usama.arif@bytedance.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/check-symbol-maps.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh
> index 8266fdf9ea..32e1fa5c8f 100755
> --- a/devtools/check-symbol-maps.sh
> +++ b/devtools/check-symbol-maps.sh
> @@ -53,7 +53,7 @@ if [ -n "$duplicate_symbols" ] ; then
>      ret=1
>  fi
>  
> -local_miss_maps=$(grep -L 'local: \*;' $@)
> +local_miss_maps=$(grep -L 'local: \*;' $@ || true)
reviewed-by Liang Ma <liangma@liangbit.com> 

I'm curious to know how can the CI passed with original patch..... 

>  if [ -n "$local_miss_maps" ] ; then
>      echo "Found maps without local catch-all:"
>      echo "$local_miss_maps"
> -- 
> 2.34.1
>