From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FAC8A0509; Tue, 29 Mar 2022 12:28:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45A8741151; Tue, 29 Mar 2022 12:28:51 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A11BB40691 for ; Tue, 29 Mar 2022 12:28:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648549729; x=1680085729; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=N49YDP6XUC44dqpkE+LFgkCmr/lpbC4w/s/A4h5xvxk=; b=GKhmHtRbOgwP+JTko8S13iNJ+P+Nlu2ngyGYnheQ2Qx9Y4A2fS3qmct+ CBS2qOIl+YWrzI1US018GCNQrhvk4+/EvJs13CNnHjWJBf6hm00jd6uCF G8WouFE9P7oL83akmw1p779GMCl6UENaJMKIhk1PCvjcXDCmToLL3cLjb MfhomxL45FD/G1Dard0vKFf6Dep9h934qe13JfBcYX6De7YJe2WrEYggN n/Baze20v4G5cbDEZfsOvKxJnYC9DQua0XYv1qzDQxAjBy/BPdjge7im2 WT+9yhmktW0uUQM92/EOZy4oCm9kOYIwza5DeOFIFyRhbdssGZwqTuzJO g==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="259186874" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="259186874" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 03:28:48 -0700 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="521384644" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.12.222]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 29 Mar 2022 03:28:46 -0700 Date: Tue, 29 Mar 2022 11:28:43 +0100 From: Bruce Richardson To: Sean Morrissey Cc: Konstantin Ananyev , dev@dpdk.org Subject: Re: [PATCH v1] examples/l3fwd: merge l3fwd-acl into l3fwd Message-ID: References: <20220325151428.1037085-1-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220325151428.1037085-1-sean.morrissey@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 25, 2022 at 03:14:28PM +0000, Sean Morrissey wrote: > l3fwd-acl contains duplicate functions to l3fwd. > For this reason we merge l3fwd-acl code into l3fwd > with '--lookup acl' cmdline option to run ACL. > > Signed-off-by: Sean Morrissey > --- > examples/l3fwd-acl/Makefile | 51 - > examples/l3fwd-acl/main.c | 2272 ----------------------------- > examples/l3fwd-acl/meson.build | 13 - > examples/l3fwd/Makefile | 2 +- > examples/l3fwd/l3fwd.h | 39 +- > examples/l3fwd/l3fwd_acl.c | 1123 ++++++++++++++ > examples/l3fwd/l3fwd_acl.h | 120 ++ > examples/l3fwd/l3fwd_acl_scalar.h | 160 ++ > examples/l3fwd/l3fwd_route.h | 16 + > examples/l3fwd/main.c | 97 +- > examples/l3fwd/meson.build | 3 +- > examples/meson.build | 1 - > 12 files changed, 1545 insertions(+), 2352 deletions(-) > delete mode 100644 examples/l3fwd-acl/Makefile > delete mode 100644 examples/l3fwd-acl/main.c > delete mode 100644 examples/l3fwd-acl/meson.build > create mode 100644 examples/l3fwd/l3fwd_acl.c > create mode 100644 examples/l3fwd/l3fwd_acl.h > create mode 100644 examples/l3fwd/l3fwd_acl_scalar.h > Patch also needs to remove/update the docs for: https://doc.dpdk.org/guides-21.11/sample_app_ug/l3_forward_access_ctrl.html https://doc.dpdk.org/guides-21.11/sample_app_ug/l3_forward.html /Bruce