From: Bruce Richardson <bruce.richardson@intel.com>
To: zhichaox.zeng@intel.com
Cc: haiyue.wang@intel.com, dev@dpdk.org
Subject: Re: [DPDK] drivers/net/ixgbe: remove expired symbols
Date: Tue, 12 Apr 2022 09:38:58 +0100 [thread overview]
Message-ID: <YlU6ou72HzQuQNa7@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20220412142706.831243-1-zhichaox.zeng@intel.com>
On Tue, Apr 12, 2022 at 02:27:06PM +0000, zhichaox.zeng@intel.com wrote:
> From: zhichao zeng <zhichaox.zeng@intel.com>
>
> Remove expired experimental symbols.
>
> Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> ---
> drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
> drivers/net/ixgbe/version.map | 10 +++++-----
> 2 files changed, 10 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> index eef6f6661c..4f1fe6029d 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> @@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
> * - (-ENODEV) if *port* invalid.
> * - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
> */
> -__rte_experimental
> -int
> -rte_pmd_ixgbe_mdio_lock(uint16_t port);
> +int rte_pmd_ixgbe_mdio_lock(uint16_t port);
>
I don't see the value in rewriting the prototypes to be all on one line as
part of this change. Just remove the experimental tag line in this patch,
to keep the diff as small as possible.
/Bruce
next prev parent reply other threads:[~2022-04-12 8:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 14:27 zhichaox.zeng
2022-04-12 7:23 ` Wang, Haiyue
2022-04-12 8:47 ` David Marchand
2022-04-12 8:38 ` Bruce Richardson [this message]
2022-04-12 8:52 ` Wang, Haiyue
2022-04-12 16:16 ` [DPDK v2] net/ixgbe: promote MDIO API zhichaox.zeng
2022-04-12 17:56 ` [DPDK v3] " zhichaox.zeng
2022-04-14 2:52 ` Wang, Haiyue
2022-04-15 14:36 ` Ray Kinsella
2022-04-18 6:41 ` Yang, Qiming
2022-04-19 11:06 ` [DPDK v4] " zhichaox.zeng
2022-04-24 8:33 ` Zeng, ZhichaoX
2022-04-26 10:11 ` Ray Kinsella
2022-04-27 1:07 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlU6ou72HzQuQNa7@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=zhichaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).