DPDK patches and discussions
 help / color / mirror / Atom feed
From: Niklas Soderlund <niklas.soderlund@corigine.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/nfp: remove unneeded header inclusion
Date: Thu, 21 Apr 2022 13:14:16 +0200	[thread overview]
Message-ID: <YmE8iEdes7RSHXz0@oden.dyn.berto.se> (raw)
In-Reply-To: <20220408094116.6542-1-david.marchand@redhat.com>

Hi David,

Thanks for your work.

On 2022-04-08 11:41:16 +0200, David Marchand wrote:
> Looking at this driver history, there was never a need for including
> execinfo.h.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

> ---
>  drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index bad80a5a1c..08bc4e8ef2 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -16,9 +16,6 @@
>  
>  #include <assert.h>
>  #include <stdio.h>
> -#if defined(RTE_BACKTRACE)
> -#include <execinfo.h>
> -#endif
>  #include <stdlib.h>
>  #include <unistd.h>
>  #include <stdint.h>
> -- 
> 2.23.0
> 

-- 
Kind Regards,
Niklas Söderlund

  reply	other threads:[~2022-04-26  8:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  9:41 David Marchand
2022-04-21 11:14 ` Niklas Soderlund [this message]
2022-05-04 12:31   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmE8iEdes7RSHXz0@oden.dyn.berto.se \
    --to=niklas.soderlund@corigine.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).