From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] build: add definitions for use as meson subproject
Date: Fri, 6 May 2022 15:06:07 +0100 [thread overview]
Message-ID: <YnUrT1ZvpX/X1xXH@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20211105172213.103988-1-stephen@networkplumber.org>
On Fri, Nov 05, 2021 at 10:22:13AM -0700, Stephen Hemminger wrote:
> Some other projects using meson may not be able to use DPDK
> using the standard distribution pkg-config mechanism.
> Meson supports a way to handle this via the subproject
> https://mesonbuild.com/Subprojects.html
>
> This patch adds the necessary dependency to follow the
> "Naming convention for dependency variables" from the documentation.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>
> v2 - add link libraries
>
Playing around with DPDK as a meson subproject myself, I have some
additional thoughts on how to put this in DPDK and some further comments on
this patch. For example:
* For static builds we need to "link_whole" the drivers, as well as doing a
"link_with" on the libraries
* for shared builds - which will need to be done explicitly by passing the
subproject the default_library type parameter we actually don't need to
include the "link_with" line since the libs are already included in the
shared deps. [I think they should be added to the static deps too, if
that doesn't cause any problems]
* we therefore likely need slightly different subproject definitions for
shared vs static, and I'd suggest moving that to a new file e.g. in
"buildtools/subproject" - to avoid cluttering the main file too much.
If you don't mind, I'll do a re-spin of this functionality in a
V3 patch, based on above ideas, and we can see where we go there.
/Bruce
next prev parent reply other threads:[~2022-05-06 14:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 22:12 [dpdk-dev] [RFC] build: allow build DPDK as a meson submodule Stephen Hemminger
2021-11-04 8:59 ` Bruce Richardson
2021-11-05 0:01 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2021-11-05 14:58 ` Bruce Richardson
2021-11-05 16:17 ` Stephen Hemminger
2021-11-05 17:22 ` [dpdk-dev] [PATCH v2] build: add definitions for use as meson subproject Stephen Hemminger
2021-11-05 18:11 ` Bruce Richardson
2022-02-02 20:59 ` Thomas Monjalon
2022-05-06 14:06 ` Bruce Richardson [this message]
2022-05-06 14:43 ` [PATCH v3] " Bruce Richardson
2022-05-21 0:54 ` Ben Magistro
2022-06-07 16:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnUrT1ZvpX/X1xXH@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).