From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74BDFA00C2; Mon, 30 May 2022 10:09:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1572F42B75; Mon, 30 May 2022 10:09:53 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9F59640A8A for ; Mon, 30 May 2022 10:09:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653898191; x=1685434191; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Z2cnwO/no2/FKnmdPcN5UaOr0Rxf5Q7mxXNdAOw6mfs=; b=fnMTM+IA3Lj5xo0XrZ4EByx0l/mSPI2sSq2FxNxRbrsEqKM4MLTm5YMk P4EIJI/3XeUyzep3Kkh9rbniDmGWeAA/FORjiR00A5cOTvtwNQZCi9+20 B1Gs86n2hiZBjsHMZBc3rNysvM5/5fkAdgpvNpvBKlfpd9LxUzYeng3zZ td9LQYQN3TX4+SiAyqvSKj8j7dVlgqAA9kTL9tYMUtPiE4EX5Z0cyjByT 1qNTCiHK5vz93nGQBv4rfD9cscDQCFpY5x9jlpmZ1Rgtgc5wNdyNZQv8N 5suAPWmbr39NqSIMN5ugkkU9Mq9gf93OPcs4P30owwbWKBT1P39TINBes Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="337969760" X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="337969760" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 01:09:50 -0700 X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="551242876" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.6.54]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 30 May 2022 01:09:49 -0700 Date: Mon, 30 May 2022 09:09:46 +0100 From: Bruce Richardson To: Lewis Donzis Cc: dev Subject: Re: FreeBSD 13.1 changes Message-ID: References: <1154975224.4469878.1653824181427.JavaMail.zimbra@donzis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1154975224.4469878.1653824181427.JavaMail.zimbra@donzis.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, May 29, 2022 at 06:36:21AM -0500, Lewis Donzis wrote: > Apparently FreeBSD 13.1 changed the syntax of the CPUSET macros, so DPDK no longer compiles. > > For example, here's one definition on FreeBSD 13.0 and prior: > > CPU_OR(cpuset_t *dst, cpuset_t *src); > > and here it is in FreeBSD 13.1: > > CPU_OR(cpuset_t *dst, cpuset_t *src1, cpuset_t *src2); > > I've modified lib/eal/freebsd/include/rte_os.h to handle both old and new versions of FreeBSD. > > I'd like to provide the updated file, if someone would be willing to review and commit, please? > Can you please retest with the latest DPDK code in git. This should be fixed there now. See patch [1]. The fix should make its way into the LTS backports over time too. /Bruce [1] http://patches.dpdk.org/project/dpdk/patch/20220520181050.55654-1-bruce.richardson@intel.com/