From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0581DA0543; Mon, 30 May 2022 15:15:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAD1640694; Mon, 30 May 2022 15:15:53 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 56F7D400D6 for ; Mon, 30 May 2022 15:15:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653916552; x=1685452552; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fmvgvgfdWKJCtDjf4PSBlworPbM1hgqKhqJCKvP3TVM=; b=JfdjE63VKxbp02oupS2mDJ4Sdsxv31xnhM/cgEOeECFcSLZCAjdc0Nxk nawzmOKbyWEaKXVdvePrgzgFitOqcsqlf9g+8toJ8Ymq1IgQgrrwEka58 6yXki4Rpzg6msPBFrtuDGnSh+XpzF3xyPavCCjQm3l0OOzaAWDz5GqRFk 8Hnv4OS9dizxv8ewe9XPnMWhv9YndGNe53BtJWA9Kdtc5WUQYxzX2Pnvc pCb/AbYn/VVkBhYSYp+C7seHloMXjdsz5UcjlYJLkTf3QgWsBmkL6/6xX W9jdAiOc/D9/sU4DWwf9qaRNDnJQLw/HboqlVLEvzYifStgYyOqeyTvZZ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="300348541" X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="300348541" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 06:15:51 -0700 X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="706155891" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.6.54]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 30 May 2022 06:15:50 -0700 Date: Mon, 30 May 2022 14:15:47 +0100 From: Bruce Richardson To: Lewis Donzis Cc: dev Subject: Re: FreeBSD 13.1 changes Message-ID: References: <1154975224.4469878.1653824181427.JavaMail.zimbra@donzis.com> <200292248.4577111.1653915019819.JavaMail.zimbra@donzis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200292248.4577111.1653915019819.JavaMail.zimbra@donzis.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 30, 2022 at 07:50:19AM -0500, Lewis Donzis wrote: > > > ----- On May 30, 2022, at 3:09 AM, Bruce Richardson bruce.richardson@intel.com wrote: > > > On Sun, May 29, 2022 at 06:36:21AM -0500, Lewis Donzis wrote: > >> Apparently FreeBSD 13.1 changed the syntax of the CPUSET macros, so DPDK no > >> longer compiles. > >> > >> For example, here's one definition on FreeBSD 13.0 and prior: > >> > >> CPU_OR(cpuset_t *dst, cpuset_t *src); > >> > >> and here it is in FreeBSD 13.1: > >> > >> CPU_OR(cpuset_t *dst, cpuset_t *src1, cpuset_t *src2); > >> > >> I've modified lib/eal/freebsd/include/rte_os.h to handle both old and new > >> versions of FreeBSD. > >> > >> I'd like to provide the updated file, if someone would be willing to review and > >> commit, please? > >> > > Can you please retest with the latest DPDK code in git. This should be > > fixed there now. See patch [1]. The fix should make its way into the LTS > > backports over time too. > > > > /Bruce > > > > [1] > > http://patches.dpdk.org/project/dpdk/patch/20220520181050.55654-1-bruce.richardson@intel.com/ > > Yes, it definitely compiles now, thank you! > > Something is still not working properly, I think in the ixl driver. But I tried the same test on FreeBSD 13.0 and it also doesn't work, so I don't think that's related to this change. The problem appears to be related to forcing "wait" true on FreeBSD in ixgbe_dev_link_update_share(). Should I post that as a separate thread? Yes, please do, and CC the relevant driver maintainers. You can use get-maintainer.sh to find out who they are, as below: ./devtools/get-maintainer.sh drivers/net/ixgbe/ixgbe_ethdev.c Qiming Yang Wenjun Wu Anatoly Burakov /Bruce