From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B03EA0548; Thu, 2 Jun 2022 15:33:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1522940691; Thu, 2 Jun 2022 15:33:56 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 09CC44021E for ; Thu, 2 Jun 2022 15:33:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654176835; x=1685712835; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6hltjUxtnNCTb/GUg+3Co7p5qRkFveqeSJRaeiSzx8A=; b=ACuJ3raC0LLqDt4hAicOxS7/igzz5hImJKLoB41fSXf5/IrWudXTABlR 8I0oWsvX1zYR7Tu58Y9DqvsIjaCg1/r30Fpv+GvsQRlOnx/NTNA800GQ/ 7bw/fOaqAs21tkJcwhs6ii5K5QiEyC7cU33mFlbr4n5gKWem7oft/vN5R sIgKE05nZxNmVd/SlBuCj+8/eCE2+D30Ltn9CXGzEORUwESsqwnnxq3p4 L/flV9O3c1mwf/PVYilNxr6/2DRLUL7Hw/wp4mxVBZZQ8HbwzMnrfcqh0 73E4vHb5QJvEJLaUxBJAxFs7IhOgVVmJXSlQlk0Uq87w1bXrTQBrrTcP/ w==; X-IronPort-AV: E=McAfee;i="6400,9594,10365"; a="274750985" X-IronPort-AV: E=Sophos;i="5.91,271,1647327600"; d="scan'208";a="274750985" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 06:33:53 -0700 X-IronPort-AV: E=Sophos;i="5.91,271,1647327600"; d="scan'208";a="606843124" Received: from bricha3-mobl.ger.corp.intel.com ([10.55.133.25]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Jun 2022 06:33:50 -0700 Date: Thu, 2 Jun 2022 14:33:47 +0100 From: Bruce Richardson To: Jerin Jacob Cc: Thomas Monjalon , Jerin Jacob , dpdk-dev , Ruifeng Wang , Jan Viktorin , David Christensen , Konstantin Ananyev , David Marchand , Juraj =?utf-8?Q?Linke=C5=A1?= , fengchengwen Subject: Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build Message-ID: References: <20220602092356.2788089-1-jerinj@marvell.com> <7385990.EvYhyI6sBW@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 02, 2022 at 05:30:36PM +0530, Jerin Jacob wrote: > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon wrote: > > > > 02/06/2022 11:43, Jerin Jacob: > > > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson > > > wrote: > > > > > > > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jerinj@marvell.com wrote: > > > > > From: Jerin Jacob > > > > > > > > > > By default, ccache is not used for cross build[1]. > > > > > Update all cross files to use ccache if it is available > > > > > in build machine. > > > > > > > > > > [1] > > > > > https://mesonbuild.com/Machine-files.html > > > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > > > Does this still work even if ccache is not available? That's not fully > > > > > > Yes. > > > > > > > clear from the docs, but it seems to be that if an array is passed the > > > > whole array is used as the command, rather than just one element of the > > > > array. That would imply that cross-builds now require ccache. Is that > > > > acceptable? > > > > > > I have removed ccache from the build machine still it works. > > > > I don't understand why it works without ccache. > > Meson is detecting valid compiler prefix. ccache is one of them. > > See > https://github.com/fabio-porcedda/meson/commit/44db495f5ece43645ca3994dc95895c76a828530 > https://github.com/mesonbuild/meson/issues/1392 > > > > > > > In general, I would prefer we have a mechanism to update the cross file > > on the fly, depending on the setup. > > I believe, It would be a departure from the meson cross-file concept. > I don't see why we could script it and use it if people wanted. The cross-file used should be stored in the build directory, so it's associated with the build. /Bruce