From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D532DA0548; Wed, 15 Jun 2022 12:15:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C37C440220; Wed, 15 Jun 2022 12:15:52 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 21B7740040 for ; Wed, 15 Jun 2022 12:15:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655288151; x=1686824151; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iCHROJ6Lmlq4LXCXKo1PsMf/fZLNfvM1Kk39pA8lVls=; b=iMxytdLI1q8ihESfm1/7mZu+6qb9aYwUIeqdHdGiV4IWfIYTMi7HvmPF 8EB1isSeSGj1KzvfCWKHqLdkYR8Ev+Xr+tq2SRQENAxUPVoewqf9CMVUj MoJz+9F+nSBbCcFWnppiPCijSoGM7WxLdz/0SzFJ9D+gFVVX2y78hOeLA KfP6zg/wnKhAYSYdcXspB543z+xxanpII0CCuSCfH2fsk0k4VvPW1nVfh UK23etaIgnBRYWGnNIvtvAuQ2JghqZ5z1RWW8ePOiOboqSZa6XwQXhzj2 mda9+UIpSscYGnFFKOt2KnfxeU5fYOsyeUTT7edm91xKS8jspoyubDEju Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10378"; a="261935241" X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="261935241" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 03:15:49 -0700 X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="911563856" Received: from bricha3-mobl.ger.corp.intel.com ([10.55.133.106]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Jun 2022 03:15:47 -0700 Date: Wed, 15 Jun 2022 11:15:43 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: Re: [PATCH 2/2] common/cnxk: add include for macro definition Message-ID: References: <20220614122904.159946-1-bruce.richardson@intel.com> <20220614122904.159946-3-bruce.richardson@intel.com> <4422106.LvFx2qVVIh@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4422106.LvFx2qVVIh@thomas> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 15, 2022 at 09:06:26AM +0200, Thomas Monjalon wrote: > 14/06/2022 14:29, Bruce Richardson: > > The header file "roc_io.h" uses the "__plt_always_inline" macro but > > don't include "roc_platform.h" to get the definition of it. This > > inclusion is not necessary for compilation, but the lack of it can > > confuse some indexers - such as those in eclipse, which reports the > > lines: > > > > "static __plt_always_inline uint64_t" > > > > as possible definitions of a variable called "uint64_t". This confusion > > leads to uint64_t being flagged as an unknown type in all other parts of > > the project being indexed, e.g. across all of DPDK code. > > > > Adding in the include of rte_common.h makes it clear to the indexer that > > those lines are part of a function definition, and that allows eclipse > > to correctly recognise uint64_t as a type from stdint.h > > It is not rte_common.h > Looks like a copy past of the first patch. > Yes, it's a copy paste error. I got most instances replaced but missed one (or at least I don't see a second miss).