From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC1DBA00C5; Thu, 14 Jul 2022 12:10:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FADC42B73; Thu, 14 Jul 2022 12:10:41 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id F025C42B6D for <dev@dpdk.org>; Thu, 14 Jul 2022 12:10:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657793440; x=1689329440; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Vzko7W2l4CLYwYP3vbkLHy1cRyxis/Ea13AxRYAka3Y=; b=HMHAMR0g+2/3YJzjzLmEjdkePJsXuw55wKOKGPN3DtVoHD+xjw45Z9P5 zmRN3TfCuomXJ2I5bYGC3PMpVH017xcFscTkiUw0QNcQa89c58bQ4nxCf +etlyKufUVI2+o2Fvv9WlZZsp78Ui01Ungmj1t0JbavWnB7sjH4N8Zy4U gwoNocz2JMrPV/bU9vHkO7x6Nk9Jjts9n49dPk+tnQPu2T6ygyJChCgLo 3jVJV61l1JF3HibmGVU1agW4OH9J2ec5xV+K3bc+8e/z1mpIrzXzuKGAF rvSNR7ez8PHwgJ0w7fZpZWnRiKsqGiHPy1D/kkDWoaDBUNQvntS6JOXhr g==; X-IronPort-AV: E=McAfee;i="6400,9594,10407"; a="347153265" X-IronPort-AV: E=Sophos;i="5.92,269,1650956400"; d="scan'208";a="347153265" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2022 03:10:38 -0700 X-IronPort-AV: E=Sophos;i="5.92,269,1650956400"; d="scan'208";a="923015413" Received: from bricha3-mobl.ger.corp.intel.com ([10.55.133.37]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 14 Jul 2022 03:10:36 -0700 Date: Thu, 14 Jul 2022 11:10:33 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Olivier Matz <olivier.matz@6wind.com> Cc: dev@dpdk.org, Ray Kinsella <mdr@ashroe.eu>, David Marchand <david.marchand@redhat.com> Subject: Re: [PATCH] doc: announce behavior change for device NUMA node field Message-ID: <Ys/rmeQssXySY3E2@bricha3-MOBL.ger.corp.intel.com> References: <20220713155043.11490-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220713155043.11490-1-olivier.matz@6wind.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Jul 13, 2022 at 05:50:43PM +0200, Olivier Matz wrote: > The dev->device.numa_node field is set by the bus driver for each device > it manages to indicate on which NUMA node this device lies. > > When this information is unknown, the assigned value is not consistent > across the bus drivers. In v22.11, the value will be set to -1 in > this case. > > Link: https://patches.dpdk.org/project/dpdk/patch/20211026090610.10823-1-houssem.bouhlel@6wind.com/ > > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> > --- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 4e5b23c53d..5f269bf527 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -125,3 +125,9 @@ Deprecation Notices > applications should be updated to use the ``dmadev`` library instead, > with the underlying HW-functionality being provided by the ``ioat`` or > ``idxd`` dma drivers > + > +* bus: The ``dev->device.numa_node`` field is set by the bus driver for > + each device it manages to indicate on which NUMA node this device > + lies. When this information is unknown, the assigned value is not > + consistent across the bus drivers. In v22.11, the value will be set > + to -1 in this case. Acked-by: Bruce Richardson <bruce.richardson@intel.com> Couple of minor rewording suggestions: * "the bus driver" seems wrong in the first line as we haven't referred to one in particular. How about "...set by each bus driver for every device..." * "the assigned value is not consistent across the bus drivers" - this reads a little strange to me and I find it unclear. Not sure how to reword it, maybe something like: "each bus driver selects its own value to set. To resolve this inconsistency, in v22.11, the device numa_node value will be set to -1 by all bus drivers when the actual NUMA information is unavailable." > -- > 2.30.2 >