From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F009A0032; Fri, 22 Jul 2022 17:24:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 067D64021E; Fri, 22 Jul 2022 17:24:15 +0200 (CEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id 95A2C40156 for ; Fri, 22 Jul 2022 17:24:13 +0200 (CEST) Received: by mail-wr1-f48.google.com with SMTP id a5so6944751wrx.12 for ; Fri, 22 Jul 2022 08:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=qwQ8bto9NYIAVIWA1m09HSpSpTiS4OIbQASVyKFadvU=; b=OpxnBWsIbOTYhZ6vTQo3KWY1oijPk9nhOP9j/WCKHlA7Bl6Nn0seV1zNQ77VryKZRK peucrQt35jwKy1wuiov27JRrxWRsuXATXyM0U0Hp+5+UuS5sdgRFYmLaczK8Rervzvmf 3DProAQ862B7bPSn2HuUW5PJXDMJ/hsXNRoXO3C1lgi1wHq20oITn9ji4VsQ8onZNutD NUl75LBRXRpT4M884TpmuvC6AWk7FT92NLTNp9P4XKcDpN9AiosA0S0NsTqo04wQJbOC nV9R82x31CouKAEGURNkjZRKPxicvW/HN4VdQfpd7z5cHV05cPtqiEoBtAUgCXli+kRy DLsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=qwQ8bto9NYIAVIWA1m09HSpSpTiS4OIbQASVyKFadvU=; b=p0vDYvlVFqdD1gdPxtLpnPbltf8K6rxhZIwNJq8mdK+cG96n0urxG/MWut+BqjWODE rikDirTkDzpdurQ6219eOQOd+SWetIbVBKU6NlegiGcSgQvXOUundqByYUIEvW4Tj6z7 63f3Yarwy+hUE4qeJJfKi2mb1ZX9v0UUak2oj4tMtnEidFMNt8rnJd9/BXK8bLzvF5xo E/VAoecmrbWJm/MNl2JLOIkxi6qg+YLvWq0J7ofJ4T8dxkxaMxFIgKEeTAeOiuYxNN1w nhxwVswCi3Dezf9C4SJEPMNA6B48DSrzqj+aig9IiKd68aITNyIblzAeiCr/fgC6bDaE /pIw== X-Gm-Message-State: AJIora9Hl71RwbD1LdhhwM6jmn84ytpPyiFSrbL1nQLb4T0WWLuPRTGa z8N2NLZ2PH6B3ko8uAvaCMG2x9KlsGoqug== X-Google-Smtp-Source: AGRyM1utmpZh0eaQ4lpc0e3Xu6qKebvikMjJFCA5VivRxaweBQCKQ4mjSg31rf0NX7cJEqGNq+wifw== X-Received: by 2002:a5d:59af:0:b0:21d:7f0c:a1ed with SMTP id p15-20020a5d59af000000b0021d7f0ca1edmr305368wrr.211.1658503453281; Fri, 22 Jul 2022 08:24:13 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id b12-20020a05600c4e0c00b003a2fde6ef62sm5349334wmq.7.2022.07.22.08.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 08:24:12 -0700 (PDT) Date: Fri, 22 Jul 2022 17:24:11 +0200 From: Olivier Matz To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org Subject: Re: RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE requirements Message-ID: References: <98CBD80474FA8B44BF855DF32C47DC35D871C5@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D871C5@smartserver.smartshare.dk> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Morten, Yes, you are right. These 2 conditions are also needed if one wants to use rte_mbuf_raw_free() or rte_mempool_put*() functions to free the mbufs. Olivier On Thu, Jul 14, 2022 at 12:46:24PM +0200, Morten Brørup wrote: > Looking at rte_pktmbuf_prefree_seg() [1], the list of described requirements for RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE [2] seems incomplete. The following two requirements are missing: > - The mbufs must be direct. > - The mbufs must be non-segmented. > > [1] https://elixir.bootlin.com/dpdk/latest/source/lib/mbuf/rte_mbuf.h#L1308 > [2] https://elixir.bootlin.com/dpdk/latest/source/lib/ethdev/rte_ethdev.h#L1701 > > > Med venlig hilsen / Kind regards, > -Morten Brørup >