From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF674A00C5; Thu, 28 Jul 2022 18:57:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A489542BD8; Thu, 28 Jul 2022 18:57:09 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2B0484014F for ; Thu, 28 Jul 2022 18:57:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659027428; x=1690563428; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=exLQIg8ytu4kqyYcl0AG8vP4RxWbZF4zYBdrCt37iR4=; b=nwquWHoxRByYJ9SVeNiIEHqz/7CXqyZW2W75QKaVo4cuVc3v9uw7Pk4n pYdUPUVjI0LAr0j9Wib6g+9C6dTRgvZg4VQbZ60D1GMuIF7Fk9n7fa81d 0Vb/t1LN3YY0vpcPcyikkQd89Wb8EY67K9IIqpkid5NfUr7Ea/XSiEVCz fL87giZJ6oOrbfHvuKlEZXtNiJKMFedK6MGe+9I5jcUUUfqg3TnaQ40Om 7Z5UMi7Ar/MUCgDKeKx6DMB9uE2y+Tse5QquSCXzr/LWWvrk7E903fFEa NwWdXgFGOuBAtbXcdBi//nZXu7lxYEvI30Gw3jfD475ElVU7o2bkdlDSc A==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="287318407" X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="287318407" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 09:57:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="597936898" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga007.jf.intel.com with ESMTP; 28 Jul 2022 09:57:06 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 09:57:06 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 09:57:05 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 28 Jul 2022 09:57:05 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 28 Jul 2022 09:57:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ul+UFMUXmr5+PsKbaM65nCLPt7TCmZwiqITYkAVjcEkxksydK1mnhp/BbvZcCO6uloe5O2vnttVv+qfM3MTT0HF6zU9PBHWnLn/u8ttZq7ebV6DeGORknmTDX1Mzi4B6K3BKR3QzkTpTHr1cBi/aJSGS3o6Gatg3WI7LPeGyzm5RDjnvXl8U66LHr5kRmIccuBMKmCbMZd6qhZMsBXQ1pQj+QjlgA20iuUDWgmlZ+y3pSh3UbUOpKy8+WbkJXCOyyw+0XMO3Bbe84kQbHWQI3NrJGxdR5kSOKnK/sXzTB+nd7ZbHxqfaFfe+4/nXWux48m4h5VzYivXLUaUzDQGlCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vRJpdmF3+QDNMPZSGya745tV8tkUrsgmpFrS81xJ8W8=; b=AT4Tj10G1t8zOJhoFUM2BcfpDZ4HFEm1MFcAY4uSa6Ak89X3hOpocoU6bPkrZNlDcY3IY1hDX4F7zYF5TFIc94q/fzMN2kBHnFb7w6UFt5SWgFk2OuGbYggMJwQQYULOozlaAk97FuAn6HPLdTf+oBG6D69lO5mPsrYNCQFET8oclpT+RoI+xUHqEP/YOSb+h3qcRdRSgniuwN5X9pqWIF2Qj/+/zsRJyaDgiFEC9CDCDDqTs40DDJQe7Re9hAv5/hKgUCPgHQvlxcoGV/eukxInOjctqpOSxqMaVsxwb5etv4XqsR951u238fFamz0/Guvig3yKU3yV/dYrQgSINw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM6PR11MB2537.namprd11.prod.outlook.com (2603:10b6:5:cd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 16:57:02 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d%5]) with mapi id 15.20.5458.024; Thu, 28 Jul 2022 16:57:02 +0000 Date: Thu, 28 Jul 2022 17:56:52 +0100 From: Bruce Richardson To: David Marchand CC: , Ray Kinsella , Parav Pandit , Xueming Li , Hemant Agrawal , Sachin Saxena , Rosen Xu , Anatoly Burakov , "Stephen Hemminger" , Long Li , "Matan Azrad" , Viacheslav Ovsiienko , Kevin Laatz , Chas Williams , "Min Hu (Connor)" , Gaetan Rivet , "Maxime Coquelin" , Chenbo Xia , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Reshma Pattan Subject: Re: [RFC v3 21/26] bus: hide bus object Message-ID: References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220728152640.547725-1-david.marchand@redhat.com> <20220728152640.547725-22-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220728152640.547725-22-david.marchand@redhat.com> X-ClientProxiedBy: LO2P265CA0312.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::36) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e1f2b79a-069d-4a82-1592-08da70ba3149 X-MS-TrafficTypeDiagnostic: DM6PR11MB2537:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ztLwMZT85fBf4On/F266jfVPyezpQw/dNrARa1/pZ9FJVxZClRVKsn2xtSG9WVnnR8UUbgHPicHl1G4FTLngHgu2RoboehzDafgTxp1FMFPyTCSJlY7L6BJb56YXdT0j1RF6D9qTCS7Bx48GmLqS9b/JnhNa/JkySlUT2CM6AMu4/zR7qFy0Er0JG/W8SH+esv0Ny8reKZcmnk5w9Zf0o0aqv36aksebf5xQYKFvZEhBot6+fwNGDPNnpA8j8WjWOKcr7JwfJ+p9uozS7V4+w7oRh51C+8FizEwQpolh/zmappxVigSuYmPVb6tEDKNucJhUxqRqnwiYrv//CxtVRy86QZk8dCbQ4Wu/+cuBClLCgzMWEasSMO+K7SMb6Mzq40YicwwIX9MqwVXpoMsupsIUwzANySKaq+jyAhbpWmW2AYeV9w4GNMUas/k9jOmjp7u3pt4cwOaE9p9kT4Yw2uv6iTw2H6Yfq/60v0FrC5uhaogLFudfdYMdyw2ttXWseeQ8CFrE2BRccOOtenf8nfO4b0k4WiK/DkVhRyP+7FHlYvD4q+gpNypcTaDYpFs0g/WPdD4slN8Z72q2fT2MVjES6IrlKELml467KKZIihJr8uEpfmeZNvFdQ1AH9+FJ2YIxcqgdFEhCjP0ndsSvhQsUEPdyjjzXv+NKoNGqde6hQJzJWTvxetjoeczvm24hp1cfR2ZIaIqFL9IZMsFNrQJ+0/qAWp60Lq+kF+Ch6EutEcmCBlUGcyqNP3BN3BVH X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(136003)(366004)(346002)(376002)(39860400002)(186003)(6512007)(66556008)(83380400001)(107886003)(66946007)(54906003)(4326008)(8676002)(6666004)(66476007)(6506007)(26005)(6916009)(8936002)(2906002)(86362001)(6486002)(41300700001)(82960400001)(478600001)(38100700002)(7416002)(44832011)(316002)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QTP8YvUPFXlMGLX02hKZxDmAohrl4fyuJGCc3t6NnaLlCDadtV7RYnYTUIZL?= =?us-ascii?Q?MHLhCq5dDT+FMx6hEBmjgbHo6gd3h4FskdL9FP2hUL2WXDzWu45R+I3tOiaQ?= =?us-ascii?Q?SCCqgc6hteLcaTHX4zrbNWpsbWOcuo11GOTOnlf5tiw2wZ9QPWs62e6L3H9k?= =?us-ascii?Q?e+pUPqdOD6GxU/7JVQR+DXeJSogfAOtPcrK8c9ChsaU8aFwbqvZIBLgNKHC2?= =?us-ascii?Q?Tn8WkWI8AypwTacdN8LHUeCPR74WBTO10LE3sOQn4QsrOwCgh7Su+Ya63RtG?= =?us-ascii?Q?J26l4UuiZXIC0TtWQyyQYcJmnfIs05nh8i4NrMYyivRuxyRLsODQzKDxT8qn?= =?us-ascii?Q?1l+biEzIBSvWurF6GsWAIFyk8+Gzcaz82OnBC/6s5APtXU56DwsfFdbWvnuJ?= =?us-ascii?Q?bkeclqLczOMpOEozkoFoZpcIDOO1cPchiXwNK2SFCZZ1WVGITIg4HkT3fEmW?= =?us-ascii?Q?ZsU9mqpDih+hp4mkUUN6La/T8dijayMtiqiXBaVMWfyf7GvCuWJO1eEI81BT?= =?us-ascii?Q?2e6zTwsIVUU1novUg8D6f/feiCwxAISTyi4Io4SDbI/dkuV5ZyffqbletcBL?= =?us-ascii?Q?t5PRfsS+6Zx+m5dRJa2ClIWJAgDsCqGdu48qnqZZqhP719d2bqKZhLZ/B6m0?= =?us-ascii?Q?tZsdaksWFjU9TRaRGFwvcS7I1Vtu5SA29N2cj3TdUoc/G8m68ToNC+FdvA+c?= =?us-ascii?Q?wKGl0cP3RdBOG9ECc5hew1uQuf2uemClRs6YUNbqWwkvxTCSIu+ah0qNgt3+?= =?us-ascii?Q?ekrA0Y9FGuhJ7/aMBZA42vItglZGe1U6rZhKcgKmA8lzC35w/fam+H4n+UGr?= =?us-ascii?Q?DyvF0FxdJ87fHyMCpblkmXbbKjoFuZuaStjQzXlEiJ3vU7GtByQiVatNh6/D?= =?us-ascii?Q?LH0LIpG/Ow5Nm9l0QcVzfmCZy9LjqRCiCOyXcwqMTG2FQt7/GDzP/QUqloCo?= =?us-ascii?Q?oJFMnxhFaeV6trSvHJt6naVoY8MiUumLQQTCPJwqb6DegZdFMuuV7L6Tn9uv?= =?us-ascii?Q?qh9y+WxdU6WXOwl+7cCXOepOrr/gbBVNuPnFqoaxK65j7q+HFWWDaaajolS/?= =?us-ascii?Q?UtiZzEOCelAHiIFtR9J0RHbVddgAYYp+K1dJoBgWOiCL+b+LVPeg/KpAGrfS?= =?us-ascii?Q?LcufuvwUQRA+sOO39fumj3VAqTSa2YpVtMatLDd2rXD4tg3iUcorRrq054gW?= =?us-ascii?Q?ua1riGJTej3auJjb8DHK57v3rTqNDE/6729IuWC/QvBV2gb1PDKq9SM4mA0E?= =?us-ascii?Q?xogN/I8XZ4xCFQs/czKIs37dFS6ChbC4byQIFoiwelH7knvlo4H6CBVZDDFF?= =?us-ascii?Q?on0xEkI1nSzgNeduvU31FxE0WD6uQMxecm9TRMJKQjupNJ7b4+sDgR938d83?= =?us-ascii?Q?LlPtNcoIxXBjxLVuuCnQSlqPIYIrrCkSRG36gJkdKpz9SIWTxtqxlsoQmjcT?= =?us-ascii?Q?zBFv7t8TNxBk220z6/wxMW5PHT7MVHPy4LJIN3siDWiq4Nl5WIMtQr9PSnIT?= =?us-ascii?Q?eADCCZ4OpPoThwdbveGZNydlO1omRl8BAOV/AB4jc3ikxqBAZv8t/VwYyFUK?= =?us-ascii?Q?eLQwR97dGpEzIUedVzTpHJbFfFa1HmGJEHiFKDxz2/HW+mVpomXvP87P4IBx?= =?us-ascii?Q?KQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e1f2b79a-069d-4a82-1592-08da70ba3149 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 16:57:02.2416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HZasqKMG4h0s72HXtk3VnupVs4PpsSBP9Nn7BiLERM5HiQL+a28LBJwULLkOtRDkEFTqZILc29UKD7KJ/q2qSfF1fBu2QA9wf10nE8hgL/U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2537 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 28, 2022 at 05:26:35PM +0200, David Marchand wrote: > Make rte_bus opaque for non internal users. > This will make extending this object possible without breaking the ABI. > > Introduce a new driver header and move rte_bus definition and helpers. > Update drivers and library to use the internal header. > > Some applications may have been dereferencing rte_bus objects, mark > this object's accessors as stable. > > Signed-off-by: David Marchand > --- > Changes since RFC v2: > - updated release notes, > - marked accessors as stable, > > Changes since RFC v1: > - update all existing users of the public header to use the internal one, > Acked-by: Bruce Richardson One small comment below... > --- > app/test/test_devargs.c | 2 +- > lib/pcapng/rte_pcapng.c | 2 +- > 38 files changed, 343 insertions(+), 319 deletions(-) > create mode 100644 lib/eal/include/bus_driver.h > > diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c > index ac5bc34c18..0a4c34a1ad 100644 > --- a/app/test/test_devargs.c > +++ b/app/test/test_devargs.c > @@ -9,7 +9,7 @@ > #include > #include > #include > -#include > +#include > #include > This seems a strange file to need to access bus internals. Maybe something to investigate in future.