From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5D43A00C5; Thu, 28 Jul 2022 18:27:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7841A40151; Thu, 28 Jul 2022 18:27:46 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 43C2A4014F for ; Thu, 28 Jul 2022 18:27:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659025665; x=1690561665; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Sgj+EhZpGYH/LebymLxb+DkjY1Bj50GI40t7mLP0Zdw=; b=m3CmkPVjxNsw0/sb8uB5nnYDcLZca2mx0HYeNw7oGRYhKT3puKW0lQSR RmVFR2c2cKPr5Sn9oNBc4c7nZcHhBQPf+YlnSVNJd8eN4FV0G1IgF32Vl llJ2c2RJqeLYQfQ1rjdmYIvajS4qv6ywVh9nNng7asO77ilKJY2AmVN1i WkaHht+h5ujY2+nTTWNx+UctI9S9tmiWfYVDvj1lUD7zc0ml7vBpFwQD3 85Z3yTE0xNNIB4fvoMR34OVkoNDg14LY17a7iwQO1cwK5RgMi/AclzrzZ +wl8odDbModTWfUU54yjBXy4yBZdmorD+u7wsnejQxkwpox6ZhHJKtz/h A==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="350261315" X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="350261315" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 09:27:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="604638943" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga007.fm.intel.com with ESMTP; 28 Jul 2022 09:27:07 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 09:27:06 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 28 Jul 2022 09:27:06 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 28 Jul 2022 09:27:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZNgeICq1uU8YUVgVXmylCarFK6ud7xZBvcg6Btf9CWJuLqVhVaom4Ddzo1ksXjCwx+mA3cqcmGurWp9VFzF9y0YyAG0B1fH5CJOyoqhJjRgepobruOp8FPdDTy7wxJ2Rbd9J48aUkoTeHW3zYOAI7PfTF3ScQxsBdILHRYlpFBSejJ4G32hl9h6Vc0TfESCqtZXzbA9MgG5fk5xYm9z95kF28f4sOvIo1/pRFLDTGdiaD047ELbD5wuMP3Y/CwNB6SD2oToSwy+5AG0/ASoyiOxWM90ehG3Msbmvpg+QYNPEoSF36Rgb3/9GE7+7iD5TJXDfA2zXt/RnapOUeSNbhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nT/vRrpRJ6Q2Zr8dny6TKxog+ZU7F4MYXFqYelsGobs=; b=kIfzNXQxDDMB3qseGOSlt9TizS6bIEG7VxJXILb1k6BztX7ipXPijRfoKhEstsP/V84ZLMV/aZmdKKQlwB/2xfJxxMdQcbRQ8H2Ux4Ig7NWjkUKR883G6wrpRTzcYOpdGZ+2lHrwsCLkXTtMYGqsRlzB6HRyWnCI3Fw7LPeKxOBkjIG6vF/4A4ENQzgiBjlqbFEFfHjvTRq7iMd4lm4ZWqjNF5VF5vtldoy9uAldZjT7KsJqqpqGwi5B2rqp9JVEZFC//N/viUX1MUSiW1opTSj00OskRCnrwx+SPs/fa35jtNTNuA8GNMrytQKnhsde9XGcsgvNq0uZek1XEZuh0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by MN2PR11MB4416.namprd11.prod.outlook.com (2603:10b6:208:188::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 16:27:01 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d%5]) with mapi id 15.20.5458.024; Thu, 28 Jul 2022 16:27:01 +0000 Date: Thu, 28 Jul 2022 17:26:54 +0100 From: Bruce Richardson To: David Marchand CC: , Aman Singh , Yuying Zhang Subject: Re: [RFC v3 04/26] app/testpmd: drop PCI register commands Message-ID: References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220728152640.547725-1-david.marchand@redhat.com> <20220728152640.547725-5-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220728152640.547725-5-david.marchand@redhat.com> X-ClientProxiedBy: LO2P265CA0315.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::15) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5fb685d9-e692-4f73-a68e-08da70b5ffbd X-MS-TrafficTypeDiagnostic: MN2PR11MB4416:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v7TNCpVCpMtiFVdEKKxQil52Vg8wLXmgMycvutx5nKhzdm9Ghsu5OlkA39umvht78EErbQDO3znFPM4qOydPYQLYlml1aQyyO/cHv/DsTjDD4F2meSvLe5rWaq8UMaaanyPeWG18BwTOmeTxnE9efY5Zo8Wt7Xhj6LEl1rg5mBE5qbrjI6BR8+hl94wtwVZSvLBBiE6JFs5o/AZalZjKfpo5Q0JJp0OrjNAR7JrzlIT9oyuO+Ny8jOksq/pqyQz6Z5pIgBFcG9nmKpbP3qwOXN8asGOlWtTD12O3HSmHSGTJ4vTzxqOTJU28O8xx7bZ7L8DU8188hoAIAsG1Be+ljvFzx7Hp2KUoJha2nDeDrU49QGWdSQ2ETV7Qr2uWg8btDRzwCrMz2H42/RlZ6EBb39V4+DlXkN2uXE4UOyEIyjF3JOjLq86ZBgD/zLmg5B/OPLMyG8nXZ8y5UrhnKa1eQYAH9AFnu2IqktiEsQqtg2n9ponlWMK3h4Vw+llp5SRcO/FmK/d+519IKG5TifSm+SGaUGdDzM5ZA8Rcn+ubMvYgLDJKBxOHbv+nVS0lYsXMWgDLDInmVZHUl5O0MMMqeXAkmzFCyLKpKXi2TeT8fio95o0wUBxIu+59GBouvhmimi014VnU+ndc3QyWjnqp7bvJZ7RfKtHHHmAJ00/lca6RsXOj/tDDcEFUMUCYml/sjhze8YyrawEKNzzMyHUyU2uKPr48d/I5CVz614IMYR99Z/oL8rBUv5uGnrSL6F6U X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(396003)(39860400002)(136003)(346002)(376002)(4744005)(6512007)(8936002)(82960400001)(26005)(66556008)(66946007)(54906003)(8676002)(66476007)(6486002)(6916009)(478600001)(41300700001)(6666004)(86362001)(4326008)(6506007)(186003)(316002)(38100700002)(5660300002)(107886003)(83380400001)(44832011)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xXDHbzGjXJwnr/DzK6vNImw6avPQnlnTyN3yKbD75dcvhoPtYQxV+E+gqHXT?= =?us-ascii?Q?BJwzZK0AZq7XkDcHWP6WkFTC8lx6O3rexCCQXThGz0Jjp6aDGSwe/q1EqJC2?= =?us-ascii?Q?1jSakwMxBrWYbW2kWR3EUKlW5vPvXpw6tWYoTiMylpiaShkLsla4JVdpntLd?= =?us-ascii?Q?brNBTe6X727VKASBSy8CVMhEa8Gb/9JyevbV4esaNBMePBI2QJnz9NNidNhO?= =?us-ascii?Q?5TLW8SaJEIzAijk+WvyrY9OWjGJ2KggKdE/8sCq5ZB5iM5To9eETOEMVPtki?= =?us-ascii?Q?gEXMnP1iHvBwvrRg8jW7rVKxEn5gTz6Jxh29KgrbL8gXOi5bg+OVfHh/ltws?= =?us-ascii?Q?W9qEQmGaLqiCnvuiIg3oVM+IGvE8LT9EHeChnyBXmuhm0gpqKrxufNltPqad?= =?us-ascii?Q?l9j4uo1/KGJb1/pLPnoVkNntu0QHb/mW14DJQz+vh/Xf45DK4+yYnYKYGLfe?= =?us-ascii?Q?PMlz69tdJz+699VTGOq3X3kDxwOAlB+XY74kPNWICeHvpgs5VtZip4Ydjr49?= =?us-ascii?Q?80AkPZHqeYo1E8S+3ufWRojYbCH44l6GgZnKX51xlQlTMlzyVYUf0aCUgwhn?= =?us-ascii?Q?467GAZKzn4/lW01ELqsXpSxFPKFObomjvgSPWqS7mj6s29vhgLvZCzeR1ebn?= =?us-ascii?Q?wdpk4W/2ScHj0+0t0Ztx3lMAXhc7k1l0fETMzqC3KsMIN0pXU209AVSHXfof?= =?us-ascii?Q?YIl04LYY3GqGGA4o4NIzWQ9i1TKvnR+5T6ZChniVRRZ61U2Q6vx66IwNcAlv?= =?us-ascii?Q?OZMJKNy3C/54idGjPldqvQ3hqXUcaLEHlolnjqDJsFgjiAvZPMoepJISQdhq?= =?us-ascii?Q?+yRYehdxCyIaUsJ826PfUebm+qrhvnXXGN55XZQ6Qm4bXkYonft0NxmAR2ai?= =?us-ascii?Q?KBkP29HGqpX3eKpanbmOOw4V7kxx64G5AFolU8NiE6TMJbPY30e2by8I1MsF?= =?us-ascii?Q?PN6GbvSgJ5Ezu00OcGlrV5PLx2KrHC3aePYJvTRns+pWmGMPxkBKi0zuKJz2?= =?us-ascii?Q?EpN2/yljcD/HexCgPPja+6SA5Pdxih4gwlIvMx0y7OSzw6hQl2apqRYluI3O?= =?us-ascii?Q?t268puogWdPbl3LFy0RXPj3BD54yPcoMHiHQqPLBSj8usRhwZx8MkbQr1qCQ?= =?us-ascii?Q?Y47ML+POVPCNpLIAXP8yd4Ca1ZnXMOvE2cEoYuU+oFwprVwQJtRaSJXNcx2x?= =?us-ascii?Q?FRV5a1r9kPA63E+czweBGTYFpSn0Cf1msbs82prdjc3UlHfb8NI/aQiuF/t8?= =?us-ascii?Q?fBdCD9Qnc47Ox+x17BfsJJD7Lry6NrmPSxmYzNDnniRP9LmiliBMUg3KPCs4?= =?us-ascii?Q?WgL/OKtrnia6vIRpBG59136T2g95DvBjkaqa78qnXvMUqRkSVci1ZK/cHJ/g?= =?us-ascii?Q?ADWeXvhvcEPxkgsdwiYb5ccPQcPfWh0nKlj4Rn7xSX+cSS0eE7fSB6G+LcN3?= =?us-ascii?Q?4GaiQ8mslbVWocKganygrfSbC1bsVq9BsRYoz1fJkwcHkgbeltG3je5qHoea?= =?us-ascii?Q?Smq3kl47g5ST7Ra8ocu7sIAbVKWoUdESMBs0H0jOnPVmyiztUD9lm2hETDi8?= =?us-ascii?Q?pjcgt9Z0x9x+DXyA35oxqrzuTGb04BO0VJj6B8kQsgEFC8qmJkgQc89+sW+a?= =?us-ascii?Q?2Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5fb685d9-e692-4f73-a68e-08da70b5ffbd X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 16:27:01.0700 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kweabukIh9p37b1/1LVcu3Vo8GjtUyz4k/76EGn+eVgJtFr9f56qq2A/6O8X8FLFGV77ydWdPTve5V+fWs1KxhyvQ1bzJh5w5ICcYoY4rLM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4416 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 28, 2022 at 05:26:18PM +0200, David Marchand wrote: > Those commands date back to the early stages of DPDK when only PCI > devices were supported. > At the time, developers may have used those commands to help in > debugging their buggy^Wwork in progress drivers. > > Removing them, we can drop the dependency on the PCI bus and library and > make testpmd bus agnostic. > > Signed-off-by: David Marchand > --- This should really have been flagged in a deprecation notice in advance, I think, but there is no rule that mandates a deprecation process for testpmd changes. Therefore: Acked-by: Bruce Richardson