From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E04DFA00C5; Thu, 28 Jul 2022 18:38:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89C3E42BC5; Thu, 28 Jul 2022 18:38:25 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B11DE4014F for ; Thu, 28 Jul 2022 18:38:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659026303; x=1690562303; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=16rzaZQL8CYcIE2kw+FO9CrbOoUGD7EVQqBW8/kAZAw=; b=kdWDNg0mrZWZSSe6mQMYTtIUfjsAuJQfZKBai31tLpj2mnKPWAGJvt8A S28ahn9uh+KGz6ehcNeMd9c5/bWQ45BJGrYZbHamDkH6mtQMHFrlW/piq sN6NspYRufIu2YACteQ+OajSgYThdUCJGk3+Zj85BPnrDabBKyzHZPp/H GlG6ol70qW/lWaBhIN4OPfAUd2ILIC51bQadrd7hju+/CVyZU4Co+oaJV kmx5ZUmYXQX0URHvGTLzpAz1wsa+shJhcootMb3gAEW0vWguU84jyes1g 6WdUS3BWrzqKshRKi3un9f6ZLmI+AUVSQjD19OvW0EjV1FSFlzE2LFAnQ w==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="374862023" X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="374862023" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 09:38:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="633769055" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 28 Jul 2022 09:38:22 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 09:38:21 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 28 Jul 2022 09:38:21 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 28 Jul 2022 09:38:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DyKtPN5V0Vz2pfbn9mR8X/90J6BEa2jXcQoCpFBt8e/3FKKSdBPbwwwir8aSH59OLJHSvQ94Kqp4T0dkmSuK33BcCbUxAH+89A48lqudemA6e7IhllnIh8dSEylAMpVccii4ux97wKRRj57UWaaFGMoMC2CFq7Mqc3zXf/R23LhOOgJwxsImEj39MNSppUxooADLxeCBVoLg2jZ0CUXnOMRbOEEYMeT8vU4V/WicijImqoCIgH6BVB7vctR+M5rBlgWSrSrkpJ4Ex5v26vknV7TV1wnxyqnCYJu+FjV+5OGd1SiV84gg5PjFAuuU9cjquZua015WNAwEPmD7C+0dxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R3bfeGQ7hU/rMGLodMnlmKm+ABU/h4WLjkb+cDQMjIM=; b=SEXf8XoVjhnjgYk8a9VzZjEGR0tQJ6IiEEM/WLMXl5iXfVmeAbxF0j4bOQlj/5faP40FsaGpFKqttZqv8ZcZWoWtE4JWVRCN8K9RE+whX1btI6DVm/IlPUx+ae+w0El8MLIsDCe6/XkRBukt1nA5Wjvfy+t83yiYdvu/xgbTAIUQpqdVjRu/4URklEnF6K0cDjeK0r+81C3Y5KUNd+ow5KKouKE2/fVYXtQzfLDERT3hkqoJkep4cjVtbkl9URrPDuJqwMOu2dGM7GFxJ/+5D3WyZan0XBU+G+flxV5Sx2dn6W4b6owBYxcdcdKp7vhMmrZn3UbfWzU/sCe6ctmwaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM6PR11MB4474.namprd11.prod.outlook.com (2603:10b6:5:206::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Thu, 28 Jul 2022 16:38:18 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d%5]) with mapi id 15.20.5458.024; Thu, 28 Jul 2022 16:38:18 +0000 Date: Thu, 28 Jul 2022 17:38:10 +0100 From: Bruce Richardson To: David Marchand CC: , Fan Zhang , Ashish Gupta , Qiming Yang , Wenjun Wu , Shijith Thotton , Srisivasubramanian Srinivasan , Chengwen Feng , Kevin Laatz , "Thomas Monjalon" , Ferruh Yigit , Andrew Rybchenko , Olivier Matz , Ori Kam , Akhil Goyal , Maxime Coquelin , "Chenbo Xia" Subject: Re: [RFC v3 08/26] dev: move unrelated macros from header Message-ID: References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220728152640.547725-1-david.marchand@redhat.com> <20220728152640.547725-9-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220728152640.547725-9-david.marchand@redhat.com> X-ClientProxiedBy: LO2P265CA0408.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::36) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5d3f58d-4c2a-446f-ed89-08da70b7939a X-MS-TrafficTypeDiagnostic: DM6PR11MB4474:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +LvlaMEm19LCkqA+DqK3scLxz0fmDFSWJkdXr9oFeV8mGpZAobNqQaPAFk/ksp8m2jxBRBucU4UbiJWZR5U47U9+qHlbFi/oKHwbNv/f0OBs588vWoNSd3RJB9DTy8vTTO9KPhxLlNTPs1N4dBdSaqF0uduBt5CRJ7/+kY3XHnAb4Eu1XdNt7pvmsdJUcwzZkhUBIfqHzzmSq7eIehTHcqkP6kcFDT1wkdG+hHJ7a3aFfBxnIn48oeW+HnJq6/tEwexAcheS1ST4VrLZaEe6DRSI7ni/2iriKamGiwp1z0HvQJOm3DGg9GqUT4SSioA3IM6rdT0d+4EQTHxeqOkLLTSAgCi65md0bRUkFhNssbqDiLYgwOV9Fb0WrpaYXHyqoiBIfUB7PeymXKC57dr3TC8rk5ga7WllyNPnxh1eua7IBGJHYlAgvVT1Sq45u+eYMjHZyRMtJToYvubtRahTfCiCn1YB76D6jiKtaRAiYSZ08BXa8UYVYD3RDx+aLSvNPw/bhk+Izpt4JB46JzJ8axGsDB44avmw6wC300OTBmNhvkWuFhS7cF2/+ec7axMmhWNCXwTiqKiB7P8ZI3vUUpB5xzdrc7zE2hMqtnI4mlgZzWynV5VBXlXKyfXxvVU0b5mlXRpI0wdIPHXZOvRwSc/GfrSRluRggm9kQx9lIijVM9k7ToAH3vFqq8JlAdsVgctkMufJBpfcQhgLElEFKys37kRxtkYmU3A4BK+3Yc4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(39860400002)(136003)(346002)(366004)(396003)(6916009)(86362001)(186003)(44832011)(5660300002)(6486002)(478600001)(2906002)(54906003)(8936002)(4744005)(7416002)(107886003)(38100700002)(26005)(82960400001)(4326008)(6512007)(316002)(6506007)(41300700001)(66476007)(66946007)(8676002)(6666004)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6KLYsqNv8Oc+x1QbIKMjI4Mi0nrMJ37IMXSQE71kupOaez0JktAT8m3AONKZ?= =?us-ascii?Q?QVtrcZzR9HDqHqZFgZ7ncS5YkqMQ7iRaFksW65z1AURDWFfDjZLTEbxVo8K9?= =?us-ascii?Q?HY/N/RuecxpAE5zOhC+zPdCeahny2IFWEhc9K5/yKOmfXQZJMYNeyCEk9g39?= =?us-ascii?Q?Eso0NbGiXmU9JCXWW9iOvPP7v5A973yMzfcdPO1yoNtS0gf2NmFsVVqe/0VN?= =?us-ascii?Q?wiYmJg4qieGaVcc6N7fa4ZQ1g6Bm64p0dyKIpt8OxcZBg3NEllyu07lNlwlx?= =?us-ascii?Q?GcQCP2YkyNhsz8sHwwliZ6wTNds/BFr9acnidqqety/JNJirxXOaiul/pqiN?= =?us-ascii?Q?R4wd5v4WUpI3gyVafdGjHo+UULbTZfGaWs/WXN5bQs+I8WUVl1FeoBppyRNi?= =?us-ascii?Q?5t9/ARKhQ/Ia1gyd/OrHegadgphx2zivakZO6f7jAj9czV7vhaL1b6YTj+Du?= =?us-ascii?Q?dUXH5GhAdNR/rLqEy7RW621ViwPoyCIpcmrxfb7wYbvyqJwXOrdz3chsOKWT?= =?us-ascii?Q?I3YOD4K6zE/p2BM7PR4ZLVD/zEO4EYUAPq8bWtu5tQ3jFg0Kb38V0xzHvVJq?= =?us-ascii?Q?spe3w3Q71WdkKow2+ElJS7eHrN+gZH4TNI9v+rzhO8lY5qn3aof21hPTZdGr?= =?us-ascii?Q?EmKWhgeactqNd0tM4HTqeoTAXmgBcIEZMIubpRjTizt7sz+8aBFsM6SOv1+F?= =?us-ascii?Q?rzGAs7KoBFZUFSaT5olyhXWBOUwH/7v7F4nnE5OwgAOBde7GRsuqw2wy6WxV?= =?us-ascii?Q?cGPWs4P/36LQSrvybyupie+sUwv16b1+Kf6HiztOaKILVdSrEHSoTNKn7lb7?= =?us-ascii?Q?VV4bKu4jGS/kOQ42TXulzj3idMrbwzxfQ9IpuT6wLv1u0d7Fb7FPctr7qcyM?= =?us-ascii?Q?yHofolOXUJRxCbMOBnv4MDr9e3GF+dDMLIKJJqryDLhJnay1jUbzN5WKQo4P?= =?us-ascii?Q?T030NGhUOlZBK+5yD57/oGnocdblnlXKWOH/wwjUrBlF0muocCwBK5yIhvUL?= =?us-ascii?Q?VZg5rAbwSFw8XAF8/0CR9Y0weswz7s5V1QHwWTxkFwsKI7w+GSGeJx85S+v8?= =?us-ascii?Q?O9jgoXl3lAA0+KC4F3fhJkkkF/aIvs/EqVHX0wa5kNfzO5NsNQiDKErXtg7s?= =?us-ascii?Q?08WhskN5R/52CBI7tRLilDBdO0ituPDC6glbZJjUcIODmGmwml87AGMj6jbO?= =?us-ascii?Q?R66XyY+VbWbT6NfDdp11bqFcYlflRRQ6mdrqJzuydNjGMVkbysz5nhJYfaZJ?= =?us-ascii?Q?1uz5MfhA+IiDg3QtqwgCgpeW+aZFrqSBVN8nUQ0MbVLApfXX9sjslZfMSJYW?= =?us-ascii?Q?9ByHfYBb4u3eWiTjrHa2vWhEh4lcL/euVy+B81hUGiqXtFWqi2YmBAof4jG9?= =?us-ascii?Q?glZ1LWOqWnB94exPZKgdKdRuM4rEHaw24I+L8qTwCduowkKckYdZzyDm1TxC?= =?us-ascii?Q?l5tpwX6y83bqBf/bqBxHon1iSSPbeYqPmNW8UQGtpjZw1WXrAXFDBawOypM+?= =?us-ascii?Q?dOZjOrIg7x+aAJGP5A1qDNvfIwFGWdq/53lZ7twBxXyJLpe+hcAI0UkiQMrK?= =?us-ascii?Q?5wBzDqpQXTjUoDrkJvitLfE8/iRl1DjHrhPGqDifWg7I8xod7yQw6o8ErPSd?= =?us-ascii?Q?aA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d5d3f58d-4c2a-446f-ed89-08da70b7939a X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 16:38:18.6732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IvYU/kbfk6RFyZmAj6a1+5osZ/cIKUPjLFFnnuU9hk8kRYcu4uMegjYpdfjqoKvvZrjjI7gc3OjS85GrYrnL2ohlCatE3oFtM1twdfR3ILc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4474 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 28, 2022 at 05:26:22PM +0200, David Marchand wrote: > RTE_FUNC_PTR_OR_* macros have nothing to do with the rte_device object > and associated API. > Move them to rte_common.h and include it where needed. > > Signed-off-by: David Marchand > --- Personally, I really don't like these macros at all. I think having the check explicitly in the code would be far more readable, and would only be one line of code longer than the macro call. Is there some private header file we could move these to instead of rte_common.h so we can drop their use in future if we decide to?