From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CD8A9A00C5;
	Thu, 28 Jul 2022 18:47:17 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B3D6C40151;
	Thu, 28 Jul 2022 18:47:17 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by mails.dpdk.org (Postfix) with ESMTP id 21C7A4014F
 for <dev@dpdk.org>; Thu, 28 Jul 2022 18:47:15 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1659026836; x=1690562836;
 h=date:from:to:cc:subject:message-id:references:
 in-reply-to:mime-version;
 bh=08OEptDZLW1qltGBQbvmdNdxqZBB71R7PY2Y2z7HzGE=;
 b=jRKRT2koH3pKBsv6m7WovcoFMATtG3fuS2L1if50uN3vWhheA3Vp6I3m
 JMKWC8FBDWWZV7wlSh2+fRqUT+al0Kxepm8aF/NubIGetmP3+9JlATocV
 B0MQ3gFp/tB1YP0NMWlXJMKqWa3xJhNYXLtuF0wnnktozHHXr4xVzGdaR
 St3ZUT5d7KpGN8j24v44fRZDnK3ADrXLn+O69RbQJvAeGWhbMquLYA4rM
 yHUnX3F+6g0+jjulxdgtWQ8T3ZUWYFOt8KgUPi9j9QyVu0d1q3D/wdoIt
 CpyN2QfaPw5EI+Gc8j5tO+0MlBTwj9gaie2Eq/QRoZAp78JDR3CSQg5tw w==;
X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="374864233"
X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="374864233"
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 28 Jul 2022 09:47:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.93,198,1654585200"; d="scan'208";a="604646289"
Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15])
 by fmsmga007.fm.intel.com with ESMTP; 28 Jul 2022 09:47:10 -0700
Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by
 ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.28; Thu, 28 Jul 2022 09:47:09 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
 orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.28 via Frontend Transport; Thu, 28 Jul 2022 09:47:09 -0700
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105)
 by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2375.28; Thu, 28 Jul 2022 09:47:08 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NwhOBMQtuWzzQdSXPqGTPeKlDd6nbIQRrvcHQKQCEJzqDlZGpM2uKQF5dgm0iDof9VK154qzjW9emv2CVC98ghsjK4+sGC0eAESLkTbvp7sHp+Q2JNVU675cmP4rj3AIu/q8LQdW6ojhuYj53tEuZdzlgm7okoAAoLOhgVE/UeD7EtlDhNlNbp31CsbCQCOKNWrO0gOkQYCresBoCyLEYy5tYJeoqrJM6ydtMEq1y18wAiaFPCQCxRkiJ91bu1C6mt0BzRJ17tbPSw49e2mKKKRjeUQYfmBq7NNVPUJEPgVawwo/pGybFGZgK4oV5ryLti6dh1cugmCso6G1HeYdYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PoqrzM54cEan7DqgAsHLd4rBgAODqJKYtheTqQ4kTkc=;
 b=NsQTxyiz6lrUk8HrYSVKMo4BcpcIrhUbx0AMEnpJg1hDlXxoc8HX6ALV9JMqjXvfionvIl29jg87AvmfrL8HVESsA4g6sv4ykYdWjwTjKhkRw4UUEG3iMSTUmk6ruElqZFMnQRYVDUU5djjsewEsnMMj8uQ9YbdWsog/D70qlsJ3p8UwpYLR8ZxCRpkGfvBXh86AShBZ0bs3TRx9Cz9J1CoSnAZE4R7oFv7gbfRmVD4PmbJzyQ3Qv7iQskYOIe9nzdKPrX1lxh3hPQIp/L8kJnLd5xNTXpOcjnM8FBgNDZHGo111KWYeFuyDem1KAcOEUEnm1smRojUSWoxaa4tJkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21)
 by MW3PR11MB4762.namprd11.prod.outlook.com (2603:10b6:303:5d::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul
 2022 16:47:06 +0000
Received: from MWHPR11MB1629.namprd11.prod.outlook.com
 ([fe80::8e4:e1e9:a851:4b0d]) by MWHPR11MB1629.namprd11.prod.outlook.com
 ([fe80::8e4:e1e9:a851:4b0d%5]) with mapi id 15.20.5458.024; Thu, 28 Jul 2022
 16:47:06 +0000
Date: Thu, 28 Jul 2022 17:46:48 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
CC: <dev@dpdk.org>, Nicolas Chautru <nicolas.chautru@intel.com>, Ray Kinsella
 <mdr@ashroe.eu>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K
 <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao
 <skoteshwar@marvell.com>, Matan Azrad <matan@nvidia.com>, "Viacheslav
 Ovsiienko" <viacheslavo@nvidia.com>, Fan Zhang <roy.fan.zhang@intel.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ashish Gupta
 <ashish.gupta@marvell.com>, Chandubabu Namburu <chandu@amd.com>, "Ankur
 Dwivedi" <adwivedi@marvell.com>, Anoob Joseph <anoobj@marvell.com>, "Tejasree
 Kondoj" <ktejasree@marvell.com>, Nagadheeraj Rottela
 <rnagadheeraj@marvell.com>, Srikanth Jampala <jsrikanth@marvell.com>, "Jay
 Zhou" <jianjay.zhou@huawei.com>, Radha Mohan Chintakuntla
 <radhac@marvell.com>, Veerasenareddy Burru <vburru@marvell.com>, "Chengwen
 Feng" <fengchengwen@huawei.com>, Kevin Laatz <kevin.laatz@intel.com>, "Conor
 Walsh" <conor.walsh@intel.com>, Timothy McDaniel
 <timothy.mcdaniel@intel.com>, Jerin Jacob <jerinj@marvell.com>, Pavan
 Nikhilesh <pbhagavatula@marvell.com>, Elena Agostini <eagostini@nvidia.com>,
 Ashwin Sekhar T K <asekhar@marvell.com>, Harman Kalra <hkalra@marvell.com>,
 Shepard Siegel <shepard.siegel@atomicrules.com>, Ed Czeck
 <ed.czeck@atomicrules.com>, "John Miller" <john.miller@atomicrules.com>,
 Steven Webster <steven.webster@windriver.com>, Matt Peters
 <matt.peters@windriver.com>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh
 <shshaikh@marvell.com>, "Ajit Khaparde" <ajit.khaparde@broadcom.com>, Somnath
 Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>, "Min Hu
 (Connor)" <humin29@huawei.com>, Rahul Lakkireddy
 <rahul.lakkireddy@chelsio.com>, Simei Su <simei.su@intel.com>, Wenjun Wu
 <wenjun1.wu@intel.com>, Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk
 <mk@semihalf.com>, Shai Brandes <shaibran@amazon.com>, Evgeny Schemeilin
 <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>, John Daley
 <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>, Ziyang Xuan
 <xuanziyang2@huawei.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, Dongdong Liu
 <liudongdong3@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, "Yuying
 Zhang" <Yuying.Zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 "Junfeng Guo" <junfeng.guo@intel.com>, Andrew Boyer <aboyer@pensando.io>,
 Rosen Xu <rosen.xu@intel.com>, Qiming Yang <qiming.yang@intel.com>, Stephen
 Hemminger <sthemmin@microsoft.com>, Long Li <longli@microsoft.com>, Jiawen Wu
 <jiawenwu@trustnetic.com>, Devendra Singh Rawat <dsinghrawat@marvell.com>,
 Maciej Czekaj <mczekaj@marvell.com>, Jian Wang <jianwang@trustnetic.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia
 <chenbo.xia@intel.com>, Jochen Behrens <jbehrens@vmware.com>, Jakub Palider
 <jpalider@marvell.com>, Tomasz Duszynski <tduszynski@marvell.com>, "Tianfei
 zhang" <tianfei.zhang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Ori
 Kam <orika@nvidia.com>, Xiao Wang <xiao.w.wang@intel.com>, Vijay Kumar
 Srivastava <vsrivast@xilinx.com>, Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@xilinx.com>
Subject: Re: [RFC v3 16/26] bus/pci: make driver-only headers private
Message-ID: <YuK9eAVGDbI4pH4W@bricha3-MOBL.ger.corp.intel.com>
References: <20220628144643.1213026-1-david.marchand@redhat.com>
 <20220728152640.547725-1-david.marchand@redhat.com>
 <20220728152640.547725-17-david.marchand@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220728152640.547725-17-david.marchand@redhat.com>
X-ClientProxiedBy: LO4P123CA0408.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:189::17) To MWHPR11MB1629.namprd11.prod.outlook.com
 (2603:10b6:301:d::21)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a797d7fe-8be5-43b5-6a49-08da70b8cdd1
X-MS-TrafficTypeDiagnostic: MW3PR11MB4762:EE_
X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 2RCqAJHXb9GpgD9NIKap3Unm5O9s8jnNR43jQH9ZbGkYByF6NpY6hp5jr8DuA4goXjpsmxXCIxzGtI23yalLByBnOEzSn+sJJYI+kP+2GqKSqUKaPGtbqmThZFZfmWo6MPmZUlNALmmeGPQ+Ue1xCGB9gtA8zU3UdBM5TOFMzLtTad6Z/4e8+xJpripb7hMG+CmYuw9ryc8f+Zvxxs/AReDxMXE1Og2n0izxDCj0TDzMbdsYdCvxRfc4LgMly5wzjz0CbU5oJu8ccg6nZULVUwVq1EwnhDq8PBD4haWf8PE+6oqFRMm7OpJbg3Cv2KWFzdnDvE0ec90EPIg+zlksxb28WvgzgJh5lE99Jl5uKh8V4wfdu04vnKPWiWfNFAsQ5DrK3ZZc4qX3KliQE+FX1vKZCE13jvgSz6YxNHl5kI/C5c+N2rWZBWH5v7VPgmMv/E+py1uXQN3MOOEzppnb/2GEGWHA90jRzx0m6XyD31MFo5sNnxWKyROiN7pjy+HOitvC13w3sGUwG4CRFNgzHx9De8LafYuNtdJ6kyfB9o3W9secS30BJ8DsTbm5MpWQYrf3EWz005HTkQrtei3o4AY6HKrTFw28nZwh2rna+rlXNFtMHG3Du5sVo/6m06sdCULj9dzodIuT5gbtZJoaCNGFm+mMqnW2Cj1F1ItmQQGUXx+xtRV1KGx1xTLgvSwxG2yv9+M3PWF8GgceU6LrqdgkL5rfjwhyh1gn//c4IupZt544hqPGa91eF7tECoOC
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230016)(346002)(136003)(376002)(366004)(39860400002)(396003)(7366002)(38100700002)(4326008)(7416002)(8936002)(6512007)(7406005)(8676002)(66476007)(4744005)(6506007)(66946007)(5660300002)(6486002)(478600001)(66556008)(82960400001)(83380400001)(26005)(186003)(54906003)(41300700001)(2906002)(6916009)(316002)(6666004)(44832011)(86362001);
 DIR:OUT; SFP:1102; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W6/j+SJFcyxtJClMo33c3UghJifZUwEhPot5qVGdMYrkuCT0OMbMBUHNx17u?=
 =?us-ascii?Q?tMBqwe2Q6n8q7yQPr18sGP8OUFHYpkO5Bdr3N1RZnHPvASmI37uG8Kc6Mi2o?=
 =?us-ascii?Q?q5NmgfQDXHgHopZ9i2cgrEQ8PLECxy0RgWoOaP/usJbNwHlznLP4O00iu0ig?=
 =?us-ascii?Q?sv8xyVn/EthcGWIEqrN0C+nmwh0CP/JBBj8NeJgnepXdOrzqmvGG8OQFba00?=
 =?us-ascii?Q?ITWOdskApxYM4+MUcM1cdwnWZR3j4RGvGLhBRJjh3DGMHYb6hYRF1A1txMzj?=
 =?us-ascii?Q?B8XKOUf4C/aLmPsHdL7fucKdQPdU3E+qbtkp30sOrbBcWeICA8t5t8eTnaXC?=
 =?us-ascii?Q?qBRetfWPP5doqGsHKebODJzaLwYhAa5NP8KX5F8n1L+YybgpxWF05Mvv9KCA?=
 =?us-ascii?Q?h006J2xaSjHG/q2NxTti25TC3ZwuChbH4j3WXn5P+ICPxsk4XLypU8yObirO?=
 =?us-ascii?Q?LxZItOXI1Iksbaputb/WdcOufz5FNpD8WAvv8s/U/I01gTWdFbBT/ChJ/rFW?=
 =?us-ascii?Q?DrbL3lD/lcaE4n5vhGnJIRj9G6biWXjoa+3AC8wNO7dp2SjMh7fpAAkP5fJu?=
 =?us-ascii?Q?9K6Pbk6K1XnGEStkUn3twENt1LvLAlTraoOW5JrKI2zm56ru73lubCtUUXdw?=
 =?us-ascii?Q?eqOZjZsNs1woxX4RMH29HUhTCbIDDCXkYht29PcPpzwbo8HasdZrZv9RdGoV?=
 =?us-ascii?Q?nu8ZLcL56pDJSDJJrvtVOGq+Wmtu4U6GFJqbwRxwk5Tg1mX2P0r7+NN/YJdC?=
 =?us-ascii?Q?0syCEbGDFpejTAeAO1unZzDEwfiPeh/x70Fv/ZUdeeODRhUByd3Gp0NlqO2i?=
 =?us-ascii?Q?j6JoH/3W8/uvzJDuAPaAChfZwrrN2IaPC+cXLC2s+PwVs/c+v8wbjGB7Pn36?=
 =?us-ascii?Q?RtZ8qMzF2NvqVI3Hy49/MLNGbmyY/fTyLXfXt7J6zOiCB3LqV6knqr0HZbor?=
 =?us-ascii?Q?7MyF/9glhh7jhA5aOFPaHff5CibwfRnvqCn0YIOKf8LOufC0DhYA2QXepVgr?=
 =?us-ascii?Q?DAfszoYB/DeMsJtuMCwCoFNkEkcYSUysyOFlzRzAqRSV27+sgnyMIpfs2H4s?=
 =?us-ascii?Q?TulAe0OwrP2kkig/6iFMXgwyiTzDINLMvFF7swKf+PUAzFmRQcdXIQBSOLM8?=
 =?us-ascii?Q?NF0Xd22nyPZmLB+AVmKe8ajYbvf3rgS6r2l4Tc9JJ7ZSeWgC7H0Zu1TWt7j5?=
 =?us-ascii?Q?rVi+BTriBxMXJVoLpd6SsQktET9f/WLOxrH8T8ozpz2e0rmoKRjgbBwS+NBW?=
 =?us-ascii?Q?ZGxxAUDX/W711TOx5KKiOKKp4YDuli+I1O0UF51SHY9f/7cQmX2JPbT2EPHk?=
 =?us-ascii?Q?OpYy4cQD4b/FyjoVQGp0Kcw2UjTmbGeTWxs2/C8duhyCJP15hpsjfrSMwWbl?=
 =?us-ascii?Q?/EMHnS1eI8tCgsuMjZcpFhC8j6iv+H7jdLU7wYQ2MMcLJjBLnCXQxdT6Ek9G?=
 =?us-ascii?Q?1q0u+KWcMM8rzFjS47dV6k21FJGfRxwgjHv5Mw3MwLnBcYGJ7/btNSXTQ25f?=
 =?us-ascii?Q?aaZtt8uYPBlSaPHNJUDmlhcfDMrfn3bjOhWSTXO5TCrmvFhC1+x8Z2IFJIvq?=
 =?us-ascii?Q?kyyvMgU4H/V5RJl8T3QAnqFw/sjoPU/1oWW4Gk/1CTzOIU0r64h+W5hHRIe/?=
 =?us-ascii?Q?UQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a797d7fe-8be5-43b5-6a49-08da70b8cdd1
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 16:47:05.8661 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: io6W9V23wfcRBkUcbXq0xnRePslWyKtJS+lzKcKUz+GzYtYhH55byBxRz8xL86LAGl2MOK02oV+d3/mOVvTH2eyGVbqd+HyAdkUMvggLaS0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4762
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Jul 28, 2022 at 05:26:30PM +0200, David Marchand wrote:
> The pci bus interface is for drivers only.
> Mark as internal and move the header in the driver headers list.
> 
> While at it, cleanup the code:
> - fix indentation,
> - remove unneeded reference to bus specific singleton object,
> - remove unneeded list head structure type,
> - reorder the definitions and macro manipulating the bus singleton object,
> - remove inclusion of rte_bus.h and fix the code that relied on implicit
>   inclusion,
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since RFC v2:                                                           
> - squashed cleanup for this bus code from other patches,
> - updated release notes,
>
It's a bit harder to review squashed IMHO, but the changes probably do
belong together.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>