From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7128A04FD; Fri, 29 Jul 2022 11:59:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 529C64069C; Fri, 29 Jul 2022 11:59:09 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D7E2140151 for ; Fri, 29 Jul 2022 11:59:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659088748; x=1690624748; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=mu7H7LMZbx+zOd23BBLJD4iuO8nEsE+oDEojuKwQ5bU=; b=DNyzgYu7iROE/zHUhqVEIgaMjlZAf4X2/G+MQr76hDwkAddH1snM7VBM biQk+v/bKZq0TxXKH/gM8GPym4flT94Jv2ZF4P/FM0v4vu7fULEPYlczj Faa2TOqfkSlxNphVWegNL773Ghye3X6DYVFEQ9gaiX/sqfIluFvULNzvD SQzyKY+fxEhUqCr/w99O8HWox/Ssr2Gz8xCjE+6WvMUrloibCNF381sKZ eATUclfw5FkswyaBElXHPS51cOMsnk3eQ/EwjcJ2976KevF4lvgMq3CHY dCSzYo3hxMW6AEmTJP6faTP2xMvdNVmTVk1l+yb40YoaggnLS8wi1OoHC Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="268499295" X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="268499295" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2022 02:59:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="551683427" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 29 Jul 2022 02:59:01 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 29 Jul 2022 02:59:01 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 29 Jul 2022 02:59:00 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 29 Jul 2022 02:59:00 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 29 Jul 2022 02:59:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KsnTUkuwei0M8wTeCJujpsoQAOQQaDI0qozgkIsjrWeOoMPfBVbxgAWnoryVpQKCtNTOSjrHKJ8lUp7IYneC+C+NMs7T1qVjfutVlecQuh2qdOhdZnG+MB2f2E4JDyRnNViZWNz4WQHrkZizHiKcSd9rfU7cGcC75NG/L8bQoXMWJiiSlAfo48IM7vWX8GaGkcM9l/SGOi1Tul7TYNUUfa+U0fi+j0A0s292XiAHXWZcs4XowEQTykKxOlw+b1i+5/9HcERcpca23yxj4TSUgMWCx2sq7i+IjT+ykyIz6OUTXAyNxYErGkENjAPVm9iPBJHw4cb2VBcibEyNOiJAZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s03O91bpc5SvIJqSrSr2dGD8kfdLKqaBGAbFe7ocTSA=; b=DBlQIcOwV0FoI8+CD9iRY3x7wvp8905lnbcDeTike3fLHT9E2FrJC5dVAGRB3AfI9gE/JtEqllTBQAN6U0Cnjn7e4NtFbW7HzHK73bszTJZArqG8PaaZPusxForv6W8vy7E1cyI2w7a6eTXsgUKRuZ9q18zjLIWymqyILi1QB2d+wBL2WN9y6THOFuysnprhTh98i4v36pQSQ1pIrLVGx0gHZULr/aPQloZlFL+wDZ2KBCvFvppgO71yJpDgen6dG23JEMeMSYsu58wRanzbQ6pMvEWaIe8IXJe1o1k79W+ATtL+MjpMtdjVDT2SlZ8rzEVMsZrOekShuPPogb62cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by CY4PR11MB1381.namprd11.prod.outlook.com (2603:10b6:903:2f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.23; Fri, 29 Jul 2022 09:58:58 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d%5]) with mapi id 15.20.5458.024; Fri, 29 Jul 2022 09:58:58 +0000 Date: Fri, 29 Jul 2022 10:58:50 +0100 From: Bruce Richardson To: David Marchand CC: dev , Fan Zhang , Ashish Gupta , Qiming Yang , Wenjun Wu , Shijith Thotton , Srisivasubramanian Srinivasan , Chengwen Feng , Kevin Laatz , "Thomas Monjalon" , Ferruh Yigit , Andrew Rybchenko , Olivier Matz , Ori Kam , Akhil Goyal , Maxime Coquelin , "Chenbo Xia" Subject: Re: [RFC v3 08/26] dev: move unrelated macros from header Message-ID: References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220728152640.547725-1-david.marchand@redhat.com> <20220728152640.547725-9-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P123CA0255.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::8) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73e1aabc-f4fd-45fe-44a8-08da7148f48f X-MS-TrafficTypeDiagnostic: CY4PR11MB1381:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4qbS4mXRyaK4iyoXhIXnH5S2zQgydsu4xn2H9+NnI/PO6m9hO6fo+PNfXcDDMMCiw6TloZQE01ykSdpGR02Idmr9/KDijIovJhOimiE4hgyYkl46ipGMAOT0hC9bA5L2RU51zNLWcbwIXWtlqEAXT4oF0eSQvneeJE1Sm9tsvheIxFdZJfh0WIBsfWk6IBlXm4rpu3EJYnvWH7lk2smx5lVzqtCwm9aNARGzruQmfrA52Gb1G+tokXqRgmliSSExv5Hvc3adAeVZrSzkf/FCmSQt28lNLsrsmrZ5ECUjcpaZNDlIq4SH9316a5F9Y9uVDPC4DT3lP7EpyZO+U/8F29+aImrLCTf9vQ8VInlcwLJs2R3Ez9bdVJq35vULaQqIXDiiYq5Ayl4k40+bYweQPxzufPCcEvCQzPfuqfShZHwTa45Y0U9HcSmWS+tE4YN0hGzHG4LDfQAVsjG47fVs+7g9oyPPNSVMrKhq2YwzRe5BA7/Y7YL70qv6nsNnpMDipnxXR1RayFESAOyTW0ltmzXi0EshF1fCXFdlhL8cSDTF8ecV9As/uc/FLj4A3vLLeUvu7WLNy17sOtFF/N/D/5YAOOR03KyRqaT4vgVQq2H4RuFv21YW3O2HH589ta8OqMgSgqs0+p6EcKwkmLT13oL9TTbJFNvbNKGaXAoEPyYkw4MUH4xttU9s0bif6qAaVp8WvtFARHc6ZjM7CclI3oZId7wRCg8CM2XKcrO1q5bI3iFMcXC3FLSr6G5rYpNMzI8RzQA+rX8wjH0eKfWikuEd0gmWO1wuUOJjqVByZ8s= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(376002)(136003)(39860400002)(396003)(346002)(6666004)(86362001)(5660300002)(6506007)(41300700001)(2906002)(6486002)(44832011)(107886003)(478600001)(6512007)(7416002)(8676002)(26005)(66556008)(4326008)(38100700002)(8936002)(82960400001)(53546011)(66946007)(6916009)(66476007)(316002)(54906003)(186003)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w9nXjRMKFTySDOgHlx37iS91v3kuisO8QJHAlhzmrXv29L/8zK3jlvdlcdm+?= =?us-ascii?Q?ORV9psZwA/U9Ff1bDMU0EP4z/mtLArGhG2N1zGLzKGol64bUbPedR6MGVcaB?= =?us-ascii?Q?de+8ZV9ijOPEI5Cj7CZiordkJXUEvdPsnDn9De2uvmXUhkidLWqz7is2xs19?= =?us-ascii?Q?eZQ0F2FVO1XxWq2G3gDqYWO7l6/VgmYACFclX53mQCcfuAyNULtfXlGp9pak?= =?us-ascii?Q?UU6XF5AIKPlWc2uS/t1TcvK1+NHA4S/wCzWWKwi7r+LfyS9+gCoIvIBvGk42?= =?us-ascii?Q?pF8dXyBEIszBM8Aru0017fV1nt5wd+J+Xu+ji0Ljo/4w4sg0pW3W8bE1UlZk?= =?us-ascii?Q?IZMeATeNNYIlkRUZrvrWGkmp5NPvNFXcjVzPmfXIYChGqrLo/CpKfceIklom?= =?us-ascii?Q?QuhIYvBaq92ST4SD+p3rOHJpCxlLryFaz2fISTzGPu/IvqLEdQTYHd5DriJK?= =?us-ascii?Q?JmUUbPA7cKqcLp1H8U0HmU8qj7CLCvgIcI4EU9LCC9mREsSA5+alM5jLTtX+?= =?us-ascii?Q?NskVxv5/mVJeRYs6y3M7utfVrFqN17OtAGVuxML9BZrbK0u6G0OJUMY0PoCE?= =?us-ascii?Q?QKhnmSrp0H/oCz4yaMbri8y6/u1+xhmvPv6CeYffo158tQZKsxh68ltWHl/O?= =?us-ascii?Q?a79jiSvwSq7oDPEvXt9VDEf0vUtHhtXto0+GMj9aiF3rX+U77d15a+2GWT+n?= =?us-ascii?Q?M5Qc0ykyWngtqMQmrGqkiJBu+jHF8fTJumDQCC6BVFhM29JS1plnxxRsodz0?= =?us-ascii?Q?6wH0y1czIF6DEeECaUIFNlj1A1n6B0qYX2gWY6eel2obLdQs8Lmwq9OaXH06?= =?us-ascii?Q?W+Q2Oh/e26Expr/RwmndBZsa70JrNwQNITF56hnMJPvEo/A9M4lRoPPQjmf6?= =?us-ascii?Q?S5/sLNUW7ZyF5+Z9vJ27uTUdvnavOqPapbFgLUC2KB9IOVxTorH15l5K2DJc?= =?us-ascii?Q?dfMshlqy232BDDt+dCys376dpEl4IgvGqpPW2swmTlL+/Z/XP8JHMnf7vKHa?= =?us-ascii?Q?WsTAVeHBYjYNQXMpBiTGi6sk28md0/8qxfFr1HZZnUgiSDBEV2oyq2/EmphN?= =?us-ascii?Q?vVZ1fLYMsKl4IziTRp55MhWcEBoyvskmmMOHw8u/VnVy9uDTMVXtmPAGrX6m?= =?us-ascii?Q?IXRsBBEXgAsp/WTzKZxsvUTwhXI6eMDo4owAYmplJtu+FZwqcmLbdcwMjXd9?= =?us-ascii?Q?6FTlNzIN6dCyB1UOiSdZ/q9UuiQTQSZQbCHYgZGRAxRWo4xhRQKvL8Br6mr6?= =?us-ascii?Q?RlDiOWO6vOuguIeStrxdJIKn6F/i2qySUCL7dTh90NmduyYu6FritMY2dz9S?= =?us-ascii?Q?+a1rqlpwM7oM1B4f0S6mhDW1XLRUP8T9R1zoQd9PSiE3VPnH6XHRtlIdJZhG?= =?us-ascii?Q?ryqPU3ugINjrKvy3qqQFQmHYysq1/3MKj7cOwJx/fkgnXpgwX5EXV4TFkzXy?= =?us-ascii?Q?TP8yCa8PCqtgK79gVPfPPGzbhaHpkdV5EXRLCxTNPYuuK4bdqanUuj3ceex3?= =?us-ascii?Q?T9MmgdqiDgPLNgFUoleIguQdal0rg94hA7mfnaO2YH2+qvsmNo1qDwr86CGb?= =?us-ascii?Q?wsBniRZJMw22q3QEvw+1yOF3uA1xz3G3myk65dky232fKHQjOEfNQLeYvaA1?= =?us-ascii?Q?Cw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 73e1aabc-f4fd-45fe-44a8-08da7148f48f X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 09:58:58.4085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nWrDL92pu0x8qkANhdUBQjQSRUT0P4xHiBU2xG0xHpNPJTXYoDdL6xaifWVfvqB/gSMn9k9xSZFmtmvzrMVFEJsE+nvAjwzREt/8vBB12iw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1381 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 28, 2022 at 09:32:38PM +0200, David Marchand wrote: > On Thu, Jul 28, 2022 at 6:38 PM Bruce Richardson > wrote: > > > > On Thu, Jul 28, 2022 at 05:26:22PM +0200, David Marchand wrote: > > > RTE_FUNC_PTR_OR_* macros have nothing to do with the rte_device object > > > and associated API. > > > Move them to rte_common.h and include it where needed. > > > > > > Signed-off-by: David Marchand > > > --- > > > > Personally, I really don't like these macros at all. I think having the > > check explicitly in the code would be far more readable, and would only be > > one line of code longer than the macro call. Is there some private header > > file we could move these to instead of rte_common.h so we can drop their > > use in future if we decide to? > > I don't like them either. > Not sure where to put them though... > > My "grep-all" shows no user in the projects consuming DPDK I track. > We could mark those macros deprecated, fix our code and drop them later. > +1 to that. Can they be marked as deprecated as part of the move perhaps (assuming we get agreement to kill them?)