From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DE95A00C4; Fri, 29 Jul 2022 15:28:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C2284069C; Fri, 29 Jul 2022 15:28:08 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id DB88F40151 for ; Fri, 29 Jul 2022 15:28:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659101287; x=1690637287; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=RIHMn2S+KuIh/0T1Xrs6HloBdReXzmMK7Gfldjhu4+M=; b=VIGlLiWQ5XwbnEBhWbf+cWIbUuEaYyR2hGkizvK2Nn+nl/o44Hc292mB 0nQdPsBEYVwclvaWlLQ4DHlBoh+AMeTpDEMYrzcxHq7cBQ7tMOgBMG5Xf EGCCdxZzfeO4WPFS7hMXy4yFlAbSN8MaoMiMxYgl3QzzuWM3ca9A8fx/w CL3+LF0YKCJYW7EwLp8z6o4Cd/BS5YKTvHV0Sazvr8o1qUiuC2z0w4Q4s JCa8HdwmMepJPI0f7dgG4BEsX1liRp1BczBqWObE2lAcVTXoMciGQ7cZ5 qNmXeVHSOvU3mA8iLiOzL+9o9ax+4CbMAUjUEgrMWxprZQ9Va0pkYqqr6 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10423"; a="289534366" X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="289534366" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2022 06:27:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="727743108" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 29 Jul 2022 06:27:44 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 29 Jul 2022 06:27:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 29 Jul 2022 06:27:43 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 29 Jul 2022 06:27:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/2qMFJYhXm8j+M1VNyAVykL+FSnjqPvC/L9SbBwPeo1rUWV1D/6lW/oBBe1UNT5wXdSpJJzLUTOchcQQogNtlKIuHEtMMBKaI0cK9BCQwTQM6RjBuSmPmSQi1h+6JkIbFuvzVZpZZyVYrROaJIEaN1mZ8CyEftUH/kD5O/ZrqyvO+PrA//U8wyVFAN3y4T5UCJNTYcl95M7DhoJWuRKeZfFXsXY9767ruK4Ks2+E5g1hSUOecCtAPeu/3rz/moVWOAR8lOnGy4+MZ0htzmMhT+aGyrLtt0F0gl79ZWhQOHyKoY1l5bw0W/oLkZ+GXNzepBfWRgrjBRKcqhUI1Jyfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4meSRdNw6YefMQOTHNyECskN2j3rq0K/3cgzuaHMxGM=; b=BenF3LoSCn1DHGF3sJ4TBxdx+mwtM5HUySgKb//uaOnlIE5Jui/aUxi5htR5pmiWM1GXWlbTLqAu2VybBNx6emiU6SvUcIOVoABB0mw8T/rzpY0IWG/JUxpYIFpn5vc2C7jWzO/wGRQFmoFxBKeQEt4NHx0A4HuWvHSJ+j6qAo44G8Ldu/ZH91qNd8ZmpFLPqj7+VzPe3Ii7GhUqi+wgCYCb5moxf8pHae5/nVWmi7EoPdMHuYaeu9WGR41t1oGqnG32o8gvyJyPTR3j2k1Gu214cr1elmCCRP3Q4kDD29556RtKZgdwYOZrL3unZW+JF7C/1AIKV7bub70OYYB7eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by PH7PR11MB5768.namprd11.prod.outlook.com (2603:10b6:510:131::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.23; Fri, 29 Jul 2022 13:27:41 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::8e4:e1e9:a851:4b0d%5]) with mapi id 15.20.5458.024; Fri, 29 Jul 2022 13:27:41 +0000 Date: Fri, 29 Jul 2022 14:27:34 +0100 From: Bruce Richardson To: David Marchand CC: dev , Chengwen Feng , Aaron Conole , Michael Santana , "Ciara Power" Subject: Re: [PATCH] app/test: invoke all telemetry commands Message-ID: References: <20220729095400.774303-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB6PR07CA0002.eurprd07.prod.outlook.com (2603:10a6:6:2d::12) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3e3aa42-4ceb-439b-ab3b-08da71661cb5 X-MS-TrafficTypeDiagnostic: PH7PR11MB5768:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vbfyUEbdrQHNPaTx5z+JNUP+M570eLJ8ThE1x762hD1rGoXYOyvX6G1Sbs6tYN9EjS+sOyYD1MnKHxHlHUHzkR9bK/coJ6Wl48oiF7oPRNYy6G5eUOAuXYTKK4S6SvLYSqa+BCbDD/+2TfchekYu1Y1KRZ+QK69FehX9BXnBdR9eaOADzP3f3juofRAOZAiYjAhI2qAHaFnRaKb2zLOfYxNJiv7labpA0wf1iSlrkv7tcJ3HS8xzfzgWC/yaKmbdfmb6n11g4gWmMbHzrQfZdh6Mt9IMMwHDagA6sIa29OrKmgeNlcFzKkxGwFeD8b2EXgMxg5So+/hJqrNQFSjkoU88/ghgoT6N/Lbw2eloC+VRKc7AE9nwWX1veut+PWKtw/p8xAy9Jup66FRmgLyy+eJvNuaYYRXvTaztjZFW3FbHomlMRxCbIoWWl3YJOE7jyhsjtjL2I8HXkDmDZOt3oVpz/zKLMvWCE0z90Vw/Osa9aYq+t5AzvzeH2FNoZEr2M2uTNcfyl1De44BBHlU4t/LUORJ0sbm63G1EK9NtCoO5LjmZey/bU4KqLk6eguSpfnJbUc06HiFHt9u7ob+Zakoill8r/e0m7tvlv43BCv6BYAYtBC7nYkVLICGPWomQgSzx6xwnGbjtONGh659gFADV/96OQVCK6GUgtz83pTaf9MPgMt7Jd8Tm8sw/2v3zMTOgNaWIV6FxuPzYXtdgcSH3EYPic5NGyl9cgSwFZJhGy01QTiPrMOezatHgii+S X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(39860400002)(136003)(376002)(396003)(346002)(6486002)(6916009)(316002)(41300700001)(54906003)(66476007)(44832011)(4326008)(53546011)(478600001)(2906002)(8676002)(5660300002)(38100700002)(6666004)(66556008)(66946007)(82960400001)(8936002)(107886003)(86362001)(6506007)(6512007)(186003)(83380400001)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NpEeQ67XKx/T8rWSqwQkM5lmiNZ/IAQiYFqTU/+nJFgAyIEmh/0VEw7uRB0+?= =?us-ascii?Q?Kse1z/V9OCLouGFBSz4PyGzDd0K1JWH3/391v4Bo3wsD06nnptC+uzRzVys0?= =?us-ascii?Q?J0MIhOIClC+WkPuiY+65n0uqG58S4OUzXQgx0kj8s316YSP7K2rMrTIDqZA4?= =?us-ascii?Q?zrANzAjKsQ9tPdaUzRxpyFmnbaozJ7u3+8LUSndDvdVyv5vPGk8pDtWplSUf?= =?us-ascii?Q?iqK4VxccjGsRUFOWW8PUnBVwtxP+O71C+GUcRI31knrGMq1NFmhPSgMv5BY6?= =?us-ascii?Q?l+iXqRFXxqEZNYEMzDoTP+D8Ip22Sj6msoDdpud0EHsC7h3GJlUmo1tRC4nG?= =?us-ascii?Q?fq+Aw+OgwYX1TRNlcgHm4RqSjqBb+ygZ4C4UveUUWq2CUWz7nFE6xo4rEuue?= =?us-ascii?Q?2Oybm6meB95U5NPdmFVVNfdWbGmVRy7ofUZhbUfVSf+vTfVbu1ZpHkA9O8Tc?= =?us-ascii?Q?lZiyo1nSarYq6umKzW4nyqvYIawfBr/pi3rMzvE7/MhrFvp9hL4DZOdTskCV?= =?us-ascii?Q?7aldgZTTfi1drwavsihXjgB1mWQmjcj73VwuUxfSE7FMizMHEntkUXAgNvr/?= =?us-ascii?Q?oHd4uTy4F+50S8zvs2dQR8FylCi+gvm9Bg9KHVcVNihCx9wxWFCFfwKu0pr8?= =?us-ascii?Q?XIJeEyfKLiZUggpQkPeGA2/LJ8CGjSlrxUkbVhri8w2qKBcaG1qp2PL6A4d4?= =?us-ascii?Q?q6cbc/rBuR/tdVA2PM5+czXYGY4Y/sxEN47F5zUHv1WN/L+QjzWPvLFSkIsb?= =?us-ascii?Q?CdiLP9LBLPnml6BDDCgPANdm+YiUhmxlHGPGdZgSGWOCUqhMaHlUnrgmArkF?= =?us-ascii?Q?h7F92bUitoo7LXmMG8m6yAygpE8IQlMJJeGNu91NADb7hyt06WuFWOU6eqo7?= =?us-ascii?Q?xm6O8/gqh1fvNpTlbV2ksMlWo1cRvQ+p7EkCiZjoj1pWIzwZ7+efE1IB5qZr?= =?us-ascii?Q?lZnJZUVfWp1jUgi4xsRf8HqMClYKMxVQmJ2V1W/mIOL19PBuzsVbxY7PCXPF?= =?us-ascii?Q?RDxpKKdyn0Uz7G8J7F2u2X6uV7AwwjdDk3qxknBR4eGvYux51LrjGLmzeRov?= =?us-ascii?Q?rD0kvnjpju2UCLBB9LP7eOBbqnzrCaOP0ajM1p98tarPEZ8eR3Ohsy0eJ7zs?= =?us-ascii?Q?B1vRJpDkmGlnM5vZRy1TrJvgBR3SuePzGiAknJDVuFqOMmuojKubcNNoa5Qo?= =?us-ascii?Q?GmN3jRs5P2sfJ0Y1QaZdMen5ePqXEaedKzLb5pwLmJ5u+Nlh8wAzRZqPc8X/?= =?us-ascii?Q?swstZKbceKP8lI+YNBHaN/zvYEjyJp/9ROMEqAfgcyzDZt9f1eqpmax97FM2?= =?us-ascii?Q?q9/65KLhNC5jGhz/2SRXBLi1HGFFMGpdZ0+gKEmz7YEvF+3y43jj+PnwLRB3?= =?us-ascii?Q?ugFAolo4MVAb3PRz55KyR7EaSdVzd18pseVD6YVVIyNOEjyz7mdQiFrIUaRn?= =?us-ascii?Q?9Xdqc1MJWgnW96PdLsQJXAXTa/nhuMBpi+q+T93jGGKEvjHqAW9b2TwySw0V?= =?us-ascii?Q?DcR/sY4Sf/QRv763IFmqkrDnOPjkt0BHonBc9D+8gCtxN3L7fjX19lA6yGyh?= =?us-ascii?Q?AOF8y6demkVIa4Pc56pm4gnKuiNWlQaytyxhhEb8v/xhf6T8EnzuEos/EyJ3?= =?us-ascii?Q?nA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e3e3aa42-4ceb-439b-ab3b-08da71661cb5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 13:27:41.0804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 87jtECs9K3L6plUBhuMnrCsh3pgtnCc+UHKsnOXX8CvJIT0w1gUGFb7n6Ai/g+pEazdGSltDfIro/ehHjlvgYvRt8Ib4S1NNgJGOniclM3U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5768 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 29, 2022 at 01:53:04PM +0200, David Marchand wrote: > On Fri, Jul 29, 2022 at 12:20 PM Bruce Richardson > wrote: > > > > On Fri, Jul 29, 2022 at 11:54:00AM +0200, David Marchand wrote: > > > Try and call all possible telemetry commands. > > > Each commands is tested with no argument, 0 (for command that accepts > > > a single integer like for a port identifier) and z (to catch commands > > > not properly validating input). > > > Fake cryptodev, dmadev, ethdev, eventdev and rawdev devices are created > > > using dummy drivers. > > > > > > Output of the commands is not checked, the point of this test is mainly > > > to catch simple issues and leaks (when coupled with ASan in the CI). > > > > > > Signed-off-by: David Marchand > > > Acked-by: Chengwen Feng > > > --- > > > .github/workflows/build.yml | 2 +- > > > app/test/meson.build | 35 ++++++++++++++++++++++++++++++++++- > > > app/test/test_telemetry.sh | 28 ++++++++++++++++++++++++++++ > > > 3 files changed, 63 insertions(+), 2 deletions(-) > > > create mode 100755 app/test/test_telemetry.sh > > > > > > diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml > > > index 6f04e7071c..bf17d2b278 100644 > > > --- a/.github/workflows/build.yml > > > +++ b/.github/workflows/build.yml > > > @@ -140,7 +140,7 @@ jobs: > > > run: sudo apt install -y crossbuild-essential-riscv64 > > > - name: Install test tools packages > > > if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RISCV64 != 'true' || env.RUN_TESTS == 'true' > > > - run: sudo apt install -y gdb > > > + run: sudo apt install -y gdb jq > > > - name: Install doc generation packages > > > if: env.BUILD_DOCS == 'true' > > > run: sudo apt install -y doxygen graphviz python3-sphinx > > > diff --git a/app/test/meson.build b/app/test/meson.build > > > index 431c5bd318..e60fc64a37 100644 > > > --- a/app/test/meson.build > > > +++ b/app/test/meson.build > > > @@ -473,12 +473,14 @@ message('hugepage availability: @0@'.format(has_hugepage)) > > > timeout_seconds = 600 > > > timeout_seconds_fast = 10 > > > > > > +test_no_huge_args = ['--no-huge', '-m', '2048'] > > > + > > > foreach arg : fast_tests > > > test_args = [] > > > run_test = true > > > if not has_hugepage > > > if arg[1] > > > - test_args += ['--no-huge', '-m', '2048'] > > > + test_args += test_no_huge_args > > > else > > > run_test = false > > > endif > > > @@ -520,6 +522,37 @@ foreach arg : fast_tests > > > endif > > > endforeach > > > > > > +if not is_windows and dpdk_conf.has('RTE_LIB_TELEMETRY') > > > + test_args = [dpdk_test] > > > + test_args += test_no_huge_args > > > + if get_option('default_library') == 'shared' > > > + foreach drv:dpdk_drivers > > > + test_args += ['-d', drv.full_path().split('.a')[0] + '.so'] > > > + endforeach > > > > Rather than looping for each driver and building a huge cmdline, we should > > just be able to pass in the path to the drivers directory, and have DPDK > > auto-load all .so files there. Passing in "meson.project_build_root() + > > '/drivers'" should probably work. If we want a more correct way to get the > > drivers build directory, we can call meson.current_build_dir() when > > processing the drivers and save off that value to be reused here. > > Or simply resolve this with a: > test_args += ['-d', fs.parent(dpdk_drivers[0].full_path())] > > But the problem is that the fs meson module comes with version 0.53 afaics. > Any elegant alternative idea? > I think the approach you have taken in the v2 is best.