From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60DEDA034C; Tue, 30 Aug 2022 10:42:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4727E40F18; Tue, 30 Aug 2022 10:42:05 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id B382040F17 for ; Tue, 30 Aug 2022 10:42:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661848923; x=1693384923; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=mgsWk3yEEF6RtDUqRclqd/NKLiizgr2gTBd+G1GDpoI=; b=M6xWMYBm7gIHMPNd97hgV+63M9MwBC5eWUmjFSCRz0ZdyiYbNsTEdhm+ 0iOBshlUQ59xa5zT5MaEd9gw37XmN8fKjKNoxtDEZq8/vVnuF2s8mA9Rk PMpXhM4m52q+kX1Pz/PE+6dIwIlVZmRnHXuMjBiDuk31CS1PiuEDhCCQG mE3bTrWtrvJKzOMQks0XqwCi7l9yAF5XksM36xgH0HX+BSEFSVnSIvXZQ CRiNnngjWk3gNMlNsCaHIlMIEQHQdJ9vxmFg8synZ9O1QPTznPiL751hj XX8dtHlx8mWM7vELyOE6OyNul4+nJlA1EZMDe6C4dOyHwKZT5gTrcknt+ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="292698807" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="292698807" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 01:41:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="679954156" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 30 Aug 2022 01:41:58 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 30 Aug 2022 01:41:57 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 30 Aug 2022 01:41:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 30 Aug 2022 01:41:57 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 30 Aug 2022 01:41:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iFHgJ86c8+OpW07h8XvxH9IzPZwI9CYmF4UWEbZ1DhnDy64chfL/hjG/oA1LXqFnalbhTzPiuqETPOeoiJ3AXg34KHoADa+WXKstHWlYJp7PAbr0/6KkEgMmEufSof8O1UomMd9WI5DELIzwLoHD8rPLqabfi7coh8IApsczFSWPl8Fap4FmxpgfMMcDB+5ToJKTUFMjyx/ncOCUb837yhMietPk0k9x6d2jRMvxZ49SiZWFOB0XTRh8UePxhEREw33buUF+Q0LBLCuJMNutNLRutufCRXrBiynMdXAkHTgAA8Rrt7EyrwoVPB1jiNMLcA2px3lZRxM37cxXr+corQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=avCsYY6tnBNhk7aQxR+vkWJztt05EQ3PoTwF2BJ9arM=; b=oByj8Cmnk0RCg4RQV0mu7WtfvdmQAnqG/1FoFK60RedSrRYzv6t9DSXTbpP5DLDvmO5V/47QS0f5yaByu4NWpKF4imAi0sO5dvvugxTmQNhAXz4mHQIzaakR+IaL6KlhTyZDZUmi4w0m4hTx6PamGIlQ5yUAP7pr6aQkj80rMXsc7NQvE+GU7vP7yXFjFE6fEclshGbZRRRL1dg5oSZ6gTm1t3Soi7WfJTI2rV17jC+fwe9Yga82z67Q04ob0E3u3U1ifE8zFqtiwDu4QAxdu1Fo340OIJMtCeDCGTW4wC25+R62+t8+pZr9I2qRX7VITTDW0JI5NcvO+aJEpn3Ufw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by SN6PR11MB3119.namprd11.prod.outlook.com (2603:10b6:805:cc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Tue, 30 Aug 2022 08:41:21 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 08:41:21 +0000 Date: Tue, 30 Aug 2022 09:41:15 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Subject: Re: [RFC PATCH 1/3] os: begin separating some OS compatibility from EAL Message-ID: References: <20220829151901.376754-1-bruce.richardson@intel.com> <20220829151901.376754-2-bruce.richardson@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D872D2@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D872D2@smartserver.smartshare.dk> X-ClientProxiedBy: DU2PR04CA0233.eurprd04.prod.outlook.com (2603:10a6:10:2b1::28) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dcbce3b9-1246-42a4-0b95-08da8a636a01 X-MS-TrafficTypeDiagnostic: SN6PR11MB3119:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: St3NwSXK3D4bNnQhhlO2HiMD21Rb6y1nT9x84a17HVdnrsLyD7a7dnwyutVZFFb1WsNTUbKnNx01R5GPqHG+vcORsQEwMS0MgGQBwmBKdKJ6lFBgKSwslStvehNyO05G8TedMB/AMUrzkBoVXAAQZA48ONXVgKNoMzHU8QfggC5T0uKV0WUlGMV6npj1f6Jackeq3UMcE/fgYSwWZE+kDSp/Lpc8UvimDZnf/wxuc6j7+o0Okpnv5xKG1lzbNjdMQTrUpHBJYPOT+TpKK7ph59hbHZv+LwSSvPpYk2+qsObk99b1c1sVJFddLw4n1+moOg1/dcF3dm49wtV/ewxxMLoRy3gXrlSTg5lU9K8Q/rXvwmey0aHup0WPb6LrTdf8yri56apb1A9A+U+87HgobA+5piJsc8AIYkYqXal8Xguzga+JIHNaB3qP8MfsyYimk7UI9yA5TcF3/0CmV3O0F8Hm9FiwlwNwG3jueG57uwkJxNsQfHJ1E9shX3glpiElz4/pGzw/3pdF2FqtouRaQR2xRYaVkb9Lyt8QqdeRZvD2nYOWUg3csODtmTJ/GMNk8f7AaQAm/Q6MAEeBM8V/Ks0fFvnAouTcKvHKduuzDnDctBvpVU1eUmhskZhEYoC74/h5gjZ0DyWHJGskEZc0Xt4ELNYEcqC89WpLirjJZ5lL5GDzLGp1xpntzHtwcn4yGabnLXQ8znA8Qm509KgNew== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(396003)(136003)(376002)(39860400002)(478600001)(8936002)(6512007)(41300700001)(86362001)(6486002)(6916009)(316002)(5660300002)(82960400001)(26005)(66476007)(8676002)(66946007)(4326008)(6666004)(6506007)(66556008)(186003)(2906002)(66574015)(38100700002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?xKqNhqkYEa42Koi5Q9mmvPLgNenqOAkEF8+KXozY1ZKhuT88o6xyg8NPqG?= =?iso-8859-1?Q?m/3p18QQhm+0t6aQNf8iYAGSn3bH26A+1nFIg2Om0uknpLSlppRhhNyETl?= =?iso-8859-1?Q?3Jc7abcCRqFo6KsAqJBEgApnmXSa88fGEhuwgcV5YV4E4Ved8cn0xtCCll?= =?iso-8859-1?Q?isZaq/VMoxx4noLnP17T2Wg9SmkBnxWvYbZvGuo/UtmPlN8KEZCK/VjMQJ?= =?iso-8859-1?Q?uTMua/8nep/hQe9X1uUPNYf4k+f4Z7sf63aFu5DShzWyrMld3bOJ1Tam7g?= =?iso-8859-1?Q?Pw0xfER4RkxdoHm/9Qp4/LK9b03wamGEC1esuD0E0iWicRm+MwuTdKFXJr?= =?iso-8859-1?Q?cc2S5XNQCLtYB3aEwIVHc/QJW9QxUSAQndwC2ABmqZkqGIZkVdl8LkPlLK?= =?iso-8859-1?Q?P1kSkTSJ+rOXCXbr1fVfgaiRhO/ZkQNYRy70r2FZN5GXIx+p7Sb7suSGlh?= =?iso-8859-1?Q?kyhbbAz1eJwcLGUZr8xHdKccc+iqtscbJ2cT5/9vfHPafss5iKeBXMDRs/?= =?iso-8859-1?Q?qudPYzaTNzDFIEgaTkFQ8yJTP0zEcvbe0UJowLiD2BfJppSNGokZgYTztf?= =?iso-8859-1?Q?aTc6ghr+Yhb6JdRN+yXeN0p1E/VdYih2lt8146+gT03anH3LFVI8AFZbyB?= =?iso-8859-1?Q?FGppfUbOoXph+xlMq+hIaGGljSE7e8n/8HyruM0gdnBLeZNUNZLpA4twOP?= =?iso-8859-1?Q?QKX+iGOcNssFlQFkRAaDxJkCSEbI7b628BUXlpLhtaG7wwLMEtAAHQL6kp?= =?iso-8859-1?Q?uKuy/cyrOIsjTbET4iqllgZparSp3qike1Blkux6I/PxhfgoV+Ikakdlhb?= =?iso-8859-1?Q?3V+/DzWxpoeeh++yHXbQ0JSNtSz/RomMhXmj8N2kTSLVPbSTs7QcoiD/+a?= =?iso-8859-1?Q?9rw04kefSfUOgxJlICK6uUeFKsZ+5TVvELMgbzfqygiH9vZg7IWi6ms6St?= =?iso-8859-1?Q?IELEQK3Ox2p+oR0Ootn7fI1DQNvy7gCoMCInEqXiOhncAhFxcozwAyKoOh?= =?iso-8859-1?Q?C5q8KbuAYgIOG4taMJ3sF/l9ujmD9HFpBAgD9AZFIhoyB0AQAPKybNX32H?= =?iso-8859-1?Q?g9ngZCYu10PQgiDDZ/ry1jQ0nyEb5NfvVHG8AZmTHIOePrSEfIvMoV9w1E?= =?iso-8859-1?Q?0JpS905hN7VER+CM69U+F/No4ad7nTLOwmlVns+fDmkjZFs5BCUKnBE7ZP?= =?iso-8859-1?Q?hrjxp7Zxi20ALAAZ6QZME4VwQwg7H/+D5azPzEU/fJR4J1cU5+REmr524+?= =?iso-8859-1?Q?oyszs5xAexjEtqk/+6VB4LkoA+qimVWNvwqgNl3UrT6uALQ1to0M/vZdjK?= =?iso-8859-1?Q?txU1xdrY9E0+5W2lZcX9UmwsjQX1oFDzoyWVng3r712gEyUqOAErU1+7cf?= =?iso-8859-1?Q?/hGRG1aTCiJLpYSGU2bvnPSQiGLD17sqclOeluG4CobiQtF78WI11K73kP?= =?iso-8859-1?Q?OZMirZXTOFFVI6pnCKTxSY/wyPgvwVgE2hmTr9edL4Us74aYLXZQqqXFv9?= =?iso-8859-1?Q?iZ1tN2GpuRfwGXOXLGWumZK1M1sLh49SP6TjVsCae9f8AYqUprGAPLmI9V?= =?iso-8859-1?Q?jlshGvwkKuK0BLAjGGToPhAxSVyZBURRTM3tcEZWG5L+cHo4FOL4xCM36z?= =?iso-8859-1?Q?GT0M7yV1CD9nCCtyAjVWIs4UiqRcCFb1hz/JdN5SLHV8H2s9g/EATsFw?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: dcbce3b9-1246-42a4-0b95-08da8a636a01 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 08:41:21.3695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /P0RyxYI9RdofLkvP2IwvUkiBe0szukN695qXC2JJRkZDsKJCKaAWCXJ6tVea2t43cMinarYWg7C/HTNxsWOEd0XDr09ycINOpNLH0rs3AU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3119 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 29, 2022 at 08:57:53PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Monday, 29 August 2022 17.19 > > To: dev@dpdk.org > > Cc: Bruce Richardson > > Subject: [RFC PATCH 1/3] os: begin separating some OS compatibility > > from EAL > > > > Some library functionality we may want ahead of EAL build depends upon > > some OS-specific functionality, so we create a new lib for that to be > > built separately. For now, just includes fnmatch function for windows. > > The description given in patch 0/3 mentions that this causes a circular dependency between the EAL and Log libraries. You should mention that here too. Until I re-read that, I didn't understand the need to move fnmatch() out of the EAL library - I was even sidetracking wildly, considering if it had to do with needing it on the host computer (for some host compiler checks). > Sorry about that! :-) > FYI, and not important: fnmatch() is a C library function (man 3), not a System call (man 2). But obviously still O/S specific, since it is not included with the C library for Windows. > Interesting, but as you say, it doesn't actually affect this patch. /Bruce