From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17939A034C; Wed, 31 Aug 2022 10:17:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9E7A40F17; Wed, 31 Aug 2022 10:17:39 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2136.outbound.protection.outlook.com [40.107.237.136]) by mails.dpdk.org (Postfix) with ESMTP id 709C840395; Wed, 31 Aug 2022 10:17:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pos0VcznbWjWWp0kZB+B8UTI7KlMglUdFPwPldwr+KTAoIAErvJTg6PmSNSwluEVuNupaqr9Waa+WH5XVdQ4L2G9qptvT221Z6u7IoZ90wD7rqM+zqGuU2iasaNOwcr04ZzmLhQgsxtesiP8MehEvbLOAW8wdmKKswg32IKNjlS+4X1xoBEbwmQqMlVobhlmR+dKsiN9vX+muobf9DZ3mfqVn1Ahmh7L53KwjtfL+BxohyxMM8TupuXnwaAid7NyKrFPiNpJBcLG6R8h6/BdhC/jKQ9DHo93NXcIttZTfOzNWP0XDS0o76jTtXnCKSP2pIeQ9sXupbwpXtP8D4ijtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I4aXfHYXWhfybB3lEV5h0NYLqvCSuHDx/me9UvZJawY=; b=hYKvT8pnVnM62XuCX0EkySpIHshYKWb9SctHmKvOQJzrn5bBp3ew2IR/o3HrW4IshRzwVCPHG8J+b8Qn0xs5/1Vaz76M4/iXdRn1yA27aYhE2gjPtInre9xgByh6+do/xq6teH+Do+Pggo0D3VUirInIoE3PPmxgckLnF+Msd/t6ty65oEhm9McXue4oR079frSjh93FYnWSg3EzhDQypZqk16jibl3ZrvzECAnaTtF3ntFQrZT5RcZSMEZvcFqiDryV200unpj2+lu3O8j15OlQbg5M6IADBUNW6+4E2gh9YqnPRiHLfiDMQTQ+cEndyRgsLsm0OLxHNdjb08MQUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I4aXfHYXWhfybB3lEV5h0NYLqvCSuHDx/me9UvZJawY=; b=Qgm0mBypUH1vuApIeCq1MrVWja3qhsurPRiqIKEZz2yCqma40OkR1RMpMBKamxqrsOwy2S77Jg8Oeiz2EVG9Mmsz15LGXWLPyC23AloX8T12VlMXY6MICF40gmCDwtTRyodCO4YRD/vhaTeZrYyKeZlXudbltF1OEogTMLMtVVU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) by MW4PR13MB5435.namprd13.prod.outlook.com (2603:10b6:303:182::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 31 Aug 2022 08:17:34 +0000 Received: from DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::2944:20ba:ee80:b9c7]) by DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::2944:20ba:ee80:b9c7%3]) with mapi id 15.20.5588.010; Wed, 31 Aug 2022 08:17:34 +0000 Date: Wed, 31 Aug 2022 10:17:28 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, Peng Zhang , stable@dpdk.org Subject: Re: [PATCH v1] net/nfp: compose firmware file name with new hwinfo Message-ID: References: <1659426903-11379-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1659426903-11379-1-git-send-email-chaoyong.he@corigine.com> X-ClientProxiedBy: GVX0EPF000013EE.SWEP280.PROD.OUTLOOK.COM (2603:10a6:144:1::1b) To DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52517acc-b3ba-4d36-9d0d-08da8b294210 X-MS-TrafficTypeDiagnostic: MW4PR13MB5435:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WNZT4JYJ5cl4eZ7693mEG22zNzr8KZL0GSpRaTz+x7seJiAvseT4SX/QF4Yp2ZzOAkbtrBNKOuz6V+NdVYF/qPLYagDMzbY9DYnBQ7qPI65YgJm/V8czJjJOSaRsvKKuF7X9MoGqAsvEp9r7wo0liD7TQ+vUSEiLKWjjGBubT4nU/xS+JF3raqjuGiX1ZLSwYgr3cuVoRI5xRZAsKGHFJLoyFO2Djjo1RyxgVB56wUU55uHb7op+DArDd9W2V6x42PmHqngbuo3YIujP6PNVL5OR5ZDu4S9wwS9XoxG1lb02S/4FCXtq7PxfNZfh4+PbfMd8GKxTu44OES8EmZEObeg6VrjjkUI0josOf0/WX8hb4J6FBq2uu4x/7WOaTHmdLNKhx5QVhDOX2ZtBGoVOwx+rY47cj9Q35TR4IiTZZNvP+V31AKX7FqX9uvn9I0cOEoSZr2LKH8hfTKjkj6i+cTmUWJPhcbses7Es3E7HA2OoGBa2y1S3HPBfeIbACWnWLbGvdjvVbsJzM4l4KgDRegzrxK322nNXF7y4YPwGpTjOw14tjofEmM07j/C5OgEeIxSkIdeDh9Oyfl07+JUn0EMncP4n+CBE2raVu56kx4bSH7+0WuJiyUEOjyBfOD+XxUWPuUAHk1LJuNNtBJGBpJX5e5u82uhlN9KTh4ybOidaDQgswTKqR0Pa9VxFuqtudKbYofFxDrmjIrhxRRwzzk8i1OBO1/eKhHrWtw6Zb5fPrFa56rM2och7noAcDf4n X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB4431.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(39830400003)(346002)(366004)(376002)(136003)(478600001)(316002)(6636002)(38350700002)(8676002)(66946007)(4326008)(66476007)(38100700002)(450100002)(6486002)(66556008)(8936002)(6862004)(41300700001)(5660300002)(52116002)(6506007)(6512007)(26005)(53546011)(6666004)(2906002)(83380400001)(9686003)(66574015)(186003)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?aqEmPM/FTjsgmklDXNZCuQbBdWpP6Mk4pqN+76+gTdluWvexwdM+r6ccMs?= =?iso-8859-1?Q?YhTH7LLrnrHCtRqFVCgMhwK02z3s6o7qmDMROVEDNcUT2h83j71mCRrAnB?= =?iso-8859-1?Q?KUwau690RwfD9xlaCDkwBD+bb8BXOG5CGDKZVVN4BQztlWVZjnna0WpOo6?= =?iso-8859-1?Q?7sLgpqioA27eUZh6Ijrqhnvx3Fz0XsvLTAr++mZxlhzD7xlGvUIjfOb8az?= =?iso-8859-1?Q?G9CYvfxrY7BWnoAXzInaCdvSzha7d8KVnGG6MEv28QfvtnX9aZ9qd/n9Uh?= =?iso-8859-1?Q?DSvMNXmQ0DJ9K/by0DEwIVkT/XRJDahAsWCwgGcYaIXt3QI2YRjZUi9JAQ?= =?iso-8859-1?Q?iM6ILYSIztpA915dVXq7liKWkWr0ZN8iRyQjNhv0jTj6YBNY8EmUNHDCiO?= =?iso-8859-1?Q?BPotLE2u9YjL4cb4p7xYyjFJUdEg3LzzGONRiC9IDw5D3vng2v0+SEVqlX?= =?iso-8859-1?Q?LJ+A1NUiNgLd4n2d4P4hKxet/y1IkUz5cYIVEokkBMqzCKt5PQhOC+MaCj?= =?iso-8859-1?Q?w2YHE4ad/zHrUiLlSP/9MYESpfv553sztzJMA5zgRQrZJ+FTMDtqSBB+aA?= =?iso-8859-1?Q?fo0jWkZj+u40HhohM3NRw6lpWFBpouR/LbMvtl8i+rukmWnkqdkUQTG1SO?= =?iso-8859-1?Q?R1PM+449TsSUx0igoMG9fVlS0zLdL55rHGWJygQUWQQiO11XzDZRDnXi+Y?= =?iso-8859-1?Q?egnF2Q87mglYjPihsykM2qEmxSXW1ROLpAYe055Aa+GSkLGZmWgUkcz7yK?= =?iso-8859-1?Q?4gou/vDgm9ir8xmasN9OmPJRZJ3Z99bvJi8HxYB8S/pRxkBLBF0e/xJl8I?= =?iso-8859-1?Q?VosZMy+0w6kmumQomrubz3yrDJjtDAD227R5wNADzXO1SqGtPdcdHiRB54?= =?iso-8859-1?Q?VokpgpqLLBgIHd5OpUp3+ccEvn6ypJ11CCOAw927hgkn2ZHJii6t1UyMw4?= =?iso-8859-1?Q?54H0HzibNx3Asv56dr3ayU/7RJ3+WkZY9/2tGr7+oK2PCVWPMXuuUIGbWs?= =?iso-8859-1?Q?bdcGgVdl5vLk91rZ+vqikVpiwsFZMf0ff7Ogy3n66I1a6t51v0ls8gLEhx?= =?iso-8859-1?Q?Vc6R0yNW/6OgElKwduMihnmagHL7Wkkl6V7UvB6GPKsLggKaiZBtDpWXCi?= =?iso-8859-1?Q?zvwWw4sDSxwVhHOUhMstXWhhADUeMqN+Nzs5wseQZBKFXurLmIZeAIJRLM?= =?iso-8859-1?Q?luIVPsCHrr4oAcaFx7u7P6ecqLo3qq1MvTEV7Wn5yYQvjwZ/Xiqwq8WP5x?= =?iso-8859-1?Q?lVdqbAD5Lnjyh50oD5zm0DmOtE0oGt5uunnil+X3aGpKtJhjfWnIFXfI8H?= =?iso-8859-1?Q?agVzEl8cbK5P4bpjU76w+qobWJygnAAdoTthMj0vf7FlYgpo1Y0q/S5Fvk?= =?iso-8859-1?Q?Oyluob+/4FNvOaXu/BTYgoIsurrBJuqOgZC18VYI44OaNh2fzy+XwYh4/0?= =?iso-8859-1?Q?x9Z0/Yx46ZYyvxZfW5CVMirOTf1EDEqipaMdfMmA5epZMNBNm9lH608Bfd?= =?iso-8859-1?Q?vPZocaw8mwJ+EtP8tic2omI22KV60yxVy/rjx52Q3n7TlOWXO76DlMZEkR?= =?iso-8859-1?Q?VSbvpnztdYHSX5Mx5psK8fvTB+4cs/rLkiJeyAoFihU+oUiNCq444PkcNc?= =?iso-8859-1?Q?S+WbtIjeNbMZZN9x7IhwxXGrCX3Zg08P/0s/f6xZS/vrG+7zmzuhMkig?= =?iso-8859-1?Q?=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52517acc-b3ba-4d36-9d0d-08da8b294210 X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 08:17:34.6213 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hTWWTyLhX/p8J+z4i0RSQjBpvcxUnqpbkraoUhAc5q4bxM0dZXLIU0r22jMp0dR/Vo3o3OckUjCOns9e0Wg/bdpE3PifBzktbKKT6IEbYuQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5435 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi all, A gentle ping on this patch. On 2022-08-02 15:55:03 +0800, Chaoyong He wrote: > From: Peng Zhang > > During initialization of the NFP driver, a file name for loading > application firmware is composed using the NIC's AMDA information and port > type (count and speed). E.g.: "nic_AMDA0145-1012_2x10.nffw". > > In practice there may be many variants for each NIC type, and many of the > variants relate to assembly components which do not concern the driver and > application firmware implementation. Yet the current scheme leads to a > different application firmware file name for each variant, because they > have different AMDA information. > > To reduce proliferation of content-duplicated application firmware images > or symlinks, the NIC's management firmware will only expose differences > between variants that need different application firmware via a newly > introduced hwinfo, "nffw.partno". > > Use of the existing hwinfo, "assembly.partno", is maintained in order to > support for NICs with management firmware that does not expose > "nffw.partno". > > Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") > Cc: stable@dpdk.org > > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfp_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c > index 5cdd34e588..e9d01f4414 100644 > --- a/drivers/net/nfp/nfp_ethdev.c > +++ b/drivers/net/nfp/nfp_ethdev.c > @@ -680,7 +680,9 @@ nfp_fw_setup(struct rte_pci_device *dev, > char card_desc[100]; > int err = 0; > > - nfp_fw_model = nfp_hwinfo_lookup(hwinfo, "assembly.partno"); > + nfp_fw_model = nfp_hwinfo_lookup(hwinfo, "nffw.partno"); > + if (nfp_fw_model == NULL) > + nfp_fw_model = nfp_hwinfo_lookup(hwinfo, "assembly.partno"); > > if (nfp_fw_model) { > PMD_DRV_LOG(INFO, "firmware model found: %s", nfp_fw_model); > -- > 2.27.0 > -- Kind Regards, Niklas Söderlund