From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37609A00C2; Wed, 31 Aug 2022 13:56:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22E5140F18; Wed, 31 Aug 2022 13:56:07 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 1B32840395 for ; Wed, 31 Aug 2022 13:56:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661946965; x=1693482965; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=HnNezg1KlTwVzrUfQe4QPvPY4n5Os0lh8LCurwvdAY8=; b=dv+hpqE9ExdnEOj/pGyF02lsWDUnh26q38glDkEJx/bMORFn7R94/B39 Cy9QaLqhgBITkC2xglxI3zabZj+t/BatNc97e+PQCEnt4rC8dF8I1PGzt EPn7zA//MGp04BWGzVqEIr5V2nTjVRCB5pIZghgqi5GaiGR1Ns/QV2jAa OfGaeEW3brj7jCDJjn3t/lOWDaZDfavyOCSKOSbVWbY1wUhtS8Wz06g+4 K2ksTPj4+Mv7GbPOWv3mbgs7xM9ZUHDfj2aFgJ0payax1BFNp0OzapqED 041lPAeP2JoiTa8vOaWLwDbgLIQe0UqqR8zOdO9c/y2rhjRA8n0s5P31v A==; X-IronPort-AV: E=McAfee;i="6500,9779,10455"; a="296214322" X-IronPort-AV: E=Sophos;i="5.93,277,1654585200"; d="scan'208";a="296214322" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 04:56:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,277,1654585200"; d="scan'208";a="641845356" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 31 Aug 2022 04:55:56 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 04:55:56 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 04:55:55 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 31 Aug 2022 04:55:55 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 31 Aug 2022 04:55:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Urov5gKfRNedni8PFeByD5mGh9g2M57cBEG/nR+em9X+LT/tK3oPQmEzO1cZRsVdoDzYfjTZ1+cdvaWqdbwCUdGyNQwJAE7rSVSvAckNGneHqwdS6wD4gpNZUrtolGDsB5fvqBpQIEW/AuO4Uhh4mY0eb3+l+n69/nwBVwEhaXZwhii6STwAGo9XvKU9MAXW5cU9t92qa6Ircdze3EpfvG5/ZQ+a5U49LSOpU4iYZGFbeCnFSA5MsabtGctShbMwHUjff8YLoozKWrZBv5mdH7nUlyIxeMgPwZoVBuiXnT3tD4+rpFP9LM9YTAzc3LDsY9ryOLq3jfpZJhl7XJvOtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5+MqQVek5McsYCwtY01Km6rq8+3XLaybxeFPwKwmJhU=; b=cHW93uKkc7xNGwU4tl5WCuhC8WphzXqkkvIVMxL/AM6gTreC3ExRv7fRqrYFv4VFg/Bf3WKbu/KdC/Ap9gE8aaKbQQOfFi2B0DFrTPdlTkMh/VWR3vvQ40dEHksNi1EE83dh8LUkrCoy7LHRlFY1fggtB3s9xmFTp56l/S7CSGfqGn62T1pZ+KUXODtcrl+zYxIszuAtgqqnrfEFW5/x1U1/m74NDzz3uOp4IYHv8x4j6r+9O4SOJ9woePcp/fZX1b8i9tbUsWcxkF81iOBXL2f5YoTnoyFXONjTOYE3CBKkthyWN08EwMmM3Y1PXunZjy6/4KNOAid1r3UnOOAXMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by CH2PR11MB4487.namprd11.prod.outlook.com (2603:10b6:610:44::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 31 Aug 2022 11:55:53 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5566.021; Wed, 31 Aug 2022 11:55:53 +0000 Date: Wed, 31 Aug 2022 12:55:45 +0100 From: Bruce Richardson To: Conor Walsh CC: , , , Subject: Re: [PATCH v2 1/2] usertools/telemetry: move main to function Message-ID: References: <20220824081539.12379-1-conor.walsh@intel.com> <20220831115250.362189-1-conor.walsh@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220831115250.362189-1-conor.walsh@intel.com> X-ClientProxiedBy: DU2PR04CA0164.eurprd04.prod.outlook.com (2603:10a6:10:2b0::19) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6f31872-045a-4395-8ae2-08da8b47c188 X-MS-TrafficTypeDiagnostic: CH2PR11MB4487:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r9DV3Id9AIvgk+exvkgCCJfYvHE4fN9X0YN6RunJrzUWaYjN2dxZBrIW0EwaITCL5Ltjuje++i17BhZjefPf+j/jeL2S060cssLZpiQXj3A6Dl3vLI/kc2djv1TkaUBpIwFMdcdpyPMjYjusxcH3aksCZKC9e9+Frl9j+7gscjkmaw+6Qrh2OepYneT2uvZgOBfqrn6MIM22jE3YS5vFo/XPipo01WWc4KkV5w+pKjxryAZCr4pqB8M8PbMnVEFxh6hWTccCXqFkBgj5HPDV7H+JwC/+4Zt+85receTXtXzko7xKOG/VcxfXTY+OYqw4fj4Nd7mJ/Fl+MPNPeR1HcRJ4FZFp+ksDPU9nhIMnnuG+24aspPyANrI4BHabXj1EFJXdoR5VIGE8ioJwvoPV4CQraYyerke6ZgM4GVCmVB/Fbqbg7NF5X7K+RNxui0rnAwuIRneRjO4CoXXu+my0Ttj1ss3DKgEs0tDMLv0RVbrgEsdf2zi+iDe94RIaHbSSmmHKLVOvxB7UM/T9za9VlwYLj77j+sCkaYks70rmhwn4BzKcC/IpGfSBCRTLrI/FlDdUpjxqjEV8YQoEIZ9j1HWcD+bxencJVwJv7GAQLZ2irx1L2XjNZjQ9xDYvQN4Z+zeV+NCYIdaF9Zi+TEJ8ArAtfiI7ItFpCyTm6b9OO0B2wzj9Soyw7L3AOI1Kw64qE3BZN/hCfzTu3Uc/jzlfrg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(136003)(39860400002)(346002)(366004)(396003)(8936002)(6862004)(66556008)(66476007)(4326008)(66946007)(478600001)(8676002)(41300700001)(186003)(5660300002)(6506007)(4744005)(44832011)(6666004)(2906002)(26005)(6512007)(82960400001)(83380400001)(86362001)(6486002)(6636002)(316002)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fwDudjU/XLL+yQojHuwfLc5juLDZaOKpHiSmfRBPKgTrilN8BpVzkY+OPFEK?= =?us-ascii?Q?PcqJuCy2fWPnU2KFmk/8Z6LDNRO7PLf2+ReOWpaDs4ojcRhHC+jlR6D6Cqo/?= =?us-ascii?Q?CM/n5wDSPbs3TL2DqRlUT/hUL8zn5PHvNY/uh/kYA8DdyYax6AF7utx4Aa4U?= =?us-ascii?Q?m1en1oDRDakP8mbadcN84ixZ+OVw3CeI8iDlg0yUOW6Rg/vicv115a7RoqWW?= =?us-ascii?Q?cCLDzeHjWuOxu8PZJI/bS4pw1tVQq1XmwaYW4hOFIfN7Xx+xEVw1dP5Eippc?= =?us-ascii?Q?Oen5zPW23FBxCcxJjI4FT82FYJK5xUTJl8Q/pm2lQKATkCazt/924kszStFO?= =?us-ascii?Q?ej4s+uCRNeS62fHC5l5a9rf1ZY/xeNW+f5Ei8hcDeTDcR6iGTkqlNQ2L9uV3?= =?us-ascii?Q?rKQoN4E/WezutW4gxux2grqvC3GhHyIOEVgvmSK6/2zS5FDJiXDOehS0KH32?= =?us-ascii?Q?/8qGRVMkWDuEoJUGtrE6SoOSaJ8LC8TXzBtePBEJI8bsu07qldKUIlRmSXRs?= =?us-ascii?Q?TPYW9t9BCGIZEA+lGwa1iSuEmR5JVJeGS8V33PG25NZzjajZ/NOHne2VQMo8?= =?us-ascii?Q?juYwPtrWaRGMKofB7xTXjDMSzwXYe4Xh9mPYRqYwNaJiLWz9Pyb3M7LSBf6v?= =?us-ascii?Q?iWIsNf87YJq1aMVMzNrs5FngmYQYm0GjqJ58ce8kSIXm4cJEXIsT19IjbsJE?= =?us-ascii?Q?LnlLLvoDddOvBbIuz6DeHxUBXn7hRo6OhLuhPfDln7lbOVHMSqzLhoZXGmEi?= =?us-ascii?Q?ny6NYYYnB1pi+wHADZuY6sdAkoihjfUPfWOjdGI9OfgXO6i2vgTDO/dCcdA0?= =?us-ascii?Q?APOGHHzY3zOIvQZfG3sMtB79PSi0Lc8RvgGoBDnxLfZbs2L6HBhyrfMXvmkf?= =?us-ascii?Q?lr8WZ/+ilYDcAi0zQD99ZSO2arUzwKmE1FTiXmMqv6ptoongnZz6MRc9raoW?= =?us-ascii?Q?jrvX4uJf/WxbJsszLiTtw6+7PFf2a2hWdJnd/0tuIxGzOnuan6GfXykaC+ks?= =?us-ascii?Q?kYKONXIooBGfUysb58JVuM/NYGNwNrSG8oPzmPq81CoN1cPZrxH0RJh3lT2o?= =?us-ascii?Q?WmHSrYe09kUnW6QN404c4qT1RQ5YUsSUCr3mV6KRiao8WasvoQLtADhcWOGf?= =?us-ascii?Q?ZpxcN/bmzWRP1ISlU/3EzkygSC8btAtxrKiJ/m1cRvNwlLPEUlfQ96Ft+soM?= =?us-ascii?Q?nKmTlvniJT3lOfTc1w3CInUbOxRI8M0h88lUQ1sOcMU7DT/xPfx/cMjNSZQ4?= =?us-ascii?Q?Q8BKJYrSGGxqUeagw+u5hmsg1CGHb8HUOH2nSAzF7feP1fGOpQJY3HunwtmS?= =?us-ascii?Q?Z2P+g9vsaYFLnbP2I818F5fPYwJxVOtC9b+ijf9eh4OsflYQIqhVYls7yj/9?= =?us-ascii?Q?5Z0mpJD3YE+RzTj9vhxFNfgbG07UQvDPcBEBe1DfHjgn6EiJp5KY2cgTEllh?= =?us-ascii?Q?aBDqEPTNb4EMv+GKJhbbs1z0zzalx+ZAjuZf+Ci5UeunDG97qjRdmZ6ILpPx?= =?us-ascii?Q?eJQe6Z7AB9dClA9jBoWxZ/H/o/ZjIPN7N+UUdnxtYfu2WOI7OJE7uZ7dpUUY?= =?us-ascii?Q?mEAU1IL9zPYrhbe3ATdAtp/bXK3DrvPYpW94uVJkdNyFuir0kHd+ehf4AnZK?= =?us-ascii?Q?vA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c6f31872-045a-4395-8ae2-08da8b47c188 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 11:55:53.5361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eMiXrJI82VvbhEkb/gyMDTHKxHS2tZf8kbgZutUebvLkAuUuPNMCleYvW8Dubo6HCY87aQUbNuWBLuZ/6Z2LDPweorF7P1RVpxp6/N7zszk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4487 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 31, 2022 at 12:52:49PM +0100, Conor Walsh wrote: > In order to allow other tools to use the generic telemetry functions > provided within dpdk-telemetry move the "main" part of the code to > a function and only run this code if the tool has been called by a > user. This allows other scripts to use the tool as a module to > prevent code duplication. > > Signed-off-by: Conor Walsh > --- Acked-by: Bruce Richardson