From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5AA4A0540; Mon, 22 Aug 2022 16:07:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5628F40A81; Mon, 22 Aug 2022 16:07:01 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 96D3040694 for ; Mon, 22 Aug 2022 16:06:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661177219; x=1692713219; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=9lXf0EUTN8lBqSk+avtFikiUgf6HqkoMG6dE0wqwM1M=; b=mscBnia/14izvJW//mPnKNCC2EZtluPznc7bb7yTTQKawQMgup++71lo t41JvGd2uamh3MFfjNpdqRqRhdij4102IybbXyM5xsfdso39C+popnLQk 4RRRHg+tUG8cmu4qw5RC+Za2bVA0AuufthIqS2JVUAnvdj2ifOIZ1zK7r Ga9XhhovCW5iYQKRHwFUySlSRm37IAT2l1wcIoKvWOXD5edGi0ivG2s8t 9VPq6GbNs2gd6uYRG9phZ0itjJq0Kngf5MSX+Y5lpBqK3DG4/oSfnAOWz aA3kGWKAL7hlGZzfKedBmNClpZPBXjoH1qufYSQPkfDqTPnwG3iJb/lpl w==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="280392271" X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="280392271" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 07:06:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="638213638" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 22 Aug 2022 07:06:21 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 22 Aug 2022 07:06:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 22 Aug 2022 07:06:20 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 22 Aug 2022 07:06:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhZxxsF9KK+tbgX1z6a1PM774oGNI7qH04CsXB6Z1EaMA/R3IOJ4zOgwBHqZkQruJ35G+XbvF3qR8BnMOTmLQ3dlow8Dh22lhos6E9VNqciQebH8Z/dJ+8tQiXFp78SfT2aP66NJFwSdy7qrrtBGg81OpzVr9wmQRActLPtythDSYobnUTx7xE9+AND7cxJ11dflqIb6Uaz8Fe+stAd9paui+TGVCAzqxXHacmM+zvppuiQpA8xRNNdo3g+eNZiUhSu89TxRiZq7qDCDBqaUtZH9jt/5ATAH6mBCjOpoeecxRA8by7htJXuHkJmJeUGMQJw7BFo6Jt4wUEj4WrbOeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w0pHMNdwCCr5DppjLDP6eXs+xthHRig12SmqUkkalk8=; b=FfBfiABqMqlpDJE6Qo6kWrPcP59Fd26S8KFEQXFyloxUPBV7hY3rXLjr9Arc3o1BM9+Xhrh5wxOq3EWnvVwHUD2im+/Bhgwz5g1stR/R7PSgtDW/8Z0NT0qXyeKYAeeZN3KnA1S1m3flPl3KeGaqMxy+qdMAQNruxU7sevn9KwGsSLO1FtENL9N6N4rVJUycNbVPcY2gKj1xHbR1nQs1lIq/dGSzmLZETxAzQuhVbts5HvwHmK/MKJoXsXLXG5byFJN77A8dQHuYm2soC/2R4+QJvgptIn45+q2TQjDUWnJRaMt5zXrKqotc/RtMKFOwF68td8VjZ6lCDf0UCJihbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BN6PR11MB1618.namprd11.prod.outlook.com (2603:10b6:405:d::13) by MWHPR1101MB2207.namprd11.prod.outlook.com (2603:10b6:301:58::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.19; Mon, 22 Aug 2022 14:06:18 +0000 Received: from BN6PR11MB1618.namprd11.prod.outlook.com ([fe80::4dde:a8aa:b773:7006]) by BN6PR11MB1618.namprd11.prod.outlook.com ([fe80::4dde:a8aa:b773:7006%8]) with mapi id 15.20.5546.022; Mon, 22 Aug 2022 14:06:18 +0000 Date: Mon, 22 Aug 2022 15:06:11 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Dmitry Kozlyuk , , Ray Kinsella Subject: Re: [PATCH 2/3] eal: uninline rte_str_to_size Message-ID: References: <20220821205009.1317044-1-dmitry.kozliuk@gmail.com> <20220821205009.1317044-3-dmitry.kozliuk@gmail.com> <98CBD80474FA8B44BF855DF32C47DC35D8728E@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8728E@smartserver.smartshare.dk> X-ClientProxiedBy: DB6PR1001CA0028.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::14) To BN6PR11MB1618.namprd11.prod.outlook.com (2603:10b6:405:d::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c4f96dbc-5a98-44e2-5617-08da84477be6 X-MS-TrafficTypeDiagnostic: MWHPR1101MB2207:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jwobSPMRZnHBn381QM92QR9+GpcB0L0x5Cs0A8jsgVFtygabvPwGTasGL156J1w/UX+PNHDCiU1UMwn57ay+0nkZ+CAbuvXR2t/2wxRE6FTBAwixsf6TG4/yVLtLSb8WA8uA9O/jEHvxYmyfF/PtYRuIUNtQqLdD+P8G1crUCb/toHqDETxZqdtupGO2I8wWpbiceVdTxpphLmUWlGnGaHO5MBMRLCWK+/VH3Yu0OhC9tbIWBtoPd1UZYv9v8AmqkvSmv6g45v/HZ590EQyDHw8WJA8P3BELc5QL7JiCLblfoqzRN0ZiqgCWQPq1tt+aj2cx500omOr+oOxrgWnpo3S45uobCKM7mub9+3h/oyUBKmj6tM+HDQ9r7K81SGKDCVd9wmPXMVW96oFHMfj1Da/P5PBQESOiCRL9TjE0Eu4IMib85RQ3SdJhoe95ePNwqqedxynMN/zhEpqlhR04KtUHyzvuDvrlPg8S+EFw9az95Zl+WWftGLCnkfp+7tvSWH5IbcJBAKw47qHInNsTot0PCJNQpL41CBPeNHw3QWm2jvJJZCtoPKm1buHWEQTOdVz9a1Ph8IXM6Ox1QMQAwffcPp6NxfHk2JGUxJNN6WjXDAXI7DVZdGA+SJIJmI8H3Ol2VG+VXdTSWbsulJ72n/LxdAhqt46g1z6Wh8Y+1nTR8qvNz5lrMc/QWJmBb1l4WDGEZOn08SpQcwrwsky29pwqEvby1+W3W3UMWR1hFIjalyEbKofN1D7KHIxXtVls X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1618.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(346002)(39860400002)(376002)(366004)(136003)(478600001)(82960400001)(6666004)(6506007)(86362001)(6512007)(26005)(41300700001)(6486002)(186003)(66476007)(66556008)(66946007)(316002)(6916009)(4326008)(54906003)(8676002)(38100700002)(8936002)(44832011)(5660300002)(2906002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?xgwOwzxxNds3uqJPiHmwd2SpD/Ah+JskFjk5GLlzNI8SWifqKQTNrBQzH8?= =?iso-8859-1?Q?G6hx41ZprZX7OUsYAcdW0uPBzNjJodbITtE0yu9V2v54ArGTJcEMVQSqm6?= =?iso-8859-1?Q?9bFk7OGlRlYyWBarWB5HE7/9KLj0r45N2p6WsRTeOQfqes1WRjLNUqeUCN?= =?iso-8859-1?Q?e7MRFOJxhlJOKcVEC6IxVLRk/7M3xH3m4v8TIiZtT/rdKaNPreAAfpMKse?= =?iso-8859-1?Q?BSQoTSwma2skBnHNPrCixT++o4vnB9ecL+e4YtSNtT3ERdEWPuNwah7RO6?= =?iso-8859-1?Q?BBjul1xOfP/nXYcnmAVci7ybJvGW/eW17eksX37x/J6w2IWTpKUnz7anE1?= =?iso-8859-1?Q?Gcd8JczbriKCaAJaoiRZLK6+7rqw33ORgwqlV2DPOvixdq7U2K7zqGurYW?= =?iso-8859-1?Q?oHdc3u4F+OuiRVJJEEgxzvpHHQIVa7DjvzFfTBIGI+B9HX0PmF0PD0FIl0?= =?iso-8859-1?Q?bwi3m+I9ZxtpyxfMqXyMBvOHEYiuex6AGxNVsukisDf3r2aeERU1h5xkEj?= =?iso-8859-1?Q?6/Sf6uuTGGOwvBIkatl/HWJJO82PBHyeVhArzov99glnAnbBCCO/3EEd2i?= =?iso-8859-1?Q?q2e+uzSrNPo/tIHG9FhrI4f6JK6zdeqMof1exTBrwKL+1+4XjroCgPZHvJ?= =?iso-8859-1?Q?ZTtnS0OsRv6bISwwrXzVaZftwSe+u7sq1tJpjDWsHfGxyYfYxunm65/DLB?= =?iso-8859-1?Q?8gmMJ4OmEpyyYdMSihPvLq8DMmcQMebdk9mMA3s1Kutw04gnfl0Xz4Iq9v?= =?iso-8859-1?Q?Tyaucssm/4x2ASkbXt9nHoCvlGQiMJJ8MKPHu6+3fQ7xfCbE3+/4x3XHrT?= =?iso-8859-1?Q?K0oXCg0vEaDBaVJg+Jxn8MXIJZvmVd38rUe/q1wcUHETmwozbCe27xicDA?= =?iso-8859-1?Q?fSkwB5Ah2puW69UOkSN+3AjvwyqzVkQojjdcFDWEbzCXhw/pFPH4tSvrKE?= =?iso-8859-1?Q?Pqkpg/NGSEAASHVco3RJh7VpkG3UFx8isjatno9gHVbOoNWTzKkMcQtxY5?= =?iso-8859-1?Q?YDnvmRXlUVGPEZ9weY6UxnL1qIaFw4KR6MKaDqRwaiQGOJTnTwzoRo3rNe?= =?iso-8859-1?Q?Z6SwMo2GIUXJAPS4QKahYvcV0R3Grhh5jOmukUBiruXyRcqW4xbOhs+ZSa?= =?iso-8859-1?Q?h3ixwGn+w5a2MyHvOCQucL+s9GrPSIAz7zuGrWK0tQb70xUHnxHJCnEN3N?= =?iso-8859-1?Q?YTgImEXK6OW7AA3Fweca0wgnqaRjP+UOlVHMRg8gpL25CQ49s4RjcSGgcq?= =?iso-8859-1?Q?fpC/IlehEbSTPJL0w83KGGDA8RHQDsfv3UkN/2FaXlkXIYE4QPi+4kGdRM?= =?iso-8859-1?Q?paysx369EZyIajell8cD6+kM/cECX4rZwVRQ9XVaJS2GQp5Q4afWvg+CfG?= =?iso-8859-1?Q?13nyKP6VjvXBRV3kUrM2hKEmHd/3zPLq1bDRZC1XTAzppvXh6KTSNuVVaA?= =?iso-8859-1?Q?z4NoUanVsQ7TRg70YeI6XGFLPIWid2BFOl19MPNyhBiPWQCYzrqZx+wuGe?= =?iso-8859-1?Q?pEJZJbtM6Qbkv47PjjwdLUuaWlpsPX2a/zpFNrbxZtipicMiXLTPmq8UoD?= =?iso-8859-1?Q?NP5la5rnqm6JPjBcGmbgpA/McAv8o1xDSDQjupKlE/Qm0EalGY2cJnZNeq?= =?iso-8859-1?Q?gslldekz14ktwM9aZVocYSgko40st3Pu8apKExfRLsMEfpp/IMhXtHRU4S?= =?iso-8859-1?Q?oIPPh7Z5hy4GvFqNIpY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c4f96dbc-5a98-44e2-5617-08da84477be6 X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1618.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 14:06:18.6177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: swRVNsVcNCqMtPXYrfhn3zdCND4H6x8StYZukmoGHsLkT4ce8gjob21vUHVWqIxazV0ZcT2VU4LfEb8bi5caGtBCFZuxOEEUbcs3rJqJvE4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2207 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 22, 2022 at 09:24:47AM +0200, Morten Brørup wrote: > > From: Dmitry Kozlyuk [mailto:dmitry.kozliuk@gmail.com] > > Sent: Sunday, 21 August 2022 22.50 > > To: dev@dpdk.org > > Cc: Dmitry Kozlyuk; Ray Kinsella > > Subject: [PATCH 2/3] eal: uninline rte_str_to_size > > > > There is no reason for rte_str_to_size() to be inline. > > Move the implementation out of . > > Export it as a stable ABI because it always has been public. > > > > Signed-off-by: Dmitry Kozlyuk > > Acked-by: Morten Brørup > > > --- > > Now doesn't need to #include and , > > but removing them breaks some DPDK code, may break user code too. > > I'm not sure what is the compatibility policy in this regard. > > If such a breakage is allowed, I'd remove includes and fix DPDK code. > > > > The question I'm asking myself here is: Do we want rte_common.h to include common headers like these, just so we don't need to include them elsewhere? I think not. > > I'm in favor of the principle of keeping it clean: Remove them from rte_common.h, and deal with the consequences. > > If we keep them, we will forget why they are there, and some day in the future, someone will ask what these unused headers are doing in . > +1 Since removing headers is a build-time issue only and not runtime, I think we should just remove them. /Bruce