From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E7C7A0542; Mon, 29 Aug 2022 10:24:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CACF94069D; Mon, 29 Aug 2022 10:24:08 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C46E140694 for ; Mon, 29 Aug 2022 10:24:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661761447; x=1693297447; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=mOYGqzrLZaExRYE0KNdzRMgQqXdLlbgkJ5pAgo5ujAQ=; b=LNAX6xZK4n6TRZ06ESLTcbA5D5DGBrAhklX5EGIDlYSOvRTcCJ0wOceZ L/mA1BlGmg+ct83NK6C2lzlLzldWWo5RBLzsYCRmPYeQ9MLK6BARu05VE 8BwyMg5iG4zV+Vh5YAF66GUTq/rv4FgJOY55gu8U0g+blltzfwl/SReAM msLtkuxDfU38rgTa2YbjbR0DQ5M10sE6crOwaqUkpOaGFStcBQ0fl9D1a +zFikrwjM45XvxlklewZ4MYgNMyMrLHgkGQFYDdkJPoSylRB394Jx3sTm TSaTj6GGjl0XMe7a0mHbSCMsU9THCZc9/JudmpgQc9BxDicFv3tHw783V w==; X-IronPort-AV: E=McAfee;i="6500,9779,10453"; a="320961678" X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="320961678" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 01:23:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="753552280" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 29 Aug 2022 01:23:58 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 01:23:58 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 01:23:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 29 Aug 2022 01:23:57 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 29 Aug 2022 01:23:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ljnU4v3gu9LhzVOSa6XK/reEezfm892A9NK+Q8PodtVpHYlqT+/ULgNuUD+erjpKcHfzB7tv7Q2LJS7Gt2q5rup5FlqDb70meGHJdFzg/xp4bs+rNwxPCzfIuEYVORaLorLb/5uL55na28qs/wt1t4B7mlARuwu9xeAy0fg3H4HhrgUIymofs9Et4csXxV5U1tgC1hai5zjup3OD4U0T9FnXyZHcq3QJkV6wfJSG3GfQAcexfudm5oSjRFD6Y2+jqRrjDPgmJ0mtg5bU1nA0tmOvr7CPEaVGUPVajufgF0S2ixOyjD0Gu5MuJI+OWVODG+tykwaaMGPicuXouPCUCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mvDOEVqz6oXBQYTWTfXFoLQkc48xW0tPyd+Dj9SQZKQ=; b=acONTRP0xdt4WIQU3N+WWV73w6XwAJw+x1vM+grxyixogc6zAWYJUgcqtqxhvtGD1JOrelk72bhIYMN9IHKLD7BUdZ/4kaArDx+rBXGIkyVbwvPRAWyn9/+EgZDsSkJiE0AqN1jc4IcintB8I0vImON3x9YSbaeFY1b5bMp0Oh6mopWbpGZNZNGbOeGig78J1zqBB9kMsO6rzyD6oes43Dkn9FMWfSxqLEiM5EpM5NHvZ1T9qzjH7Nl41nRXtQE/QmCH5MpwVgYnKsU7Y91/lZaTyM3tn1cCKRUx5juCUHjyWsoui7oqAWJszAYNi+NKMV+HWt1eVBj4v3mpKhO20Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DM6PR11MB4348.namprd11.prod.outlook.com (2603:10b6:5:1db::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Mon, 29 Aug 2022 08:23:55 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5566.021; Mon, 29 Aug 2022 08:23:55 +0000 Date: Mon, 29 Aug 2022 09:23:47 +0100 From: Bruce Richardson To: Mattias =?iso-8859-1?Q?R=F6nnblom?= CC: Kevin Laatz , , , Conor Walsh , David Hunt , Nicolas Chautru , "Fan Zhang" , Ashish Gupta , Akhil Goyal , Chengwen Feng , Ray Kinsella , Thomas Monjalon , "Ferruh Yigit" , Andrew Rybchenko , Jerin Jacob , "Sachin Saxena" , Hemant Agrawal , Ori Kam , Honnappa Nagarahalli , Konstantin Ananyev Subject: Re: [PATCH v3 1/3] eal: add lcore poll busyness telemetry Message-ID: References: <24c49429394294cfbf0d9c506b205029bac77c8b.1657890378.git.anatoly.burakov@intel.com> <20220825152852.1231849-1-kevin.laatz@intel.com> <20220825152852.1231849-2-kevin.laatz@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB7PR02CA0001.eurprd02.prod.outlook.com (2603:10a6:10:52::14) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e855dfa8-80db-458c-5271-08da8997d004 X-MS-TrafficTypeDiagnostic: DM6PR11MB4348:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +ID/WWDqaIR1WHtlP6bZOKfI0Spjmfojzeyi6vmaBXaOAAn516xl0EKY1I8XaiPBxXEVVpSUv+mSAeyZfUd+Bxq8UG+K3G+DXp/NSi/Ildjz0G8ipwDpotKmPugkf7mJ6cbiqApsPQk3i2PNuoTrkSfPNGNawWfc06Uz64HIRWU/reKL+xq+jDSSHRuZ67v6PZF5DemQgYQENO7keHr7CyUDqru0gJ49W7gwzN9jMq6Q5/be3av5IyPWQA1+fXUxRpS+z3PyQVdwUuArz64tpOv+WBMqxHxwfh0zq/nVLmCkz3Nsw6XlEbB2//P0fqSc43PYN4I7LTS2V+wTOqZEQjw7iNj33DA/8Ytr6qIqKRMekCZOmXdNNDcaEc7NgoXh6wVmbsAnVi88ACLNyLNJ4Dy74f69GgMOr6VZaJf/V4fQ6XFBe6uRuOcI+uPW6CUVU4QbM8fGCN8YAXxlMo5utKerQrEAWuJ8vRNRrWJpqKdusnsz9FQxPg+xTzrQwKou7MW2i0pubQQCcTvZPNWKSD5LpBdoApmwllDY7yMX2csVluO6+HVTvZRgKkCwIEkNY+cVtpPYXEk8jGQn9KLASZmM5HbZgQIYy0bwUh/dDYcU2Z2h/NpLNi6gsE6qR7MCPpIxsoRvPRJ2EZ2y2MPBAX7SY2lMGV48uQSmJroAqN52bVOCUDyIAZQFjkZrcqjsIbEMYmAFSTb7aCEj69ljEQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(39860400002)(396003)(346002)(366004)(8676002)(66476007)(66556008)(66946007)(54906003)(4326008)(316002)(6916009)(296002)(8936002)(44832011)(7416002)(2906002)(5660300002)(38100700002)(53546011)(82960400001)(6506007)(26005)(6666004)(6512007)(6486002)(478600001)(41300700001)(83380400001)(86362001)(186003)(66574015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?DIwDQtgEr27/d6m9qea7X65a6wqYph36SVqpxGofxDv/qK8HIZPhsCBtXH?= =?iso-8859-1?Q?xxceHklAqdgJ6ofzmxlBE5qqqzh2m1Ui7iZ7c46wJCWMB6k5nDbi05N2/v?= =?iso-8859-1?Q?eCxBvif3HIZ6rnestYYKkKHHAsBEAwhINOEP9MhrZC/UuJ4KZIGF0OVBL6?= =?iso-8859-1?Q?36VEW99QoN5FnNRuBI8qRSQWoLpvN4D4Pbeyn+yRCvoCqkULfpBYqACdow?= =?iso-8859-1?Q?/nXODkGYKSQLiUT1UmN2Vx7KbFI9cEHwtLTu5O36n+xto9V2m9La+BovZl?= =?iso-8859-1?Q?XmW7QJRUsSHtykuWkRBlnjqjMnc1IxS81MVGY5cocy1tpu9t04+YUSUJ4q?= =?iso-8859-1?Q?OfXlqfpzOhBJpPL1t+t4x9vt7RriTwDB+WAMnSRdgq7WLTwYCstn6TTGRd?= =?iso-8859-1?Q?TG8W1EQbUQPMY2u5+L0KNw1Yi6vjPSbKwgPP0tGKOHfpnuoxFPp4bX76a7?= =?iso-8859-1?Q?YOO6lYN2Sw0xoq2vOFE8UaGEo5cTPoxsVF5hZQ7EUyOifyRXd0eYGnnNMy?= =?iso-8859-1?Q?lNAJ4vpF+UcUpck1fe9coSxAAxLUH8p+os75hx7c1xKUB0mN+lbAmQvSb1?= =?iso-8859-1?Q?TdxHma/DDWxhu4ap51uhH1POcJMTXPj0bjDjZigvOJ3Fevf7t0tMDOCfG1?= =?iso-8859-1?Q?L2A1v29uOK2kVE/e2RpsHQA5oTT7UYDfo4/z6cVC4UTu6RtdzPzrPEv4Mf?= =?iso-8859-1?Q?DRjmGadEmFDdkH3w4fYSznERnVBe+OKf57+BESKCPDr66fjXL3TJgFVk2H?= =?iso-8859-1?Q?slbcktsvh01hlFw5pcF147epy/8hyrKOLn0w+lwLBRRbLbTUu+IuQoy8qn?= =?iso-8859-1?Q?aMWiqMrtr4UhjWkqLg5sCZ6HsLcjRuFh4XtbdpRBip6iOEi9yisvYd6f74?= =?iso-8859-1?Q?VI5bTAdEj/oUNjHX1UmayMjeHw2iaXhQp60OZUskDFo1d9vY1TAqcCJNbz?= =?iso-8859-1?Q?yk7OdpSSwzo7cSstPoEHMYKxfy/atE11gNjHTce+gyWBRocJiQGDIRAa19?= =?iso-8859-1?Q?6Ssm7L2iC0s0lB5QoIAAlzQJcOpDbhkrPdlm/mjZA3dtmYIACnbLkTPldm?= =?iso-8859-1?Q?tyMfMvvX3b6hMLQ68p54yzBGkU4ZmXYLV29n5UCW+7b/u9WB6LmAxV9Dl5?= =?iso-8859-1?Q?r11pfx+7Fzjz+uqCTYNffEeRpwUv/TZZ+zWqHkquHCNqS008SzxqkNTNRH?= =?iso-8859-1?Q?NjZZUdxRtu3ctANGBgAPFnzxZshU79MRgeFY0tDiVfAIH48MYlpZQW+P5B?= =?iso-8859-1?Q?/f0PUnMe7ks4Zo5GApGOfuvaA+B0UoVMhZprshOFblzHCRapk9bHij1EPy?= =?iso-8859-1?Q?SafRecrlQxewmKmMnNW3gO822LgZAahECJZyDeZcW/4QfIAuBFOfs98RAk?= =?iso-8859-1?Q?8nqluBJjRG1QXr9okaXdZh4CxoD4PELYZ3eYUd5uR145vWg3m/inROB7eU?= =?iso-8859-1?Q?Zs8Nlm4gUeEAGGXdg7n9uJCmlmsJuC0tzjUlhcvcEaT77WbOO9oHJFJTFf?= =?iso-8859-1?Q?+4XGzpcXKLZIdQrrg1KcdlmOdFSOyzIwCBWl6cU7qdcVyPKvZMMr/HdKhA?= =?iso-8859-1?Q?vrSoeEA9OKMkBlAEhewLDZrH932VARHr0MTMlyLJGjGhgNiVuDYD1jbRei?= =?iso-8859-1?Q?V0cTrxz9XmRzd9AN+KA7Mp1UgUkIdv3reXtyqNNGX8QaaDp+DNzXlfXg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e855dfa8-80db-458c-5271-08da8997d004 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 08:23:55.3263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7R2UxkTQwvtuIVLK7As9yjEDg99Waz3yGcvEGFWpn+d7uh7GB+ShielQ4RMeYBtBti57M9OY4kyTqnNPutXGcBv5o7nzJczBoX6nL57MLfg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4348 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Aug 27, 2022 at 12:06:19AM +0200, Mattias Rönnblom wrote: > On 2022-08-25 17:28, Kevin Laatz wrote: > > From: Anatoly Burakov > > > > This patch also adds a telemetry endpoint to report lcore poll busyness, as > > well as telemetry endpoints to enable/disable lcore telemetry. A > > documentation entry has been added to the howto guides to explain the usage > > of the new telemetry endpoints and API. > > > > Should there really be a dependency from the EAL to the telemetry library? A > cycle. Maybe some dependency inversion would be in order? The telemetry > library could instead register an interest in getting busy/idle cycles > reports from lcores. > Just on this point, EAL already exposes telemetry and already depends upon the telemetry library, so there would be no new dependency introduced here. With the existing code, we avoid a cycle by having telemetry avoid using EAL functions - and for the couple it does need, e.g. the log function, we inject in the function pointer on init. /Bruce