From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 415BAA0032; Mon, 12 Sep 2022 17:19:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24F62400D4; Mon, 12 Sep 2022 17:19:36 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id EC1FD4003C for <dev@dpdk.org>; Mon, 12 Sep 2022 17:19:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662995975; x=1694531975; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=4lqt66Cr8hi38v/vyR/AMGsJeHOFOiDqfpiSvErZgc8=; b=Iu1bpoWE8OY55pK2RTPoj2Zcj02JnrSEMYOig6u3T4UShcfx4pEwMNHw K/iBsp1IbSEGaip2JdLna+qKjCrRsxQjYlI7djhr55j7FiBAftuOF43F0 RJC7sbOyeuYal4m3zIhpyMZeBD7MmZwnZXUD0o6LUOL5dDZLlO8A7qHBt VMVPPzQcMz28qnSGSxZvtixiTu4xb9BnTGvfM9/DJab7h0IQv9lnG6oTM 63lCqeh01fxqZUVTErL6I5CHv2H/8+NUh6FnOXyZyzZnaLpLLV8dDxoKm OcwqG2oyhOBNZMsB9YfZxRljbjQObcjRGRZxWyZ4m1zeQJmzagMDA6XVJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="296625943" X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="296625943" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 08:19:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="611794543" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 12 Sep 2022 08:19:33 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 08:19:33 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 08:19:32 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 12 Sep 2022 08:19:32 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 12 Sep 2022 08:19:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QH6mGDt4GimQKsZyXXStkULUNcRA+chRvhJNvcncOk2tpYv2J60h1LmSmNBH4FAVtit0r1TV51rY7OgGKo/kgqtu6fUXiOIxzSZM6LyxXFCTFFkBcxodIwEA3IeQILmsHJCSOZwyvDdXmTD4gmi0S1N0DDKhf6RfeZNWL+uKt7Qz4mYkchtAHyzGhS4EJjKiXjQHS2pqDcqO8596+vWD5y3yeUgHQASjtFVrGWHdWWrYjquz/BYcdBHHAF7SIgMfwl+dV+jC7BnEpj737JGvVtBMlbqgsf2vZYydyZDLkPAI4nXmI+HM0TVEJSKYJ1fdUKtKMzpXYK1ROBlfUDGlew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDmGhiWMCYH7r6zsjNcWjNmjOEq0Cqif7vvNeC36gTA=; b=YLktSJzPziQQw0ePthWWZRq8IeAm5vrxS5t6E/aL4A9Cfc2JRz3XQYWZYJix8D4MU+F07MLJoTAN1Rg9r5i2xALdzp7AFEjg3xZgMNQDDguYCE9B8EpQekpcG49JkmJO/oNVpEveDmGTp+BP3N4XbyR4npYUXUpH187Y9hKGL3z/KcpgVXzUELYIc9KNN7iWCvEEN8UVV9fvmXPbFUKAKJWGhYZB8LH6dTstgFqsT6PGG3ENu/1dWABCBDQy5Op7CX/y+uYiDKoKZG3leemJi06yC5n0AOzARFpUWUXNgH03SHKaRkyzt0Mn1gtSbqAXnRgrkTrUqVZ86whsa6zHqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by PH0PR11MB4952.namprd11.prod.outlook.com (2603:10b6:510:40::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Mon, 12 Sep 2022 15:19:26 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 15:19:26 +0000 Date: Mon, 12 Sep 2022 16:19:18 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Nic Chautru <nicolas.chautru@intel.com> CC: <dev@dpdk.org>, <thomas@monjalon.net>, <gakhil@marvell.com>, <hemant.agrawal@nxp.com>, <maxime.coquelin@redhat.com>, <trix@redhat.com>, <mdr@ashroe.eu>, <david.marchand@redhat.com>, <stephen@networkplumber.org>, <hernan.vargas@intel.com> Subject: Re: [PATCH v2 01/11] baseband/acc100: refactory to segregate common code Message-ID: <Yx9N9qSRrPiQSyFB@bricha3-MOBL.ger.corp.intel.com> References: <1657238503-143836-2-git-send-email-nicolas.chautru@intel.com> <1662944938-32649-1-git-send-email-nicolas.chautru@intel.com> <1662944938-32649-2-git-send-email-nicolas.chautru@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1662944938-32649-2-git-send-email-nicolas.chautru@intel.com> X-ClientProxiedBy: PR3P193CA0015.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::20) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|PH0PR11MB4952:EE_ X-MS-Office365-Filtering-Correlation-Id: b148c9fc-2971-4e20-ad23-08da94d22de5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6K3kWPr1wZPUymFUjr1loktQKS0GjbvOUw7ANQXsRlKOXfra4QR0Rb8zxR6LxCfy2cyks1eBVux35cEELiR0zAnkH1EvFrsCNFL/B2EXqicGmW6UCbODsK7G5camN8UBxlsC1Tf05ad+vTSa6xvY1taz2MEFjAHehvHcXzKQeZxKOQnDPsBSbYhQuI89wMRqTpWbWPqmDMcvXAMB8O6JVeLSsxe00j2A9ym1ji2cIeWHi4paebo32OYkaCa+3q694o7EGzbv9GzCcWLaUIPN75yP212DwBeXOfsXOJxoG/srgxD+RJUgS7b77Ht6toEembrpJITp5wwFu7DIfk6FkHf90PWJiMYL7NClHo9tFwJr80FP2/jXv1QqZIEFbzHW5haP4TUXQp56PwPIXkWVDK4gIqUo/ulDJ4bNex0URmAgORFrYZpivt9dbFtwM0yBNrrhc7lbz3fhHPTKjgk3RPI/Zor09B0II25HrylFJ9reB+LdxpV/NuarBAzZ53L0PXb3nxg4U19XFss6rrta6oD2cFkGLWRE75KIUuWkub9OO724LR27aXGtlktsvZRM3ariopUK8afVPAAiAxOvamVA4HCm/OWPSzUtqFFcn+KMc2mrz9SOoXPPmwfHqoxslJt8wb2Ir9MywIKC8UJ3VbHU0yO4FGG6FR/2lfeXSdeNhl+gVCpAZInva+HAqEprPPqqDsMyw6OnXJuysJjHyA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(136003)(39860400002)(376002)(396003)(346002)(86362001)(6486002)(26005)(186003)(6506007)(107886003)(6666004)(6512007)(2906002)(4744005)(44832011)(38100700002)(6862004)(8676002)(8936002)(5660300002)(316002)(82960400001)(6636002)(83380400001)(66946007)(66556008)(478600001)(66476007)(41300700001)(4326008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CRD8vfqvuzF9xH1b2919BBZfxhmWzJFJtxkFTd6ngMR9OdsGRVII/rIPrxo/?= =?us-ascii?Q?Aa0xj/jwkqX1a8oL+QjpysaeredIjxDdweDj/creLpGx/0hmIkVb6+rMZJ8g?= =?us-ascii?Q?0ewKVt3RBDKQk3Twq+ujaF0qjE7K/xnRECVQ/aR9Era3PO7KabL2FbUzQ0kO?= =?us-ascii?Q?UJT5D+hHuXXDNp6WVXYdJI/anRup8nOx7DZEIlcet5EBWdYFaKenbeH2vdOC?= =?us-ascii?Q?5AWDH1XK1ksUrN5NtIQzYtWXhA26uPKCq3KrmEv7yalH2acl/HuChevqGxU0?= =?us-ascii?Q?ykgQwUlBfyJZwjeRnDh4LqJj1lfSmO3x449ndNN8QsE8NYJzonI7+Wb6wJL1?= =?us-ascii?Q?JE6qp+p9/0iENqamHJ/ZaRi1e4GAIgB7+CP/q1RQU+rX0NtjE0m8xaqGG8zZ?= =?us-ascii?Q?9VGGv0NLaeIKfOScCfyp2o///nK1jFlLbs3H1ZsLJhoSInZFez92xM8ndW6R?= =?us-ascii?Q?tQoEqRFekMtxweoB1oChifCNHTczEGlvibTImT9W7ryDzyuBAIgs3njCKzRP?= =?us-ascii?Q?MhP8og6/AET+QGNFacO/AmFU7rGqU1xUcrnMjd8r03GzuGR2hcc0XvA2YLIc?= =?us-ascii?Q?75WIPQZx2OCspVLdNJ/xKIgY2+zY7jMTcBz8vx9f8s4dMhi65Gup2dZcqdSX?= =?us-ascii?Q?RGgTrPDEjy05E5RLy+EeHHut30bqxp1Hzta/oA2xmxV48jkKRiiMCRETwcsg?= =?us-ascii?Q?eHUXzboBYEAzlM1VwfQqUrfd/27XoUKEpR4G1und7W8pyJBEFX1VY4YVEE8c?= =?us-ascii?Q?jEtH1d+5cE9Nz9jRG7wJuBR7piHwz6YN0C33m+OYqsO15f1jJmuKZd1ML0ZD?= =?us-ascii?Q?oncUWG19lQ5aG2Cts9jArgPfRMhsRpSxCb0+ItBJunIPhFJJNM9VFn4req1M?= =?us-ascii?Q?KAba/MiumvLV61RfyFRu/IncuN7QLr18coxrxFS7bvDrx3xijFA0z7MeZ5bs?= =?us-ascii?Q?8yLgemSQZe5cNhR9mBOGjAJkraSTSIyrYttEsqpM+wPkgRFx7lwjA+3L9ZZm?= =?us-ascii?Q?6/Ur1+vPwCknYXhZ9QfYp663wOB4UPcWwqlDKo+xNfv+vkHFkI5Kz8x3TbB2?= =?us-ascii?Q?cmHAw5xGMkkHFsE/pn9xBm5caxDh3n2NzISuDLaQvDWYuu5gAo51YGeqHkyI?= =?us-ascii?Q?cXvwelUFdxYxM2iNU8bU112WtResID35ZjOePLsArk1hcqeM8cibT4ujQRtM?= =?us-ascii?Q?TBzROnQBXnL/RFnftz8JOSmicMtnwMcHqjh2Ny9DsHiWjs/lJqC6Qs/RsIz6?= =?us-ascii?Q?wHhKpzSVpLBdbNh6+dldm8sFO61X/KAKDy4y7v2hxVmwBv4TpHxlfOybcYQg?= =?us-ascii?Q?qSSN0cJp381tnUMVs27cmY7EsewTVeeMq4W/591Y56EjepBS0TH8cOot2Mlf?= =?us-ascii?Q?LPwAT4LfUdtRtr2DDs7iOO0+cOAkfi5XgqkXLv2RaNA7ZUCGw+WUu8eHCbKB?= =?us-ascii?Q?XlFTW/gmltnQpixtJz99lQLVIYg+9CUvbhpEyA2By3n3p3s6r9sUUeXvOOB9?= =?us-ascii?Q?4IWQ1Skt9qqvywsuAgFQTK4mYeUGzDUw/PmIuJWb7Ssn++XlY/Z0rS0+NxWY?= =?us-ascii?Q?J/IKchKGZDFh5jl+lEg/XJbV9cl36B8vedAzyR4riaoFip23oaqpMh5DOltu?= =?us-ascii?Q?Cg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b148c9fc-2971-4e20-ad23-08da94d22de5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 15:19:26.1510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xo5gcOjvMH1smHUQqdhwVtpC8QrkY5NeWPdHacxw6ch8PjlZ1omNpEhbDRw2UlPnM1Lv+A8+BdYHuV/c4drFSJp2F1X8swXLK/Fij+ZTxoM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4952 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Sun, Sep 11, 2022 at 06:08:48PM -0700, Nic Chautru wrote: > Refactoring all shareable common code to be used by future PMD > (including ACC200 it his serie as well as taking into account > following PMDs in roadmap) by gathering such structures or inline methods. > Cleaning up the enum files to remove un-used registers definitions. > No functionality change. > s/refactory/refactor/ Good to see this cleanup to reduce future code duplication. > Signed-off-by: Nic Chautru <nicolas.chautru@intel.com> > --- Acked-by: Bruce Richardson <bruce.richardson@intel.com>