From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15114A0032; Tue, 13 Sep 2022 16:24:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE2FA4021D; Tue, 13 Sep 2022 16:24:00 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 9D74540151 for ; Tue, 13 Sep 2022 16:23:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663079038; x=1694615038; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=w9+tZmH1rytaDR1d05tKz1U8utsdyTVs3L1T2ae1TfU=; b=Dyhg04ZPctXYLrhT2Co6jt0pVzsh4HyngRx6AYzBBCYXGHN1vLkVj9Ql wgx8yfsTTlKbPOlAv5p0VsPu7leY8IaLyv3/0DP/uXRm7TzuekQ8tufu7 1fgvnp4mPBoleS7YzN+HWuoZ7u3dN4H30bPvzEqVo9NjE5AllWnA6OJui TJsPvwTZD3l3SrfpApUNAXlmZPmyPmNDR6bQImJI1+Ud60sytioIy4GNb 8Mx1jCwcu9RW2XoQ5PsgTcI+BmREkjyIGOU/gWI29j5kiiwWBQjaZXbwf tGYOC/quxH6IkkAjpedCcLWHpBVyd5eareIE3HDIGVXZvPM3NzlzKrueO w==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="296883306" X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="296883306" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 07:23:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="705566018" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 13 Sep 2022 07:23:54 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 07:23:53 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 13 Sep 2022 07:23:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 13 Sep 2022 07:23:52 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 13 Sep 2022 07:23:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cjXsGp9pWwvJXCKBf2cnP7aAWcfrVd3Fwbf+rTKKdmdafaQJBiVOvm2GTceMFiTpksVJ3tHSbKa67Ni78gE0IR8Yt/dH6OArM3i0jwk+06qUCuOiXN2/xJFAkDkA9mpOhhItFHfQNNCFLYyl4Kah2KS4+EQ8AA14Y15sXURxYr3nfB9bOLs/Qz4NDygsWRmGxZ2DbXzKGYBMX+s31JX6PecLrTI/Xrtq7mWXgFAXD29OFRlvGyr9+QsZNHz6rSWz9z3hOYOAPNxXOVwznDV2rWxrCMqGWmn/HPI1gXryGCXkkzUTQa4+53EZC9ML/fEWoj9dmZEzPwEt67oW3IabWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KTp6pUdkA1tOet+GfiGppdpc5gzcy1qN2rkbi+dW55s=; b=Kxf8snazFxGAxjMEaMYImnIHdQ2sY1r7SRpi+ccMmjvoJkgXIaDAcm5/Nb9O8cBZC8RB/4ESfO7SgxS9Ej5wBZ1iTKsmJCRirp1+BrriAMEcXzffbJzxkKYYUQ+AcwfkbVsF3Mllv3KUKk4ol6lmKx0lxdaFmbrOeRTD43COfSvLs9alsYlNJ+9YyyGryRysN3nsRssIcCWJmxW8ET5/z3UIaU2gkbCMEsTvWG2WCX37Jhpi5I1bfp4scQsqHvCf+iJCooNqhiDkxxNrY9LQAW42U8+XWReaU99y3+EDivjHiwPDCMGuJg2Fvd5lVNo5nsTc5GWJgJl5ZWCj7EcLsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) by DS7PR11MB6080.namprd11.prod.outlook.com (2603:10b6:8:84::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19; Tue, 13 Sep 2022 14:23:50 +0000 Received: from MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2]) by MWHPR11MB1629.namprd11.prod.outlook.com ([fe80::13c:8120:d994:16d2%6]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 14:23:50 +0000 Date: Tue, 13 Sep 2022 15:23:44 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "ronan.randles@intel.com" , "Honnappa.Nagarahalli@arm.com" , "ohilyard@iol.unh.edu" , "lijuan.tu@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH v4 4/9] dts: add ssh pexpect library Message-ID: References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-5-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P123CA0092.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::7) To MWHPR11MB1629.namprd11.prod.outlook.com (2603:10b6:301:d::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB1629:EE_|DS7PR11MB6080:EE_ X-MS-Office365-Filtering-Correlation-Id: 1108dba3-efed-44f4-5c83-08da9593942a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5GDRI4oy97v2JJA4xYyvTNxOemRK4t+DxtnbzvBWUqx6yN+NRLSOzgKLbTsr8UkJ4hCkKq/ZAL34ZnKhZbMQsNtX14YaimhP2UiSEJwDKn9ZHmRm+uLj1AED8XdbTlHNxcv+LRIf1Bzbljn3s+u/TAftLe8owIQ/CQr5b9qVJHNrzTzxPjkvs2BaLT9gSL1zI5mKD6+HjzIdOBMICuvQ8QxhFxm7j2uqIbOvdauaAAWZVLbsjXRsPUqjrYNatrgdzIYmDzUuLn4jZSL62yDWgAJbRxRG4COTLCLkMVSBgC9+PD/DdEIYsUyaBu2uD0WNrYX+GafHV5liYLNuLSEZdB0kCscNanvBDgzxAeChJENJ1SgNRrtSVMXzK6pJnjrayVoqAUcyFb9kBvsTV0NGGu4PX2tUJsbxtu3FbU2AKNEPSUJJKO9J3OCsXcY1YotSOqBohsC+29Aygprd4KieX/bx48eRwbc6h9nBtac9GEEew7m0YuPDPQ69ejxbJd0Uq5WyJaQagHPmV+UVAaj+aLLIWCwp9mq/UFlITzh3yisJOOvgUCyBOWKsu/w7PrP/k9xUYGDWSSdxmVpZ6jACyW3/hMQGmZzY4wcPNirJcxadlXZZChAbANMuji2X+Uc6QJw+acbA134665wUGRDaPFKclksFF4xErRGPGz7YW0e4J2pKpuj9ZSOu/mMwPywiEL8xD/EXnqTmbBC4vf67Ww== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1629.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(8936002)(82960400001)(41300700001)(86362001)(4326008)(66556008)(66476007)(66946007)(6506007)(8676002)(83380400001)(54906003)(6486002)(6512007)(26005)(6666004)(53546011)(44832011)(38100700002)(186003)(478600001)(2906002)(6916009)(316002)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czE0RmFoQzJVR3d1SXp1VFZNK29BanNlZHVCUGgvcGkxMEhEczlSRkl1MEww?= =?utf-8?B?U1FHV0thY1NzV2prR1JLTDIybzhKNkl1TWJLL3p0MnZMc2I1NXNuVGtOcDVD?= =?utf-8?B?MGJvb1JBMkluU0c2enU4a29qVStDWEF5b2lIRzdSOUI0OVZrM2lNUEFwaWw4?= =?utf-8?B?VlNaVGJMaTQzZTlJa1ZENmRlM056NlRZME5WWUtHWUY2OUgxQUhXZnJIRkkw?= =?utf-8?B?bW93RTVNckZUY01qdVlRNmpSU1J1TjRTYW1GNjBJY05uVUFHMklIN29DVlhR?= =?utf-8?B?VkhScDhTK0Y5ak9CTDRoaEw4WFNEcEs2VGJSZ1VBYnd3RE5tTDZScWlranMr?= =?utf-8?B?b0RVcVZScCs4WHRtcjhUbXdTaWNsclN4enkxTmp5OWJjMVEwMlhlYXhDcmRS?= =?utf-8?B?cHBsZVBac0REc0pUY0hyK3ZoSlZQbkhHRXF2ZHJBaUVWM0g4UFR6RUJtemJD?= =?utf-8?B?bHc4NFBGL2ZHdE83SUt1VEpHMUdXQVpLaVFNd0trOUJmL1AxWnQ0NGdVWnhi?= =?utf-8?B?UjhyNVZ3VldTQ0N5WWZEVWNFSFlSYlZycEd4QVZQemNTdjlnMDRFeUhyUzBM?= =?utf-8?B?TlI1SDM1K2YzNmxyMWJUZkhpbDZneGFpV1NObnJkNmtLcERMNDdNTmMrRHRF?= =?utf-8?B?VDdNRUpSMTlFYkk0UGZhNGFMSjF4dmZ1Q2F6TzFCZThpS3UvZVE2T3NZQ0o2?= =?utf-8?B?UmNVT0pLamFOMmRqMmJWMFdVL3Fia3d5S2hJOUdUaWlabmR4RVNOOTFyZE5B?= =?utf-8?B?MUd3MGRXSnRId1FMRXlPaXlpYnpHc2F4d04zWGo0WE5sN3lEZlV5ck1Td1VX?= =?utf-8?B?MW1qWVlsQ1l6ZW9qdGlCUjBxYXNIVUVwNUcwLzJ1a0lGOXZMWU9hRC9heGRT?= =?utf-8?B?OEJ4cTNoNnBZeHpWRUVhUmNESGlYYVFHYmIyU1pycjExM0JVcXF4SS9HZzFa?= =?utf-8?B?TVYxamtrRjFadmpXVGREbUJqMkdQODMreVE3R3d4Z3Z6ZTAvazV4NWlKaVNL?= =?utf-8?B?RDNyYThSM1ZWdkZHR1JGQWpwS1FFWktnc2hsNm5KSTY3WVhtY3lsWTZRNkdX?= =?utf-8?B?V0phNWI4TEpJclhnV0t5U3FjbHp3YnpZQk5PTzBoRzdJYWovMjk1UFpLcGhv?= =?utf-8?B?andycnUyd1F3Q3ZKcWdQbDRDbjlrMDZWTWNFTkJuM1p2MHhZVFNUaUhZbnZ2?= =?utf-8?B?OXIzUGdWVmU4N29FTTRFQWhoMkdkS0JCN3VrOW9talF1SWlnTUdiajd1ZFdN?= =?utf-8?B?TmZ1TVFwVTNXclJ2ZEhublZMOHV1b3daSTdPeVBSTlBjWEowY2pZU1JwSm9o?= =?utf-8?B?QzhKNVd4MTQyWWZ0SEtHMTFSd2FWVkIrQTRNMnhGcC9vSnBqUVFKUGY4NkpQ?= =?utf-8?B?WEZjRmJtUDVtbEZoUk9KOS9CcVNXQ3JhbmgxcDlNK25mNXhMMTFUdmoxdnZ2?= =?utf-8?B?RmFUeEZJdERkcEdYaWlQMSs0cTJCbHcwZkJlUWYzRXVUSTloZmxBY0RrVmNp?= =?utf-8?B?Wmt6anF4R2hhQ0ZTdnlWTnZhUEVPcTZxVy9QV1RMNm82THNwODExazhQVUh2?= =?utf-8?B?Szg2bThuR0dZN1E4aVU3ZUY5RFBCMUN2aWNMUis0ZmhvbEgyZlJCdG9zaWJH?= =?utf-8?B?UVhCMkp5SFZrdVVYSjEvZDdlbCtvUE9tNlVTVTVuN0pYNXdPZDRVV0ZHQzNL?= =?utf-8?B?MVlQRUZoQk5OMzVObmtlaURaRERWU0RBa04xL0gzRElWaXlpRnJJOGxlUG82?= =?utf-8?B?a3gwK3NMV3BSZDFnQ2xhZER5OTRwVnRWSHc2Vy9mYmd5eEVhbmEvang5MEZ0?= =?utf-8?B?YUQ3UW9TM0pmdkE3Z2JHYVpxWWlqbEV1U1A3QlJQVzZyWFJDWFMwQmZaSzVr?= =?utf-8?B?WGFMaENvV3k4RXc0NjNXWXdFTGpMNmh2T3JlaG4rbk1JNS9uYkFtSHZXU0RY?= =?utf-8?B?YWpKMXJWVmlpYmpJY2NDNTFMVmp5OTdudHBXRFZNSHJmdFp5dnBJM1orSm83?= =?utf-8?B?dDBsc1dVeGNNSnJnaS9jSm9mTlBWbElObWFlZ2twVkl2UmdBbHpzMUFHQ09F?= =?utf-8?B?SDRSTnZXOUVLMndqU2tTTkRIUXhkL0Z3aGJyR1NIUDJ6UEFnWHlRM3NMVkoy?= =?utf-8?B?bzhmb3hmTnVvbVVGb2pyWkcwcjVHUkVEbnpVQzFQOWpwT0dKUDFadGlVcDVl?= =?utf-8?B?YUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1108dba3-efed-44f4-5c83-08da9593942a X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1629.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 14:23:50.7850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qn2Sn67UYYgcArmpFRYiakuzQvjulSBXjyRhi7av/fZW9pyeJTY7sUor0nfFwbjDRMmT6P+OOvzCQtHrIFY/iG3RGMF9ay9ozsxlyTdiuCE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6080 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 13, 2022 at 01:36:42PM +0000, Juraj Linkeš wrote: > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Thursday, September 8, 2022 11:53 AM > > To: Juraj Linkeš > > Cc: thomas@monjalon.net; david.marchand@redhat.com; > > ronan.randles@intel.com; Honnappa.Nagarahalli@arm.com; > > ohilyard@iol.unh.edu; lijuan.tu@intel.com; dev@dpdk.org > > Subject: Re: [PATCH v4 4/9] dts: add ssh pexpect library > > > > On Fri, Jul 29, 2022 at 10:55:45AM +0000, Juraj Linkeš wrote: > > > + self.send_expect("stty -echo", "#") > > > + self.send_expect("stty columns 1000", "#") > > > + except Exception as e: > > > + print(RED(str(e))) > > > + if getattr(self, "port", None): > > > + suggestion = ( > > > + "\nSuggession: Check if the firewall on [ %s ] " % self.ip > > > + + "is stopped\n" > > > + ) > > > > I'd suggest using f-strings here to avoid splitting error messages across lines. > > They can also be used for strings above too to increase readability. > > > > We should probably look to standardize all strings used in DTS to a single format > > - either f-strings or the style given here, rather than using a mix. > > > > This is one of the many things we left from the original code to facilitate discussion - would this be a requirement or can we skip it (possibly changing it later)? I prefer f-strings everywhere and I'll change it where I can, at least in this patch. > Maybe we could do this one patch the best we can to showcase what the code should ideally look like and possibly loosen requirements in subsequent patches? This will leave technical debt so it doesn't sound good. > Yes, I can understand that a huge amount of tech-debt has built up in the code, and it's probably a fairly huge undertaking to remove it all. On the other hand, this move to the main repo seems the best opportunity we are likely to get to try and clean this up and standardise it. Therefore, I'd really like to see us use f-strings everywhere. Is there a style-checker that can be used automatically to flag older-style strings?