From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58DCCA00C3; Tue, 20 Sep 2022 11:58:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0384940DFB; Tue, 20 Sep 2022 11:58:57 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2133.outbound.protection.outlook.com [40.107.237.133]) by mails.dpdk.org (Postfix) with ESMTP id 0B1264069B for ; Tue, 20 Sep 2022 11:58:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IddoOBKCTZ3WqoTPy2/uL7UV1s1ut1CJvt1wDn5e6y573IhreHO/ucxLjaKxzlCqHfCiuJjLAgiwua5vBUzi9zGXZLVpIgvvqDqNr0XWV22P90TOSAkL6qyE7jSBOoAL0EXggdGlNlQYb7szW0WhNBWVykVaw63s6c2BPlEiXwykf1NLhMKg4NYzgheo+45wrh182jEiO62eVsVmV7kJ28zyHtFZrJO0iXc6x74s3SzXCv7WLyoEZb+4uFqc8Bb0dbXpzdEr9+GyxSuSeliDAq2EIIv6qmG+C48YtFvT+6DjqL5brLxdTftRQNT53AQbbK3fdAXqGpukvG7WnSNapg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+uElXR0YtXhjQ4FzmnIk4dQWt9byCMP4luORj46S/28=; b=LZjiKwIy8yUq31fbHd7Tyj996x7h3HeY4e2XHJMEtz+HfOur4VLreVdufMDcwAftf0IA91v+0KdtaZEYGijnZjaEU+87NIhFn0BzXVFVVRzmhr0MkxrCMegFoMuiCHWfFmNDGo5NGRvU7YRD57GQq0WwobAA98zcbN4is5D3xQTrQqKZNikp/oNRHJyHmgmrgDqhKbzpkAgZSPI1rDfgK5kuaF4Mj0kA0Z/Ub5R874JoDp5j2n+n4ZE0l153OGii2BjuOJ3gof0y70nsf87vcSpiMemKlu3LHWCys//cZm/iy6Gow/NXE+B9PmAVQkpuI33Q23ZwneW6sWymZgdtLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+uElXR0YtXhjQ4FzmnIk4dQWt9byCMP4luORj46S/28=; b=ZW11xgv8ldjUrvkW8A1GWwjNlhg7Rfhpee7o943vrv55oSUg7k5lRD7YAbwoBRI9Cjxu2x41XbrmKGMtNFlsSB7mNJgOV6wRN6aRInQPOx3JjrbP2OtQC/e1Az7Nkr5SFM+Am+kn334C9u53KpbSRaEyvUmWVc4YO6ZIAMlh5fo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) by SA1PR13MB5444.namprd13.prod.outlook.com (2603:10b6:806:233::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 09:58:54 +0000 Received: from DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::e198:fd7c:5eb4:89c1]) by DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::e198:fd7c:5eb4:89c1%5]) with mapi id 15.20.5654.014; Tue, 20 Sep 2022 09:58:54 +0000 Date: Tue, 20 Sep 2022 11:58:43 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: dev@dpdk.org, oss-drivers@corigine.com Subject: Re: [PATCH] net/nfp: improve readability NFP HWINFO header Message-ID: References: <1661492343-23225-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1661492343-23225-1-git-send-email-chaoyong.he@corigine.com> X-ClientProxiedBy: GVX0EPF000013E5.SWEP280.PROD.OUTLOOK.COM (2603:10a6:144:1::25) To DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR13MB4431:EE_|SA1PR13MB5444:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b749752-a8be-401f-ccf8-08da9aeeb9f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SZoESfxGcR2Vv+6whz28B9jw0yllx2ypSobB4vL4XNKjzBfLBP9v+D8XMEXMJmywIUuXbctvECymZxxHcRDZca1Oek+PE8nmKCWPFBKmaqocT1yXPgwLKXWH+xsVQSH5/mY4RdO8RucS2YTfGyOG1fJ4gMp9j02SWO+FcDg5QrQkY375eYo0cHnFZmZp0lOd4m7PDZlVJ0M+vmB/rFBTF7sWIZuTd0Cc5v6hiRxHQudX7SoTpRXeWybetuHXHXni4GkAsLHPx8JZFPXsh1DZW7HIo7RZqjR2JRBu7ySJ1Lx5Y7gFQoS7thf43tMlhxFEPb44yxRA/YWH9QdoWO74v6i1bdbmTyRd8KpuetGde+rdGZGLxYiGyq/32RtiL+8NZwqoKD1Ytw35/+7rodxySXJAOovnVxTQfOLpcC+QAwSWXqo0b0N/XZeOFRmGBDjVOYOEKlzl85cvSicSQ+JyWlLDHvNmIe2IHNvdaOiRK4lRFSxddUD1mxGLpmk7cgYYBoCWWxETKV03PzMUwhQL+AKVsXojmtzeiuM5/l85mEuRsAxGPOY0yACJYcMHTvajn68+G6kigP+emmNnrZQc5b5yhFZkk3GsnL3uztigKIfSVQUP1lniJngdaHXCpgplL8plLWhR2KIEMviR6gHv6uTr6vuA867dVbW/Dac6nUjV/KTntMQEWf5UlHVIEEriv4EsY010JILsVLpq1pM8aWcNZlAwjZ6tLybkKQxFHy3VBQ8fPxIpEE4rcbHqP2yf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB4431.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(136003)(376002)(396003)(366004)(39830400003)(451199015)(6486002)(41300700001)(8936002)(478600001)(8676002)(66946007)(66556008)(5660300002)(66476007)(316002)(6636002)(86362001)(38350700002)(38100700002)(186003)(6506007)(9686003)(6666004)(26005)(6512007)(52116002)(53546011)(83380400001)(66574015)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?tAJYILNE8udTG90K/a5IB30tmSOrCTjmA+62v8elxDTMBncXn8oMZeTQEd?= =?iso-8859-1?Q?tHXjfaLS0fd6yHF+fyFCrF5MspdBmzrcJ1OP2NijiJqikuSBBBQYq3bSvK?= =?iso-8859-1?Q?DYIwBdzrSHEwx6004SkUk+dM+4G0yGbxkSiCbjLA/KF2QgKdu5ZX6VNfY3?= =?iso-8859-1?Q?ZUCc5Y11yDbCDggPak+vqqhWBva3x9ttsunRjY35lIL794CgJgFnl2HDbP?= =?iso-8859-1?Q?T1AB3hpkoCfTaaeellPBx7Ygglkhl4Np2PPAJtTR5UNRaiAX8qrKKbcmDp?= =?iso-8859-1?Q?URzzH52LQFH0HfdZaSh66NtfKTMW45Ge5V/k9GmlciTAGKsToc9uKvfwv2?= =?iso-8859-1?Q?WdzSRHEqnjIdG6RCGLEddB+sQ7pFN8NoTnksiQZ7RRFHg100Bv8FtBpP5w?= =?iso-8859-1?Q?8kUIiMmxPiZZzc78F3jKzs8C4ODT1U0SFPJ5777aZaSRTNwG6fQWmFH1i1?= =?iso-8859-1?Q?ZJGC/Te/R9aErQshETLNuXCMrbD05D3QNOVLv/er1vGlTGhPSCdf5qLggj?= =?iso-8859-1?Q?NJoBQokmjl55vL1ex/kK+gXq3GyLCSM0MNT3WI9rtkYGX8HTgssvDX3qqb?= =?iso-8859-1?Q?1j3C4vdbgkUNGy+yE4NlRtZwhPG14Y3qwk6lSJNhOpO91PkIGjYWCp+9hQ?= =?iso-8859-1?Q?ePTBa6UIduGkmzMsMyHPo4d68KAoOyVPJgVZpR9AXlNWl5frg9ZC29daA0?= =?iso-8859-1?Q?gQb5e1EJkA/731YyOjrghNhRX03QoainOiaXVIIsDZwSo5uQ1H50D/lut9?= =?iso-8859-1?Q?qR88PpSp++FohPzYFw6JdmLIom6BgwRpgheiGCzu8Ljh6Cn4cQyZ8qkMuM?= =?iso-8859-1?Q?NmLt25ASwaKQRiH/xwdmVloqZj/pKu9HFRuBFsqPZ66ubgfhu4MfKLnWXQ?= =?iso-8859-1?Q?a4hi1MgHYRiB50sUSPa2sWqtxxChkY2IEH+B0Euoi0o9RNWKDICxLAHFda?= =?iso-8859-1?Q?/SJzCvrVTsKh/ndxysF/9650+KWD8BE0m69cvT1CM4oZ3mo4zH2jou6jGB?= =?iso-8859-1?Q?qNwk05rAOUJb3IO4NR1SRAN4auFH7gjYJd2Qjq56X+R9ceT6XPfHRliUU4?= =?iso-8859-1?Q?VEc4d0sa/iguR31CrAtRnfX6OcmGhh7BYeb05I4TuNQDzUSga0Bw7amOQq?= =?iso-8859-1?Q?riuY1bJouovO53vdZ3dabbskgGYNiwueAUNRBwRr7Xbds0l45PJnQH33/p?= =?iso-8859-1?Q?utP70lVvqAQKwJbZhOKEqhUO6MbjUfq1aOO5zMiwqSvJ3XFhcRST2hKq0z?= =?iso-8859-1?Q?R1+8P9bqnW8BF9AeaEi9D0xk3z2LIRlcCxien2IwI/RUNf04t/7regsPdY?= =?iso-8859-1?Q?DpA3tQ4KokkxQjaeNs5xaAbJRnn0j/PkHxoFjL3PjJLTsm14g1zDfmE1xx?= =?iso-8859-1?Q?f8mkEoQhHmH6JxZrNFSjc4LFjbYBfPF2ULBS1OUXCeKmxBFE+87B6E6FGy?= =?iso-8859-1?Q?stdipCI8fx7VAtSdjMMMGJ6wr066/C+St9L4XM9XKvZ4ri3W35c9H6+vvQ?= =?iso-8859-1?Q?yGNOzEdmn/FXGz+Np9uHbN5J5SL1YpKARkjgA1cVQEAjKtSwrWfhHfQB9r?= =?iso-8859-1?Q?Vrk3jVuSz1vP6j6cG8EhCuGuh/ROh6p9rBakdOe00YHCs3KfK2mtvQ8Flh?= =?iso-8859-1?Q?XuZuuQnoUuhLvm0LlGGoHgMXSEGmwz/yh5P3xaRCYgwcpGWHY1tmJAvQ?= =?iso-8859-1?Q?=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b749752-a8be-401f-ccf8-08da9aeeb9f4 X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 09:58:54.0005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D/0iOjgZ0qonYW2HoD5qyqH+I42eOPxro5qQ8POSouUBpNSRjRwODKnwArGyj4lgA1qmph/2aQTKrjwOVJgHdnkDlxu1UsG1+T8RXQSAb6g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5444 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi all, Gentle ping. On 2022-08-26 13:39:03 +0800, Chaoyong He wrote: > From: James Hershaw > > Prepend `0x` to the NFP HWINFO header value that is printed to improve > the readability of the printed statement. > > Signed-off-by: James Hershaw > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfpcore/nfp_hwinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/nfp/nfpcore/nfp_hwinfo.c b/drivers/net/nfp/nfpcore/nfp_hwinfo.c > index c0516bf..9f848bd 100644 > --- a/drivers/net/nfp/nfpcore/nfp_hwinfo.c > +++ b/drivers/net/nfp/nfpcore/nfp_hwinfo.c > @@ -108,7 +108,7 @@ > goto exit_free; > > header = (void *)db; > - printf("NFP HWINFO header: %08x\n", *(uint32_t *)header); > + printf("NFP HWINFO header: %#08x\n", *(uint32_t *)header); > if (nfp_hwinfo_is_updating(header)) > goto exit_free; > > -- > 1.8.3.1 > -- Kind Regards, Niklas Söderlund