From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BE2EA00C3; Tue, 20 Sep 2022 19:51:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E8CA40DFB; Tue, 20 Sep 2022 19:51:11 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 5FDB64069B for ; Tue, 20 Sep 2022 19:51:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lhc2BIKBosQc5bUE7eTRZuAxrVpL8ssiMVjH/c1I/Yf/K0wItVNn+E7NCqUYR2oREE39P9ffVub0fQ7+0PTodT6a+HR1i6QqNoEDCHBr5so/a203mImPSwfwkshX6FP1E45NoSSsao0OZg15BQnlumGgZewXB/3PwH9mW1mPtRGRxgS2RFi9MBS9OJAghmf9rhb4tt1FbTl22SXYyeLpGASf9cqd4yZLvF+31Fv1o1Sz1qIFcVQX2Z+Bqe9WyZu/k4vGz1ylhTHHcPAGEzCjLbtN2mHxJE66r6vtmZGzTHTUuhv3KyP/SJ4vzE4X6X7R2cWL4H+3pJCTJgWKAKyNRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+0UfwOoskVjzni6d+4+2LrJbJX9kAco5DUDCouZ3E/0=; b=NpyM6rY4a1duXlvjT8b+wdpjwxXLF8RASdKs5YRaO/aTC61LubaXAQhoZnSsjFaGTy4KAmhmcslRbix0m43NqbwwbtNFFh28LmVlCeFyICZJnsgzHjE2eM5esDnLbF2SntwcIh66SMYmRxbdCkvpOOk3TGbMaWVjs4SMdPZHzK/kLIMZWf8cqbiKKW6FSQqv8GalS114ofUmv4v1scVUpWwhceE/6su85HC+CniL6g19jYEB3aapgz1Otj6Gcxl2MzooyNn/6j2NkhsDSxkeyysN11Yb5GXzONbZPjoDEYmXkQQ9zFrEKMsh/Jl5h5H5zbOJyFDO7QlWE3ukZQqIWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+0UfwOoskVjzni6d+4+2LrJbJX9kAco5DUDCouZ3E/0=; b=dc+kjHog5v0i6NvRewjOBMn9Ay8NxCr0H3eEWVSPczzsntVLonxbkDIDwoyP0ua1uPeif+D8ZRcnR/h8NslLKeaqTuuZXtK2i1VDA09VaDxoo/PhHNYs/KYAdfVCS9I3/Lq1pIQOsIZ6cVnb9/DVJDFP9kMP/gVAEMdwp2p1kIA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) by DM6PR13MB3924.namprd13.prod.outlook.com (2603:10b6:5:28f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 17:51:09 +0000 Received: from DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::e198:fd7c:5eb4:89c1]) by DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::e198:fd7c:5eb4:89c1%5]) with mapi id 15.20.5654.014; Tue, 20 Sep 2022 17:51:08 +0000 Date: Tue, 20 Sep 2022 19:51:03 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Ferruh Yigit Cc: Chaoyong He , dev@dpdk.org, oss-drivers@corigine.com, James Hershaw Subject: Re: [PATCH] net/nfp: improve readability NFP HWINFO header Message-ID: References: <1661492343-23225-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: GV3P280CA0026.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:b::14) To DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR13MB4431:EE_|DM6PR13MB3924:EE_ X-MS-Office365-Filtering-Correlation-Id: 901ab98d-943d-4743-f029-08da9b30b2ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0oaz4JQI/piUnn7+aandUmvpUldTTrAAhzueD/XLv6dd7LvxuzcqVoiPOHCg+VFsudjZ9SC9vP72MkZd7GHrecOeIveTcAGucTL+KztqcIEdKMgy91F9ReHtuFVlM9nKtHmy4RgJugorVhSDfJO6+O9bYGqVPU9qzdP/uDUtBC3fIf8rMCcyjTJVhOAPJ37knSJBo1wb0IZvApQz6cK0py1+Ab1CA9qtW08mj+G2QtQH7IinAOzOAah5d6xm21uohebqHZ8N5VsOWnzZHDXadtBIpSBeQRobXXobXYwl7X55Ombsbyv3VxiWZHXNtuwetGQ5KXd5I24/+bDZjes92TkImpKcXOPiSAX2MF4wTAXLqVvNy2sLeQUmLV0OAUsaH5lLQy/2RcPCC2u7xP50HoVmsuOgyOjqxHXDZo6lywfTxQvhM28AaMVuTIcol0GqIJp3AcBIXTmezjCbU8GKdNi14VgNYJqHzQioCw4t++0OObZchbnF/dQSEXSzT7xFqK7B5+Qpnv4tNIQEzOk2Sqsc0cjd4IMGb7wgKzjffbV+e6D9+TqwPWmEjOPIRtVmGqSjENjVzFSwq3ll7bFyHfMO4V6rpnotSmufrbOqKnU4XAUOsQdEO5fObXxIuG9QDpMMZuclaYm4VdfSB5ntthXPQairYGEsyeRX4KTnbf2oKtf5yf/JvgeoKYtA9FqaWJflWxH6tg7YS1oGtaubVXmMrgEuSZ3SKmCN1ohLMGkwgVgL78AofYQC20Bmc5bdbJXM00F+mtmx6kenKyyphJjmguAJkNZ1xFv+bWjc7wY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB4431.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(376002)(396003)(39840400004)(136003)(346002)(451199015)(38350700002)(83380400001)(66574015)(186003)(38100700002)(9686003)(41300700001)(5660300002)(2906002)(8936002)(478600001)(316002)(53546011)(6486002)(52116002)(26005)(6512007)(6506007)(107886003)(8676002)(6666004)(66476007)(66556008)(66946007)(6916009)(54906003)(4326008)(86362001)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?B+LIWNLQyR5Jvi/oONRYIaIST4voaftsgwrOXS5PBw+qcW81vJdvYnKrDR?= =?iso-8859-1?Q?6YVZKyToMp3T+EB7cm7+eNqV/87k3i6xGEzOY+wZ7SAA/SEy93dMxWaUkw?= =?iso-8859-1?Q?r8p4AZhW5hkoiN467mWLHOGrHqyi5nAAHgPoc10dDGUie+lTeBSbnkXtzZ?= =?iso-8859-1?Q?s8FrBJ+77m2q7nYYDgqk9M7RuAFFEZENC+T43rMMIG+h2ndezjozooX3/k?= =?iso-8859-1?Q?l0kOVVFNZXNY6QByXXXLX/VX6Y2kXPufbN4iucmDhEdv8QCsTL1MAiFzKC?= =?iso-8859-1?Q?2TiYQlXRSK5/SHl11x/FJYPJ6kjGHDToPhLxhsuBYVUKndqC+//sxk6ecp?= =?iso-8859-1?Q?1oLTIDHYRNGVe48QykBdceWqsFEtQQ9PT55q6wLxm/IfOvy+3p6HSdD+xb?= =?iso-8859-1?Q?tUxpU7iLbrIxUZenx/x6a50BXKIDlfT/vvjqW5IvaFt7wvM7KTNzoPmtqO?= =?iso-8859-1?Q?UmSMAPfCFbRwf+K2lWhrewQ/L8OYu82gyLC3wSTYXeZOYLT9OL8MIRmeCK?= =?iso-8859-1?Q?ra73l/3EjHFUtzY0V5dWMunxtUN4G+GesXsWMZ7VrVkHi70l2e42y3pKEh?= =?iso-8859-1?Q?XsYaOyi2EdECcDhllvZE8QqR52XQQSOZKaa0lJHVSfOuh5XLLl7nbtybk8?= =?iso-8859-1?Q?5Rr52NJyn0V5HcFYhpIe3I5iGCf7UYFNokMYy7mbhn54eC6AY4qkuaFoEb?= =?iso-8859-1?Q?K75QXBePziWBv4SmE46OVi/VZhtL04snDEusxc5ds6I/H6Bl4MXJx3azc1?= =?iso-8859-1?Q?0mrkI/Td7YFslowZ6+ZcHyPoj4yO2hIC3Lz8+ybgHosK/AkGiDaMIj+xsK?= =?iso-8859-1?Q?3pR7XQt6IvmOSC3gjvZWcQ03vdakSIqbIC5TWJbnkeSpEI+VXYe+S8qwGT?= =?iso-8859-1?Q?pcZ5Jyi0fCuGNQj8LIuvJ7S4H3YJNxoW+yKnyauDuvdxFtb2TMTittte4g?= =?iso-8859-1?Q?QZyfOrQ/TPiMqEOGzo/rpvx1nmpUJrQe0mYgAoJwK62STE7z4SXzleeXCs?= =?iso-8859-1?Q?5qT3o9gpjVEPkuumQg2DPs86UroyzfZZwNpsAG5TBXj9aKlShxT359zIm+?= =?iso-8859-1?Q?bUz1P+oQzcd24/HamDCe0o/eu8SzvXwcbo6fwt4I12e4TaePEoWF+qjQJq?= =?iso-8859-1?Q?kLfLfRr8qJzwXyHg0h7ZgZ7KDl9SvVmX5ZJeuIXFSr31xiOcuBPYrG/1md?= =?iso-8859-1?Q?JjmUBF4AKdzlNXWNuR1btvDc+6LryLPGzQtkuxVyWBwQC5qT4MMFq5zUaX?= =?iso-8859-1?Q?A/raLrOj4SYFTWs0QhcVpECnpoWR+Vbz0FJIoORngyyRI9aAd+rH5HZkkX?= =?iso-8859-1?Q?OZSk0RaNnoVoCbcR5YBVRJ48hpvNi0dWPs/pU7mrT0MkFBYQchyAt8N7zG?= =?iso-8859-1?Q?RGw4cGUT0E9wbS+JktbRzMtHgQoEdIsUjQJ6yEPE2EP+x/EBkM2oUQ5dG1?= =?iso-8859-1?Q?KqaPMU9kygOg8c5UgrrO3Sr58gAS+hNhwxAIbj6ct9csaO8o1jLxz4Z7TX?= =?iso-8859-1?Q?VGx3aQorZ/Skd9ienToemiMcXvh6pl58chfPgEgDIjEInXBEs3jsHVHnu6?= =?iso-8859-1?Q?p8EjHUXRROfKtb+fpJS+gR9P0Q4wlBtKi4ALELDI0DMwt6WFa8uS/IowrN?= =?iso-8859-1?Q?UfgqD9q3Xoj8qeqMQz4zuUNs4O/30qLB9aaulG4hQ5sjL5tJLaQgRKIg?= =?iso-8859-1?Q?=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 901ab98d-943d-4743-f029-08da9b30b2ac X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 17:51:08.5853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2S+aIP6x7FQAadhZRw2bhu5jg2hK9LzQaPjo6KNLTO7h4psH60n4UDVVCwlyfBGwkifVXmsLtHjWZg49lr/eQPYHMqfug/5bshUN4bVuJ1Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3924 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh, Thanks for your feedback. On 2022-09-20 18:33:02 +0100, Ferruh Yigit wrote: > On 8/26/2022 6:39 AM, Chaoyong He wrote: > > From: James Hershaw > > > > Prepend `0x` to the NFP HWINFO header value that is printed to improve > > the readability of the printed statement. > > > > Signed-off-by: James Hershaw > > Reviewed-by: Chaoyong He > > Reviewed-by: Niklas Söderlund > > --- > > drivers/net/nfp/nfpcore/nfp_hwinfo.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/nfp/nfpcore/nfp_hwinfo.c b/drivers/net/nfp/nfpcore/nfp_hwinfo.c > > index c0516bf..9f848bd 100644 > > --- a/drivers/net/nfp/nfpcore/nfp_hwinfo.c > > +++ b/drivers/net/nfp/nfpcore/nfp_hwinfo.c > > @@ -108,7 +108,7 @@ > > goto exit_free; > > header = (void *)db; > > - printf("NFP HWINFO header: %08x\n", *(uint32_t *)header); > > + printf("NFP HWINFO header: %#08x\n", *(uint32_t *)header); > > Why driver is directly using 'printf', but not rte_log APIs? > > I can see there are already 'PMD_INIT_LOG' & 'PMD_DRV_LOG' macros for this. We have a series ready to convert all printf style logging into rte_log APIs as well as fix some other style issues. We also have a few other things in our internal patch queue waiting to be sent out. To reduce conflicts in patchwork we are sending them out in the order as some of them depends on each other. And the one cleaning up log messages are at the end of the pile unfortunately. Do you think it's acceptable to take this fix as-is and then a patch that convert all printf on one go, or would you prefers we move touch this line only once and create a v2 of this fix while also moving it to the rte_log APIs? -- Kind Regards, Niklas Söderlund